[android][a11y] set "android.widget.ProgressBar" according to semantics role#183897
Merged
hannah-hyj merged 12 commits intoMar 23, 2026
Conversation
github-actions
Bot
added
platform-android
chunhtai
reviewed
Mar 19, 2026
| // TODO(jonahwilliams): Figure out a way conform to the expected id from TalkBack's | ||
| // CustomLabelManager. talkback/src/main/java/labeling/CustomLabelManager.java#L525 | ||
| } | ||
| if (semanticsNode.role == 23 /* ProgressBar */) { |
Contributor
There was a problem hiding this comment.
we should define java enum or const for this
Contributor
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
I tried setRangeInfo and although we can set them, it won't change the talkback announcement at all, should i still set them?
Contributor
There was a problem hiding this comment.
Have you tried local context menu? I suspect some additional action may show up. Also there is voice access that possible uses set Progress value. If you want to be sure, will need to do a code search internally to see how getRangeInfo and set progress value are used
Contributor
There was a problem hiding this comment.
I did some internal search and also with LLM and still can't locate where this action will be dispatched besides they put this action on their own progress bar.
I think I will still slap it on the progress bar just to be safe. Could also asked in yaqs about this.
Member
Author
There was a problem hiding this comment.
looks like ACTION_SET_PROGRESS is only for seekbar(slider) not for progress bar.
did some code search internally and it looks like getRangeInfo wont change any announcement in progress bar but may change announcement in seek bar (slider)
for progress bar specifically, setting range info will help setting the progress bar role in android if we didn't set it as "android.widget.ProgressBar", but wont add some extra announcement like "from min 0 to max 100", or "50%"
Member
Author
There was a problem hiding this comment.
ProgressBar is like a progress indicator with no action
Member
Author
There was a problem hiding this comment.
I think we should add a semantics role in the framework side for slider to distinguish it with the progressBar, right now we use the flag "isSlider".
Contributor
There was a problem hiding this comment.
oh yeah you are right. I mixed up both roles.
Contributor
|
Warning Gemini is experiencing higher than usual traffic and was unable to create the review. Please try again in a few hours by commenting |
Member
Author
|
Added enum and rangeinfo |
Contributor
|
ci is not happy |
Member
Author
|
ci happy now |
chunhtai
reviewed
Mar 20, 2026
chunhtai
reviewed
Mar 20, 2026
| } | ||
|
|
||
| @NonNull | ||
| public static Role fromInt(int value) { |
Contributor
There was a problem hiding this comment.
should we use this as part of JNI serialization?
Contributor
There was a problem hiding this comment.
or just remove this since this is linear search and may be costly
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 24, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 24, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 24, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 24, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 24, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 24, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 25, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 25, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 25, 2026
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Mar 25, 2026
…11345) Manual roll Flutter from dd64978dfae1 to 82d96ef98a33 (89 revisions) Manual roll requested by [email protected] flutter/flutter@dd64978...82d96ef 2026-03-24 [email protected] Fix RenderStack's documentation (flutter/flutter#183822) 2026-03-24 [email protected] Roll Skia from a465876e3156 to f4e59f82dc69 (4 revisions) (flutter/flutter#184082) 2026-03-24 [email protected] Refactor: Removes Geometry field from ColorSourceContents (flutter/flutter#183952) 2026-03-24 [email protected] Refactor layout dimensions (flutter/flutter#184066) 2026-03-24 [email protected] feat: Add --base-href support to flutter run for web (flutter/flutter#182709) 2026-03-24 [email protected] Add LeanCode and contributors to AUTHORS (flutter/flutter#182997) 2026-03-24 [email protected] [tools] Make sure `assemble` has a pubspec as cwd (flutter/flutter#184067) 2026-03-24 [email protected] Roll Skia from bf4f2763b6e6 to a465876e3156 (5 revisions) (flutter/flutter#184068) 2026-03-24 [email protected] fix gaussian blur getting clipped with negative scale (flutter/flutter#184037) 2026-03-24 [email protected] Keep glyphs for variable fonts (flutter/flutter#183857) 2026-03-24 [email protected] Mark `IconData` `final` and `@mustBeConst` (flutter/flutter#181345) 2026-03-24 [email protected] Roll Skia from 62841a512deb to bf4f2763b6e6 (1 revision) (flutter/flutter#184062) 2026-03-24 [email protected] Use Color.a instead of Color.alpha to assert the opacity of the color… (flutter/flutter#184003) 2026-03-24 [email protected] Roll Dart SDK from f504293598f2 to b08bd0a3ee39 (1 revision) (flutter/flutter#184054) 2026-03-24 [email protected] Roll Fuchsia Linux SDK from x9x76ERXhrt0Q3zKf... to M3sjWggTQmP2AD4bS... (flutter/flutter#184053) 2026-03-24 [email protected] Roll Dart SDK from 788e347194a6 to f504293598f2 (1 revision) (flutter/flutter#184048) 2026-03-24 [email protected] Roll Skia from fb6acef456ea to 62841a512deb (2 revisions) (flutter/flutter#184046) 2026-03-24 [email protected] [Slider] Remove value indicator painter when animation is dismissed (flutter/flutter#182991) 2026-03-24 [email protected] Manual roll ICU from 7971660ba630 to ee5f27adc28b (1 revision) (flutter/flutter#184041) 2026-03-23 [email protected] Add scrollPadding property to DropdownMenu (flutter/flutter#183109) 2026-03-23 [email protected] Roll pub packages (flutter/flutter#183895) 2026-03-23 [email protected] Roll Skia from c2b58922e37d to fb6acef456ea (1 revision) (flutter/flutter#184033) 2026-03-23 [email protected] Roll Dart SDK from b172bea4f008 to 788e347194a6 (2 revisions) (flutter/flutter#184035) 2026-03-23 [email protected] chore: deflake Linux_android_emu android_display_cutout (flutter/flutter#183522) 2026-03-23 [email protected] Add note about gclient sync network failures and workaround (flutter/flutter#183794) 2026-03-23 [email protected] Roll Skia from a81bf411a5cb to c2b58922e37d (3 revisions) (flutter/flutter#184016) 2026-03-23 [email protected] refactor(web): use positive logic and platform defaults for accessibility features (flutter/flutter#183907) 2026-03-23 [email protected] [android][a11y] set "android.widget.ProgressBar" according to semantics role (flutter/flutter#183897) 2026-03-23 [email protected] Add progress bar to artifact downloads (flutter/flutter#182836) 2026-03-23 [email protected] Add windows instruction to `Forcing Flutter Tools Snapshot Regeneration` (flutter/flutter#183977) 2026-03-23 [email protected] Roll Skia from 42a6eb1dc5c9 to a81bf411a5cb (3 revisions) (flutter/flutter#184007) 2026-03-23 [email protected] Roll Fuchsia Linux SDK from q1xqlQPxq8a3JTA4P... to x9x76ERXhrt0Q3zKf... (flutter/flutter#184006) 2026-03-23 [email protected] Roll Dart SDK from ef45f179526f to b172bea4f008 (1 revision) (flutter/flutter#184004) 2026-03-23 [email protected] Roll Skia from 964c3b33fd73 to 42a6eb1dc5c9 (1 revision) (flutter/flutter#184001) 2026-03-23 [email protected] Update the windowing docs per the latest wording found while doing Satellites (flutter/flutter#183748) 2026-03-22 [email protected] Add assert for mutually exclusive errorBuilder and errorText (flutter/flutter#183901) 2026-03-22 [email protected] Roll Fuchsia Linux SDK from Yc7Ijp2ySjG841xha... to q1xqlQPxq8a3JTA4P... (flutter/flutter#183991) 2026-03-21 [email protected] Roll Skia from 812822ad5caa to 964c3b33fd73 (1 revision) (flutter/flutter#183982) 2026-03-21 [email protected] Roll Dart SDK from c831a55e2fcc to ef45f179526f (1 revision) (flutter/flutter#183973) 2026-03-21 [email protected] Roll Skia from 569cc0475162 to 812822ad5caa (2 revisions) (flutter/flutter#183970) 2026-03-20 [email protected] Roll Fuchsia Linux SDK from ilAIAVzu4xmeb078x... to Yc7Ijp2ySjG841xha... (flutter/flutter#183956) 2026-03-20 [email protected] Roll Skia from 79a14289c60d to 569cc0475162 (3 revisions) (flutter/flutter#183954) 2026-03-20 [email protected] Roll Dart SDK from c88a8008e93b to c831a55e2fcc (3 revisions) (flutter/flutter#183953) 2026-03-20 [email protected] Roll Skia from 8d4c76b92050 to 79a14289c60d (4 revisions) (flutter/flutter#183949) ...
okorohelijah
pushed a commit
to okorohelijah/packages
that referenced
this pull request
Mar 26, 2026
…lutter#11345) Manual roll Flutter from dd64978dfae1 to 82d96ef98a33 (89 revisions) Manual roll requested by [email protected] flutter/flutter@dd64978...82d96ef 2026-03-24 [email protected] Fix RenderStack's documentation (flutter/flutter#183822) 2026-03-24 [email protected] Roll Skia from a465876e3156 to f4e59f82dc69 (4 revisions) (flutter/flutter#184082) 2026-03-24 [email protected] Refactor: Removes Geometry field from ColorSourceContents (flutter/flutter#183952) 2026-03-24 [email protected] Refactor layout dimensions (flutter/flutter#184066) 2026-03-24 [email protected] feat: Add --base-href support to flutter run for web (flutter/flutter#182709) 2026-03-24 [email protected] Add LeanCode and contributors to AUTHORS (flutter/flutter#182997) 2026-03-24 [email protected] [tools] Make sure `assemble` has a pubspec as cwd (flutter/flutter#184067) 2026-03-24 [email protected] Roll Skia from bf4f2763b6e6 to a465876e3156 (5 revisions) (flutter/flutter#184068) 2026-03-24 [email protected] fix gaussian blur getting clipped with negative scale (flutter/flutter#184037) 2026-03-24 [email protected] Keep glyphs for variable fonts (flutter/flutter#183857) 2026-03-24 [email protected] Mark `IconData` `final` and `@mustBeConst` (flutter/flutter#181345) 2026-03-24 [email protected] Roll Skia from 62841a512deb to bf4f2763b6e6 (1 revision) (flutter/flutter#184062) 2026-03-24 [email protected] Use Color.a instead of Color.alpha to assert the opacity of the color… (flutter/flutter#184003) 2026-03-24 [email protected] Roll Dart SDK from f504293598f2 to b08bd0a3ee39 (1 revision) (flutter/flutter#184054) 2026-03-24 [email protected] Roll Fuchsia Linux SDK from x9x76ERXhrt0Q3zKf... to M3sjWggTQmP2AD4bS... (flutter/flutter#184053) 2026-03-24 [email protected] Roll Dart SDK from 788e347194a6 to f504293598f2 (1 revision) (flutter/flutter#184048) 2026-03-24 [email protected] Roll Skia from fb6acef456ea to 62841a512deb (2 revisions) (flutter/flutter#184046) 2026-03-24 [email protected] [Slider] Remove value indicator painter when animation is dismissed (flutter/flutter#182991) 2026-03-24 [email protected] Manual roll ICU from 7971660ba630 to ee5f27adc28b (1 revision) (flutter/flutter#184041) 2026-03-23 [email protected] Add scrollPadding property to DropdownMenu (flutter/flutter#183109) 2026-03-23 [email protected] Roll pub packages (flutter/flutter#183895) 2026-03-23 [email protected] Roll Skia from c2b58922e37d to fb6acef456ea (1 revision) (flutter/flutter#184033) 2026-03-23 [email protected] Roll Dart SDK from b172bea4f008 to 788e347194a6 (2 revisions) (flutter/flutter#184035) 2026-03-23 [email protected] chore: deflake Linux_android_emu android_display_cutout (flutter/flutter#183522) 2026-03-23 [email protected] Add note about gclient sync network failures and workaround (flutter/flutter#183794) 2026-03-23 [email protected] Roll Skia from a81bf411a5cb to c2b58922e37d (3 revisions) (flutter/flutter#184016) 2026-03-23 [email protected] refactor(web): use positive logic and platform defaults for accessibility features (flutter/flutter#183907) 2026-03-23 [email protected] [android][a11y] set "android.widget.ProgressBar" according to semantics role (flutter/flutter#183897) 2026-03-23 [email protected] Add progress bar to artifact downloads (flutter/flutter#182836) 2026-03-23 [email protected] Add windows instruction to `Forcing Flutter Tools Snapshot Regeneration` (flutter/flutter#183977) 2026-03-23 [email protected] Roll Skia from 42a6eb1dc5c9 to a81bf411a5cb (3 revisions) (flutter/flutter#184007) 2026-03-23 [email protected] Roll Fuchsia Linux SDK from q1xqlQPxq8a3JTA4P... to x9x76ERXhrt0Q3zKf... (flutter/flutter#184006) 2026-03-23 [email protected] Roll Dart SDK from ef45f179526f to b172bea4f008 (1 revision) (flutter/flutter#184004) 2026-03-23 [email protected] Roll Skia from 964c3b33fd73 to 42a6eb1dc5c9 (1 revision) (flutter/flutter#184001) 2026-03-23 [email protected] Update the windowing docs per the latest wording found while doing Satellites (flutter/flutter#183748) 2026-03-22 [email protected] Add assert for mutually exclusive errorBuilder and errorText (flutter/flutter#183901) 2026-03-22 [email protected] Roll Fuchsia Linux SDK from Yc7Ijp2ySjG841xha... to q1xqlQPxq8a3JTA4P... (flutter/flutter#183991) 2026-03-21 [email protected] Roll Skia from 812822ad5caa to 964c3b33fd73 (1 revision) (flutter/flutter#183982) 2026-03-21 [email protected] Roll Dart SDK from c831a55e2fcc to ef45f179526f (1 revision) (flutter/flutter#183973) 2026-03-21 [email protected] Roll Skia from 569cc0475162 to 812822ad5caa (2 revisions) (flutter/flutter#183970) 2026-03-20 [email protected] Roll Fuchsia Linux SDK from ilAIAVzu4xmeb078x... to Yc7Ijp2ySjG841xha... (flutter/flutter#183956) 2026-03-20 [email protected] Roll Skia from 79a14289c60d to 569cc0475162 (3 revisions) (flutter/flutter#183954) 2026-03-20 [email protected] Roll Dart SDK from c88a8008e93b to c831a55e2fcc (3 revisions) (flutter/flutter#183953) 2026-03-20 [email protected] Roll Skia from 8d4c76b92050 to 79a14289c60d (4 revisions) (flutter/flutter#183949) ...
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Mar 26, 2026
…cs role (flutter#183897) when testing flutter#182491 I found out the ProgressBar class is not set on android, setting the class name will make the talkback announce "progress bar". ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: chunhtai <[email protected]>
ahmedsameha1
pushed a commit
to ahmedsameha1/flutter
that referenced
this pull request
Apr 14, 2026
…cs role (flutter#183897) when testing flutter#182491 I found out the ProgressBar class is not set on android, setting the class name will make the talkback announce "progress bar". ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: chunhtai <[email protected]>
Jyndigo
pushed a commit
to uesp/wkwebview_flutter
that referenced
this pull request
Apr 15, 2026
…(#11345) Manual roll Flutter from dd64978dfae1 to 82d96ef98a33 (89 revisions) Manual roll requested by [email protected] flutter/flutter@dd64978...82d96ef 2026-03-24 [email protected] Fix RenderStack's documentation (flutter/flutter#183822) 2026-03-24 [email protected] Roll Skia from a465876e3156 to f4e59f82dc69 (4 revisions) (flutter/flutter#184082) 2026-03-24 [email protected] Refactor: Removes Geometry field from ColorSourceContents (flutter/flutter#183952) 2026-03-24 [email protected] Refactor layout dimensions (flutter/flutter#184066) 2026-03-24 [email protected] feat: Add --base-href support to flutter run for web (flutter/flutter#182709) 2026-03-24 [email protected] Add LeanCode and contributors to AUTHORS (flutter/flutter#182997) 2026-03-24 [email protected] [tools] Make sure `assemble` has a pubspec as cwd (flutter/flutter#184067) 2026-03-24 [email protected] Roll Skia from bf4f2763b6e6 to a465876e3156 (5 revisions) (flutter/flutter#184068) 2026-03-24 [email protected] fix gaussian blur getting clipped with negative scale (flutter/flutter#184037) 2026-03-24 [email protected] Keep glyphs for variable fonts (flutter/flutter#183857) 2026-03-24 [email protected] Mark `IconData` `final` and `@mustBeConst` (flutter/flutter#181345) 2026-03-24 [email protected] Roll Skia from 62841a512deb to bf4f2763b6e6 (1 revision) (flutter/flutter#184062) 2026-03-24 [email protected] Use Color.a instead of Color.alpha to assert the opacity of the color… (flutter/flutter#184003) 2026-03-24 [email protected] Roll Dart SDK from f504293598f2 to b08bd0a3ee39 (1 revision) (flutter/flutter#184054) 2026-03-24 [email protected] Roll Fuchsia Linux SDK from x9x76ERXhrt0Q3zKf... to M3sjWggTQmP2AD4bS... (flutter/flutter#184053) 2026-03-24 [email protected] Roll Dart SDK from 788e347194a6 to f504293598f2 (1 revision) (flutter/flutter#184048) 2026-03-24 [email protected] Roll Skia from fb6acef456ea to 62841a512deb (2 revisions) (flutter/flutter#184046) 2026-03-24 [email protected] [Slider] Remove value indicator painter when animation is dismissed (flutter/flutter#182991) 2026-03-24 [email protected] Manual roll ICU from 7971660ba630 to ee5f27adc28b (1 revision) (flutter/flutter#184041) 2026-03-23 [email protected] Add scrollPadding property to DropdownMenu (flutter/flutter#183109) 2026-03-23 [email protected] Roll pub packages (flutter/flutter#183895) 2026-03-23 [email protected] Roll Skia from c2b58922e37d to fb6acef456ea (1 revision) (flutter/flutter#184033) 2026-03-23 [email protected] Roll Dart SDK from b172bea4f008 to 788e347194a6 (2 revisions) (flutter/flutter#184035) 2026-03-23 [email protected] chore: deflake Linux_android_emu android_display_cutout (flutter/flutter#183522) 2026-03-23 [email protected] Add note about gclient sync network failures and workaround (flutter/flutter#183794) 2026-03-23 [email protected] Roll Skia from a81bf411a5cb to c2b58922e37d (3 revisions) (flutter/flutter#184016) 2026-03-23 [email protected] refactor(web): use positive logic and platform defaults for accessibility features (flutter/flutter#183907) 2026-03-23 [email protected] [android][a11y] set "android.widget.ProgressBar" according to semantics role (flutter/flutter#183897) 2026-03-23 [email protected] Add progress bar to artifact downloads (flutter/flutter#182836) 2026-03-23 [email protected] Add windows instruction to `Forcing Flutter Tools Snapshot Regeneration` (flutter/flutter#183977) 2026-03-23 [email protected] Roll Skia from 42a6eb1dc5c9 to a81bf411a5cb (3 revisions) (flutter/flutter#184007) 2026-03-23 [email protected] Roll Fuchsia Linux SDK from q1xqlQPxq8a3JTA4P... to x9x76ERXhrt0Q3zKf... (flutter/flutter#184006) 2026-03-23 [email protected] Roll Dart SDK from ef45f179526f to b172bea4f008 (1 revision) (flutter/flutter#184004) 2026-03-23 [email protected] Roll Skia from 964c3b33fd73 to 42a6eb1dc5c9 (1 revision) (flutter/flutter#184001) 2026-03-23 [email protected] Update the windowing docs per the latest wording found while doing Satellites (flutter/flutter#183748) 2026-03-22 [email protected] Add assert for mutually exclusive errorBuilder and errorText (flutter/flutter#183901) 2026-03-22 [email protected] Roll Fuchsia Linux SDK from Yc7Ijp2ySjG841xha... to q1xqlQPxq8a3JTA4P... (flutter/flutter#183991) 2026-03-21 [email protected] Roll Skia from 812822ad5caa to 964c3b33fd73 (1 revision) (flutter/flutter#183982) 2026-03-21 [email protected] Roll Dart SDK from c831a55e2fcc to ef45f179526f (1 revision) (flutter/flutter#183973) 2026-03-21 [email protected] Roll Skia from 569cc0475162 to 812822ad5caa (2 revisions) (flutter/flutter#183970) 2026-03-20 [email protected] Roll Fuchsia Linux SDK from ilAIAVzu4xmeb078x... to Yc7Ijp2ySjG841xha... (flutter/flutter#183956) 2026-03-20 [email protected] Roll Skia from 79a14289c60d to 569cc0475162 (3 revisions) (flutter/flutter#183954) 2026-03-20 [email protected] Roll Dart SDK from c88a8008e93b to c831a55e2fcc (3 revisions) (flutter/flutter#183953) 2026-03-20 [email protected] Roll Skia from 8d4c76b92050 to 79a14289c60d (4 revisions) (flutter/flutter#183949) ...
10 tasks
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…lutter#11345) Manual roll Flutter from dd64978dfae1 to 82d96ef98a33 (89 revisions) Manual roll requested by [email protected] flutter/flutter@dd64978...82d96ef 2026-03-24 [email protected] Fix RenderStack's documentation (flutter/flutter#183822) 2026-03-24 [email protected] Roll Skia from a465876e3156 to f4e59f82dc69 (4 revisions) (flutter/flutter#184082) 2026-03-24 [email protected] Refactor: Removes Geometry field from ColorSourceContents (flutter/flutter#183952) 2026-03-24 [email protected] Refactor layout dimensions (flutter/flutter#184066) 2026-03-24 [email protected] feat: Add --base-href support to flutter run for web (flutter/flutter#182709) 2026-03-24 [email protected] Add LeanCode and contributors to AUTHORS (flutter/flutter#182997) 2026-03-24 [email protected] [tools] Make sure `assemble` has a pubspec as cwd (flutter/flutter#184067) 2026-03-24 [email protected] Roll Skia from bf4f2763b6e6 to a465876e3156 (5 revisions) (flutter/flutter#184068) 2026-03-24 [email protected] fix gaussian blur getting clipped with negative scale (flutter/flutter#184037) 2026-03-24 [email protected] Keep glyphs for variable fonts (flutter/flutter#183857) 2026-03-24 [email protected] Mark `IconData` `final` and `@mustBeConst` (flutter/flutter#181345) 2026-03-24 [email protected] Roll Skia from 62841a512deb to bf4f2763b6e6 (1 revision) (flutter/flutter#184062) 2026-03-24 [email protected] Use Color.a instead of Color.alpha to assert the opacity of the color… (flutter/flutter#184003) 2026-03-24 [email protected] Roll Dart SDK from f504293598f2 to b08bd0a3ee39 (1 revision) (flutter/flutter#184054) 2026-03-24 [email protected] Roll Fuchsia Linux SDK from x9x76ERXhrt0Q3zKf... to M3sjWggTQmP2AD4bS... (flutter/flutter#184053) 2026-03-24 [email protected] Roll Dart SDK from 788e347194a6 to f504293598f2 (1 revision) (flutter/flutter#184048) 2026-03-24 [email protected] Roll Skia from fb6acef456ea to 62841a512deb (2 revisions) (flutter/flutter#184046) 2026-03-24 [email protected] [Slider] Remove value indicator painter when animation is dismissed (flutter/flutter#182991) 2026-03-24 [email protected] Manual roll ICU from 7971660ba630 to ee5f27adc28b (1 revision) (flutter/flutter#184041) 2026-03-23 [email protected] Add scrollPadding property to DropdownMenu (flutter/flutter#183109) 2026-03-23 [email protected] Roll pub packages (flutter/flutter#183895) 2026-03-23 [email protected] Roll Skia from c2b58922e37d to fb6acef456ea (1 revision) (flutter/flutter#184033) 2026-03-23 [email protected] Roll Dart SDK from b172bea4f008 to 788e347194a6 (2 revisions) (flutter/flutter#184035) 2026-03-23 [email protected] chore: deflake Linux_android_emu android_display_cutout (flutter/flutter#183522) 2026-03-23 [email protected] Add note about gclient sync network failures and workaround (flutter/flutter#183794) 2026-03-23 [email protected] Roll Skia from a81bf411a5cb to c2b58922e37d (3 revisions) (flutter/flutter#184016) 2026-03-23 [email protected] refactor(web): use positive logic and platform defaults for accessibility features (flutter/flutter#183907) 2026-03-23 [email protected] [android][a11y] set "android.widget.ProgressBar" according to semantics role (flutter/flutter#183897) 2026-03-23 [email protected] Add progress bar to artifact downloads (flutter/flutter#182836) 2026-03-23 [email protected] Add windows instruction to `Forcing Flutter Tools Snapshot Regeneration` (flutter/flutter#183977) 2026-03-23 [email protected] Roll Skia from 42a6eb1dc5c9 to a81bf411a5cb (3 revisions) (flutter/flutter#184007) 2026-03-23 [email protected] Roll Fuchsia Linux SDK from q1xqlQPxq8a3JTA4P... to x9x76ERXhrt0Q3zKf... (flutter/flutter#184006) 2026-03-23 [email protected] Roll Dart SDK from ef45f179526f to b172bea4f008 (1 revision) (flutter/flutter#184004) 2026-03-23 [email protected] Roll Skia from 964c3b33fd73 to 42a6eb1dc5c9 (1 revision) (flutter/flutter#184001) 2026-03-23 [email protected] Update the windowing docs per the latest wording found while doing Satellites (flutter/flutter#183748) 2026-03-22 [email protected] Add assert for mutually exclusive errorBuilder and errorText (flutter/flutter#183901) 2026-03-22 [email protected] Roll Fuchsia Linux SDK from Yc7Ijp2ySjG841xha... to q1xqlQPxq8a3JTA4P... (flutter/flutter#183991) 2026-03-21 [email protected] Roll Skia from 812822ad5caa to 964c3b33fd73 (1 revision) (flutter/flutter#183982) 2026-03-21 [email protected] Roll Dart SDK from c831a55e2fcc to ef45f179526f (1 revision) (flutter/flutter#183973) 2026-03-21 [email protected] Roll Skia from 569cc0475162 to 812822ad5caa (2 revisions) (flutter/flutter#183970) 2026-03-20 [email protected] Roll Fuchsia Linux SDK from ilAIAVzu4xmeb078x... to Yc7Ijp2ySjG841xha... (flutter/flutter#183956) 2026-03-20 [email protected] Roll Skia from 79a14289c60d to 569cc0475162 (3 revisions) (flutter/flutter#183954) 2026-03-20 [email protected] Roll Dart SDK from c88a8008e93b to c831a55e2fcc (3 revisions) (flutter/flutter#183953) 2026-03-20 [email protected] Roll Skia from 8d4c76b92050 to 79a14289c60d (4 revisions) (flutter/flutter#183949) ...
pull Bot
pushed a commit
to Superoldman96/flutter
that referenced
this pull request
Jun 15, 2026
…r#185217) In flutter#183897 I added semantics roles in [AccessibilityBridge.java], I found some other current semantics roles can be mapped to android classes. There are some other android classes in AccessibilityBridge.java are currently set by flags instead of by roles. example: we use "isSlider" instead of slider role. we will need to add a slider role for it : flutter#184029. ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
10 tasks
pull Bot
pushed a commit
to Spencerx/flutter
that referenced
this pull request
Jun 15, 2026
flutter#185217)" (flutter#188008) <!-- start_original_pr_link --> Reverts: flutter#185217 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: cbracken <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: triggers test failures in android_semantics_integration_test Speifically `dev/integration_tests/android_semantics_testing/integration_test/main_test.dart` To be clear, it looks like the fix itself is good but the tests have not been updated to test the corrected behaviour. Reverting to get the tree green but I think all that needs doing is updating the tests. `AccessibilityBridge TextFiel <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: hannah-hyj <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {chunhtai, reidbaker} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: In flutter#183897 I added semantics roles in [AccessibilityBridge.java], I found some other current semantics roles can be mapped to android classes. There are some other android classes in AccessibilityBridge.java are currently set by flags instead of by roles. example: we use "isSlider" instead of slider role. we will need to add a slider role for it : flutter#184029. ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <[email protected]>
via-guy
pushed a commit
to via-guy/flutter
that referenced
this pull request
Jun 26, 2026
…r#185217) In flutter#183897 I added semantics roles in [AccessibilityBridge.java], I found some other current semantics roles can be mapped to android classes. There are some other android classes in AccessibilityBridge.java are currently set by flags instead of by roles. example: we use "isSlider" instead of slider role. we will need to add a slider role for it : flutter#184029. ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
via-guy
pushed a commit
to via-guy/flutter
that referenced
this pull request
Jun 26, 2026
flutter#185217)" (flutter#188008) <!-- start_original_pr_link --> Reverts: flutter#185217 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: cbracken <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: triggers test failures in android_semantics_integration_test Speifically `dev/integration_tests/android_semantics_testing/integration_test/main_test.dart` To be clear, it looks like the fix itself is good but the tests have not been updated to test the corrected behaviour. Reverting to get the tree green but I think all that needs doing is updating the tests. `AccessibilityBridge TextFiel <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: hannah-hyj <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {chunhtai, reidbaker} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: In flutter#183897 I added semantics roles in [AccessibilityBridge.java], I found some other current semantics roles can be mapped to android classes. There are some other android classes in AccessibilityBridge.java are currently set by flags instead of by roles. example: we use "isSlider" instead of slider role. we will need to add a slider role for it : flutter#184029. ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when testing #182491 I found out the ProgressBar class is not set on android, setting the class name will make the talkback announce "progress bar".
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.