[CP-stable][Impeller] Do not wait for a frame's acquire fence if the frame was never presented#183885
Merged
Conversation
…ever presented (flutter#183288) This could happen if a previous call to vkAcquireNextImageKHR failed. If that occurs, then AcquireNextDrawable will not return a surface. The caller will not render a frame or call Present, and the fence will never be signaled. See internal issue b/488786379
Contributor
Author
|
@reidbaker please fill out the PR description above, afterwards the release team will review this request. |
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
github-actions
Bot
added
engine
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the Vulkan swapchain implementation to avoid waiting on an acquisition fence if the frame was never presented. This is achieved by introducing a new flag, acquire_fence_pending, to track whether a fence wait is expected. The acquire fence is now created in an unsignaled state, and the acquire_fence_pending flag is set to true only when a frame is successfully submitted for presentation. The wait for the fence is skipped if this flag is not set, preventing a potential hang when acquiring the next drawable fails. The changes also include updates to the Vulkan mocking infrastructure to support a new unit test that validates this fix.
jason-simmons
approved these changes
Mar 19, 2026
reidbaker
added
the
autosubmit
auto-submit
Bot
merged commit 301b0e8
into
flutter:flutter-3.41-candidate.0
162 checks passed
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2026
…ce if the frame was never presented (flutter/flutter#183885)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 27, 2026
…ce if the frame was never presented (flutter/flutter#183885)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 27, 2026
…ce if the frame was never presented (flutter/flutter#183885)
ahmedsameha1
pushed a commit
to ahmedsameha1/flutter
that referenced
this pull request
Apr 14, 2026
Merge CHANGELOG.md into master for 3.41.6 includes: flutter#183885 flutter#184040 flutter#184025
littleGnAl
pushed a commit
to littleGnAl/flutter
that referenced
this pull request
Apr 15, 2026
…frame was never presented (flutter#183885) This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: What is the link to the issue this cherry-pick is addressing? b/488786379 ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping of production apps (the app crashes on launch). This information is for domain experts and release engineers to understand the consequences of saying yes or no to the cherry pick. ### Changelog Description: Explain this cherry pick: * In one line that is accessible to most Flutter developers. * That describes the state prior to the fix. * That includes which platforms are impacted. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples. < Replace with changelog description here > [flutter/183887](flutter#183887) During SCREEN_OFF event a deadlock preventing new frames causing an ANR can occur on android devices running the Android 16 March Security update. ### Workaround: Is there a workaround for this issue? No ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? No public repro steps.
Xbectordash
pushed a commit
to Xbectordash/abhi_flutter_fork
that referenced
this pull request
May 13, 2026
…frame was never presented (flutter#183885) This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. What is the link to the issue this cherry-pick is addressing? b/488786379 What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping of production apps (the app crashes on launch). This information is for domain experts and release engineers to understand the consequences of saying yes or no to the cherry pick. Explain this cherry pick: * In one line that is accessible to most Flutter developers. * That describes the state prior to the fix. * That includes which platforms are impacted. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples. < Replace with changelog description here > [flutter/183887](flutter#183887) During SCREEN_OFF event a deadlock preventing new frames causing an ANR can occur on android devices running the Android 16 March Security update. Is there a workaround for this issue? No What is the risk level of this cherry-pick? Are you confident that your fix is tested by automated tests? What are the steps to validate that this fix works? No public repro steps.
Xbectordash
pushed a commit
to Xbectordash/abhi_flutter_fork
that referenced
this pull request
May 13, 2026
Update the changelog for 4.41.6. Includes: flutter#183885 flutter#184040 flutter#184025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
What is the link to the issue this cherry-pick is addressing?
b/488786379
Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)?
Does it impact development (ex. flutter doctor crashes when Android Studio is installed),
or the shipping of production apps (the app crashes on launch).
This information is for domain experts and release engineers to understand the consequences of saying yes or no to the cherry pick.
Changelog Description:
Explain this cherry pick:
See best practices for examples.
< Replace with changelog description here >
flutter/183887 During SCREEN_OFF event a deadlock preventing new frames causing an ANR can occur on android devices running the Android 16 March Security update.
Workaround:
Is there a workaround for this issue?
No
Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is tested by automated tests?
Validation Steps:
What are the steps to validate that this fix works?
No public repro steps.