fix(web): handle asynchronously disposed platform views by harryterkelsen · Pull Request #183666 · flutter/flutter

harryterkelsen · 2026-03-13T21:54:42Z

Check if platform views still exist in PlatformViewManager before compositing to avoid crashes if they are disposed during async gaps in the rendering pipeline.

Added test/ui/async_rendering_test.dart.

Fixes #182844
Fixes #176299

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

gemini-code-assist

Code Review

This pull request addresses a potential crash when platform views are disposed asynchronously during rendering. The core change in PlatformViewEmbedder is the addition of a guard in compositeEmbeddedView that checks if a platform view is still known to the PlatformViewManager before proceeding with composition. To validate this fix, a new test file, async_rendering_test.dart, is introduced. This test simulates the specific race condition by disposing of a platform view within an artificial asynchronous gap in the rendering pipeline, and then confirms that the rendering process completes without crashing.

harryterkelsen · 2026-03-13T22:15:40Z

/gemini review

Check if platform views still exist in PlatformViewManager before compositing to avoid crashes if they are disposed during async gaps in the rendering pipeline. Added test/ui/async_rendering_test.dart.

gemini-code-assist

Code Review

This pull request correctly addresses a crash when a platform view is disposed asynchronously during the rendering pipeline. The fix involves checking if the view still exists before compositing and changing a debug assertion to a warning to handle the race condition gracefully. The new tests are well-written and verify the fix. I have one suggestion to reduce code duplication in the new test file.

mdebbar

LGTM, thank you for fixing this quickly!

auto-submit · 2026-03-16T15:48:35Z

autosubmit label was removed for flutter/flutter/183666, because - The status or check suite Windows framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.

flutter-zl

LGTM

ditman

LGTM! Small question about whether or not to nag the user in release builds for this case (before this change we used to NOT nag users in release builds, only when asserts were enabled)

ditman · 2026-03-17T23:06:29Z

+        debugInvalidViewIds ??= <int>[];
+        debugInvalidViewIds.add(viewId);


Do we really want to "nag" the user in production with the invalid view warning? Should this be: "populate the debugInvalidViewIds array when asserts are enabled, but skip rendering an invalid viewId regardless"?

Before this change we would crash in the case where we went to render a scene with a platform view where !PlatformViewManager.instance.knowsViewId(viewId). I think downgrading from crash to a warning is okay here. If it turns out that the warning is logged often in normally behaving apps, then we should reconsider and just have it print the warning in an assert or something.

…utter/flutter#183666)

flutter/flutter@d117642...dd64978 2026-03-18 [email protected] Roll Skia from 2fb5fa71eb12 to f0a13e5efbad (2 revisions) (flutter/flutter#183830) 2026-03-18 [email protected] Roll Skia from ae3d36cb9e29 to 2fb5fa71eb12 (3 revisions) (flutter/flutter#183823) 2026-03-18 [email protected] Linux reuse sibling (flutter/flutter#183653) 2026-03-18 [email protected] Roll Skia from 84a180a1fa80 to ae3d36cb9e29 (4 revisions) (flutter/flutter#183812) 2026-03-18 [email protected] fix(web): handle asynchronously disposed platform views (flutter/flutter#183666) 2026-03-17 [email protected] (Test cross-imports) Remove legacy Material import from sliver_constraints_test (flutter/flutter#183351) 2026-03-17 [email protected] Fix Android Studio pluginsPath when version is unknown (do not use 0.0) (flutter/flutter#182681) 2026-03-17 [email protected] Fixes animation glitch into bottom sheet (flutter/flutter#183303) 2026-03-17 [email protected] Handle#6537 second grouped test (flutter/flutter#182529) 2026-03-17 [email protected] Add a Clarification for the docs of suggestionsBuilder of SearchAnchor (flutter/flutter#183106) 2026-03-17 [email protected] Remove obsolete null checks from style guide (flutter/flutter#181703) 2026-03-17 [email protected] [Impeller] Do not delete the GL object in a HandleGLES if the handle has a cleanup callback (flutter/flutter#183561) 2026-03-17 [email protected] Encode source file patches as UTF-8 in the code formatter script (flutter/flutter#183761) 2026-03-17 [email protected] Fix widget inspector control layout and add safe area regression test (flutter/flutter#180789) 2026-03-17 [email protected] Reland "[Android] Add mechanism for setting Android engine flags via Android manifest (take 2)" (flutter/flutter#182522) 2026-03-17 [email protected] fix(web): fix crash in Skwasm when transferring non-transferable texture sources (flutter/flutter#183799) 2026-03-17 [email protected] Roll Skia from dba893a44d7a to 84a180a1fa80 (7 revisions) (flutter/flutter#183803) 2026-03-17 [email protected] Framework: Improve DropdownButton selectedItemBuilder assertion (flutter/flutter#183732) 2026-03-17 [email protected] Add mainAxisAlignment to NavigationRail (flutter/flutter#183514) 2026-03-17 [email protected] Update android triage process to not look at unassigned p1s every week (flutter/flutter#183805) 2026-03-17 [email protected] Adds macos impeller new gallery transition perf test. (flutter/flutter#183802) 2026-03-17 [email protected] fix(web_ui): move prepareToDraw after raster to improve concurrency and stability (flutter/flutter#183791) 2026-03-17 [email protected] [build] Generate debug info for assembly. (flutter/flutter#183425) 2026-03-17 [email protected] [web] Fix occasional failure to find Chrome tab (flutter/flutter#183737) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#11281) flutter/flutter@d117642...dd64978 2026-03-18 [email protected] Roll Skia from 2fb5fa71eb12 to f0a13e5efbad (2 revisions) (flutter/flutter#183830) 2026-03-18 [email protected] Roll Skia from ae3d36cb9e29 to 2fb5fa71eb12 (3 revisions) (flutter/flutter#183823) 2026-03-18 [email protected] Linux reuse sibling (flutter/flutter#183653) 2026-03-18 [email protected] Roll Skia from 84a180a1fa80 to ae3d36cb9e29 (4 revisions) (flutter/flutter#183812) 2026-03-18 [email protected] fix(web): handle asynchronously disposed platform views (flutter/flutter#183666) 2026-03-17 [email protected] (Test cross-imports) Remove legacy Material import from sliver_constraints_test (flutter/flutter#183351) 2026-03-17 [email protected] Fix Android Studio pluginsPath when version is unknown (do not use 0.0) (flutter/flutter#182681) 2026-03-17 [email protected] Fixes animation glitch into bottom sheet (flutter/flutter#183303) 2026-03-17 [email protected] Handle#6537 second grouped test (flutter/flutter#182529) 2026-03-17 [email protected] Add a Clarification for the docs of suggestionsBuilder of SearchAnchor (flutter/flutter#183106) 2026-03-17 [email protected] Remove obsolete null checks from style guide (flutter/flutter#181703) 2026-03-17 [email protected] [Impeller] Do not delete the GL object in a HandleGLES if the handle has a cleanup callback (flutter/flutter#183561) 2026-03-17 [email protected] Encode source file patches as UTF-8 in the code formatter script (flutter/flutter#183761) 2026-03-17 [email protected] Fix widget inspector control layout and add safe area regression test (flutter/flutter#180789) 2026-03-17 [email protected] Reland "[Android] Add mechanism for setting Android engine flags via Android manifest (take 2)" (flutter/flutter#182522) 2026-03-17 [email protected] fix(web): fix crash in Skwasm when transferring non-transferable texture sources (flutter/flutter#183799) 2026-03-17 [email protected] Roll Skia from dba893a44d7a to 84a180a1fa80 (7 revisions) (flutter/flutter#183803) 2026-03-17 [email protected] Framework: Improve DropdownButton selectedItemBuilder assertion (flutter/flutter#183732) 2026-03-17 [email protected] Add mainAxisAlignment to NavigationRail (flutter/flutter#183514) 2026-03-17 [email protected] Update android triage process to not look at unassigned p1s every week (flutter/flutter#183805) 2026-03-17 [email protected] Adds macos impeller new gallery transition perf test. (flutter/flutter#183802) 2026-03-17 [email protected] fix(web_ui): move prepareToDraw after raster to improve concurrency and stability (flutter/flutter#183791) 2026-03-17 [email protected] [build] Generate debug info for assembly. (flutter/flutter#183425) 2026-03-17 [email protected] [web] Fix occasional failure to find Chrome tab (flutter/flutter#183737) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Check if platform views still exist in PlatformViewManager before compositing to avoid crashes if they are disposed during async gaps in the rendering pipeline. Added test/ui/async_rendering_test.dart. Fixes flutter#182844 Fixes flutter#176299 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Mouad Debbar <[email protected]>

I haven't seen these tests fail since the underlying issue was [fixed](flutter/flutter#183666) and [rolled](99155a8) in. Closes flutter/flutter#182844

github-actions Bot added engine flutter/engine related. See also e: labels. platform-web Web applications specifically labels Mar 13, 2026

harryterkelsen requested a review from mdebbar March 13, 2026 21:56

harryterkelsen added the CICD Run CI/CD label Mar 13, 2026

gemini-code-assist Bot reviewed Mar 13, 2026

View reviewed changes

harryterkelsen force-pushed the fix-async-frame-render-issues branch from 98757ce to 3fc6e2d Compare March 13, 2026 22:13

harryterkelsen added CICD Run CI/CD and removed CICD Run CI/CD labels Mar 13, 2026

fix(web-ui): handle asynchronously disposed platform views

e79db91

Check if platform views still exist in PlatformViewManager before compositing to avoid crashes if they are disposed during async gaps in the rendering pipeline. Added test/ui/async_rendering_test.dart.

gemini-code-assist Bot reviewed Mar 13, 2026

View reviewed changes

Comment thread engine/src/flutter/lib/web_ui/test/ui/async_rendering_test.dart Outdated

mdebbar previously approved these changes Mar 13, 2026

View reviewed changes

harryterkelsen added 2 commits March 13, 2026 17:01

Fix platform_view_test

20aa50e

Fix warnings and formatting errors

b943f30

harryterkelsen dismissed mdebbar’s stale review via b943f30 March 14, 2026 00:04

harryterkelsen force-pushed the fix-async-frame-render-issues branch from 3fc6e2d to b943f30 Compare March 14, 2026 00:04

harryterkelsen added CICD Run CI/CD and removed CICD Run CI/CD labels Mar 14, 2026

lint

c123c92

mdebbar approved these changes Mar 16, 2026

View reviewed changes

mdebbar added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App and removed CICD Run CI/CD labels Mar 16, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 16, 2026

[retrigger ci]

af9a6a8

github-actions Bot removed the CICD Run CI/CD label Mar 16, 2026

harryterkelsen added the CICD Run CI/CD label Mar 16, 2026

mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 17, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 17, 2026

flutter-zl self-requested a review March 17, 2026 21:02

flutter-zl previously approved these changes Mar 17, 2026

View reviewed changes

Refactor test

6ae5f89

harryterkelsen dismissed stale reviews from flutter-zl and mdebbar via 6ae5f89 March 17, 2026 21:15

github-actions Bot removed the CICD Run CI/CD label Mar 17, 2026

harryterkelsen added the CICD Run CI/CD label Mar 17, 2026

ditman approved these changes Mar 17, 2026

View reviewed changes

auto-submit Bot added this pull request to the merge queue Mar 18, 2026

Merged via the queue into flutter:master with commit 537bb2c Mar 18, 2026
185 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 18, 2026

engine-flutter-autoroll mentioned this pull request Mar 18, 2026

Roll Flutter from d117642c18e0 to dd64978dfae1 (24 revisions) flutter/packages#11281

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 18, 2026

537bb2ca2 fix(web): handle asynchronously disposed platform views (fl…

50508a7

…utter/flutter#183666)

engine-flutter-autoroll mentioned this pull request Mar 18, 2026

Roll Flutter from d117642c18e0 to e6ed6e9e1678 (25 revisions) flutter/packages#11282

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 18, 2026

537bb2ca2 fix(web): handle asynchronously disposed platform views (fl…

75315e9

…utter/flutter#183666)

engine-flutter-autoroll mentioned this pull request Mar 18, 2026

Roll Flutter from d117642c18e0 to 7189eb4d128c (26 revisions) flutter/packages#11284

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 18, 2026

537bb2ca2 fix(web): handle asynchronously disposed platform views (fl…

0026905

…utter/flutter#183666)

engine-flutter-autoroll mentioned this pull request Mar 18, 2026

Roll Flutter from d117642c18e0 to 6df82a9ec022 (27 revisions) flutter/packages#11286

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 18, 2026

537bb2ca2 fix(web): handle asynchronously disposed platform views (fl…

2f5eaf3

…utter/flutter#183666)

engine-flutter-autoroll mentioned this pull request Mar 18, 2026

Roll Flutter from d117642c18e0 to 73d6bccaf322 (30 revisions) flutter/packages#11288

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 18, 2026

537bb2ca2 fix(web): handle asynchronously disposed platform views (fl…

37c59a0

…utter/flutter#183666)

engine-flutter-autoroll mentioned this pull request Mar 18, 2026

Roll Flutter from d117642c18e0 to c0aee3b4ca7d (31 revisions) flutter/packages#11289

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 18, 2026

537bb2ca2 fix(web): handle asynchronously disposed platform views (fl…

ea884a3

…utter/flutter#183666)

mdebbar mentioned this pull request Apr 9, 2026

[url_launcher_web] Re-enable flaky test (not flaky anymore) flutter/packages#11478

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(web): handle asynchronously disposed platform views#183666

fix(web): handle asynchronously disposed platform views#183666
auto-submit[bot] merged 8 commits into
flutter:masterfrom
harryterkelsen:fix-async-frame-render-issues

harryterkelsen commented Mar 13, 2026 •

edited by mdebbar

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

harryterkelsen commented Mar 13, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

mdebbar left a comment

Uh oh!

auto-submit Bot commented Mar 16, 2026

Uh oh!

flutter-zl left a comment

Uh oh!

ditman left a comment

Uh oh!

ditman Mar 17, 2026

Uh oh!

harryterkelsen Mar 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		debugInvalidViewIds ??= <int>[];
		debugInvalidViewIds.add(viewId);

Conversation

harryterkelsen commented Mar 13, 2026 • edited by mdebbar Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

harryterkelsen commented Mar 13, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

mdebbar left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit Bot commented Mar 16, 2026

Uh oh!

flutter-zl left a comment

Choose a reason for hiding this comment

Uh oh!

ditman left a comment

Choose a reason for hiding this comment

Uh oh!

ditman Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

harryterkelsen Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

harryterkelsen commented Mar 13, 2026 •

edited by mdebbar

Loading