Update typedef syntax to use Function notation and turn on lint for old notation. #18362
Conversation
analysis_options.yaml
Outdated
There was a problem hiding this comment.
It looks like analysis_options_repo.yaml was intended to be removed in #16979. If so, we should audit any changes that have landed to that file since that PR landed and make sure things haven't gotten out of sync.
/cc @a14n @devoncarew
There was a problem hiding this comment.
I thought that there was a legitimate reason why there were two almost identical files: according to the comments, one is for flutter analyze to use, and one is for IntelliJ. I did check and make sure that they hadn't diverged (there is one intentional difference, turning off public_member_api_docs for IntelliJ which I think is the reason for the separate files).
There was a problem hiding this comment.
Yes, I'd thought I'd deleted one of them in that PR. I had to revert and re-apply it a few weeks later, so it's possible the delete was a casualty.
We should just have one at the top level (I believe analysis_options.yaml), and it should have the public_member_api_docs lint enabled.
There was a problem hiding this comment.
OK, I've removed analysis_options_repo.yaml and updated the comments at the top of analysis_options.yaml. I grepped through the repo, and I didn't see any reference to analysis_options_repo.yaml.
There was a problem hiding this comment.
I did have to turn on public_member_api_docs: it wasn't enabled. Hopefully the analyzer knows to not fail the build because of those. We'll see shortly...
gspencergoog
force-pushed
the
typedef_reapply
branch
from
67d217f to
b75c1c8
Compare
|
|
Update engine.version update tests for TextStyle changes in engine (flutter#17982) * update tests for TextStyle changes in engine * roll engine, support Foreground on TextStyle * Support for saving Dart compilation trace on device (WIP) Expose foreground in framework TextStyle use identical instead of == Add @istest annotation to testGesture (flutter#18311) Notifies IDEs this is a test method, and helps e.g. the flutter plugin recognize test methods and display them in the structure view in intellij. Update gallery assets version with optipng (flutter#18327) Passing any to named params require the name of the parameter itself. (flutter#18361) Update typedef syntax to use Function notation and turn on lint for old notation. (flutter#18362) Now that Dart 1 is turned off, reapplying my change to turn on the prefer_generic_function_type_aliases analysis option, and fix all the typedefs to Dart 2 preferred syntax. Also eliminated the unused analysis_options_repo.yaml file and turned on public_member_api_docs in analysys_options.yaml. No logic changes, just changing the typedef syntax for all typedefs, and updating analysis options. More flexible timeout logic in flutter_test (flutter#18256) This should reduce the number of flakes without actually increasing the timeout, so we'll still find out quickly if a test is hanging. The numbers here might need tweaking. Maybe the default two seconds is too short for CI bots. merge/apply/lerp prefer foreground doc updates and update for copyWith
|
This broke the "document all public members" benchmark, so I'm going to revert it. |
…nt for old notation. (flutter#18362)" This reverts commit 6c56bb2. That commit broke the dartdocs benchmark
…nt for old notation. (flutter#18362)" This reverts commit 6c56bb2.
|
@cbracken also had to revert this in order to revert the Dart 1 removal. You two should sync up 😄 |
fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly from source, flutter_platform.dart automatically runs a kernel compile when operating in Dart 2 mode, but this assumes a functional Dart SDK is available in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts directory with an empty temp dir. Remaining work is: 1. Get the frontend server building as a dependency on Fuchsia. 2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server. This also reverts migration to Dart 2 typedef syntax. This reverts commit 6c56bb2. (#18362) This reverts commit 3daebd0. (#18316)
6 participants
Now that dart 1 is turned off, reapplying my change to turn on the prefer_generic_function_type_aliases analysis option.
No logic changes, just changing the typedef syntax for all typedefs.