refactor: remove material from list_view_viewporting_test and page_forward_transitions_test#183564
Merged
auto-submit[bot] merged 5 commits intoApr 3, 2026
Merged
Conversation
github-actions
Bot
added
framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors list_view_viewporting_test and page_forward_transitions_test to remove dependencies on the Material library. This is achieved by replacing Material widgets like MaterialApp, Theme, and SliverAppBar with non-Material alternatives such as TestWidgetsApp, IconTheme, and SliverToBoxAdapter. As part of this, TestWidgetsApp is enhanced to support onGenerateRoute, and corresponding tests are added. My review includes suggestions to properly dispose of HeroController instances in the updated tests to prevent resource leaks, and a correction to the documentation for the new onGenerateRoute property in TestWidgetsApp.
Comment on lines
+129
to
+130
| /// When provided, this takes over route generation from [home] and [routes]. | ||
| /// The [pageRouteBuilder] is not used when [onGenerateRoute] is specified. |
Contributor
There was a problem hiding this comment.
This documentation is slightly incorrect. onGenerateRoute is a fallback for home and routes, it doesn't take them over. Also, pageRouteBuilder is still used for routes from home and routes; it's just not used for routes generated by onGenerateRoute.
/// This callback is used if [routes] and [home] do not contain the requested
/// route.
///
/// The [pageRouteBuilder] is not used for routes created by this callback.
Contributor
There was a problem hiding this comment.
I guess Gemini is correct here but no big deal either way.
rkishan516
force-pushed
the
simple-cross-imports-3
branch
from
e7c5397 to
7949c8d
Compare
navaronbracke
previously requested changes
Mar 12, 2026
rkishan516
force-pushed
the
simple-cross-imports-3
branch
from
7949c8d to
f8ab710
Compare
justinmc
previously approved these changes
Mar 12, 2026
| /// }); | ||
| /// ``` | ||
| /// | ||
| /// For tests that need full control over route generation: |
Contributor
There was a problem hiding this comment.
Thanks for documenting this!
Contributor
Author
There was a problem hiding this comment.
All thanks to gemini, I always update docs with gemini.
Comment on lines
+129
to
+130
| /// When provided, this takes over route generation from [home] and [routes]. | ||
| /// The [pageRouteBuilder] is not used when [onGenerateRoute] is specified. |
Contributor
There was a problem hiding this comment.
I guess Gemini is correct here but no big deal either way.
| expect(find.text('Details Page'), findsNothing); | ||
| }); | ||
|
|
||
| testWidgets('onGenerateRoute builds routes from callback', (WidgetTester tester) async { |
Contributor
There was a problem hiding this comment.
Thanks for testing the changes to TestWidgetsApp too.
Contributor
Author
There was a problem hiding this comment.
Yaa, we are testing other properites, so added for this also.
victorsanni
previously approved these changes
Mar 12, 2026
victorsanni
left a comment
victorsanni
left a comment
Contributor
There was a problem hiding this comment.
LGTM, only had one comment.
victorsanni
approved these changes
Mar 23, 2026
rkishan516
force-pushed
the
simple-cross-imports-3
branch
from
07bd6a9 to
1d30539
Compare
rkishan516
added
CICD
auto-submit
Bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/flutter/183564, because This PR has not met approval requirements for merging. Changes were requested by {navaronbracke}, please make the needed changes and resubmit this PR.
|
justinmc
added
the
autosubmit
victorsanni
approved these changes
Apr 3, 2026
github-project-automation
Bot
moved this from In Progress
to Done
in Test cross-imports Review Queue
flutter-dashboard
Bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 4, 2026
…nd page_forward_transitions_test (flutter/flutter#183564)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 4, 2026
…nd page_forward_transitions_test (flutter/flutter#183564)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 5, 2026
…nd page_forward_transitions_test (flutter/flutter#183564)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 5, 2026
…nd page_forward_transitions_test (flutter/flutter#183564)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 6, 2026
…nd page_forward_transitions_test (flutter/flutter#183564)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 6, 2026
…nd page_forward_transitions_test (flutter/flutter#183564)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 6, 2026
…nd page_forward_transitions_test (flutter/flutter#183564)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 6, 2026
…nd page_forward_transitions_test (flutter/flutter#183564)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 6, 2026
…nd page_forward_transitions_test (flutter/flutter#183564)
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Apr 6, 2026
flutter/flutter@7245c3f...9cd60b5 2026-04-06 [email protected] Fix go/ links in rbe.mde (flutter/flutter#184672) 2026-04-06 [email protected] Roll Packages from d31df66 to 5299279 (2 revisions) (flutter/flutter#184663) 2026-04-06 [email protected] Add suggestion for what types of skills are helpful (flutter/flutter#184661) 2026-04-06 [email protected] Roll Fuchsia Linux SDK from hrLZV-ij47FXnv_m5... to 1rcChbOv4nSTVkUxs... (flutter/flutter#184657) 2026-04-06 [email protected] Skill to find dart or flutter revision from a hash (flutter/flutter#184589) 2026-04-06 [email protected] Roll Skia from 207c6721c64b to 163dfdf500c7 (7 revisions) (flutter/flutter#184650) 2026-04-05 [email protected] Roll Skia from 52b79372764c to 207c6721c64b (1 revision) (flutter/flutter#184636) 2026-04-05 [email protected] Roll Fuchsia Linux SDK from D2z-jMnRVbcwcraY-... to hrLZV-ij47FXnv_m5... (flutter/flutter#184623) 2026-04-05 [email protected] Roll Skia from 500bc1651c86 to 52b79372764c (1 revision) (flutter/flutter#184621) 2026-04-04 [email protected] Roll Fuchsia Linux SDK from PpL3Bn2YMb2h9LbdK... to D2z-jMnRVbcwcraY-... (flutter/flutter#184611) 2026-04-04 [email protected] Roll Dart SDK from 102a3d1c7fe5 to 79f728f5d66e (1 revision) (flutter/flutter#184610) 2026-04-04 [email protected] Roll Skia from 5e5a7f252b5e to 500bc1651c86 (1 revision) (flutter/flutter#184609) 2026-04-04 [email protected] Roll Skia from ec209c206aa5 to 5e5a7f252b5e (2 revisions) (flutter/flutter#184606) 2026-04-04 [email protected] Roll Dart SDK from f7be88117622 to 102a3d1c7fe5 (2 revisions) (flutter/flutter#184604) 2026-04-04 [email protected] refactor: remove material from color and image filter test (flutter/flutter#183563) 2026-04-04 [email protected] Roll Skia from 50f3a9aaa185 to ec209c206aa5 (1 revision) (flutter/flutter#184601) 2026-04-03 [email protected] Roll Skia from 4ecb7b28459f to 50f3a9aaa185 (3 revisions) (flutter/flutter#184599) 2026-04-03 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll ICU from ee5f27adc28b to ff7995a708a1 (5 revisions) (#184566)" (flutter/flutter#184586) 2026-04-03 [email protected] Add integration scripts and tools for SwiftPM add to app (flutter/flutter#184204) 2026-04-03 [email protected] Roll Dart SDK from 46f49142acd9 to f7be88117622 (1 revision) (flutter/flutter#184596) 2026-04-03 [email protected] [AGP 9] Add Disable Built-in Kotlin and newDSL Migratorrs (flutter/flutter#184255) 2026-04-03 [email protected] Roll Skia from 3b0f0f04f97c to 4ecb7b28459f (7 revisions) (flutter/flutter#184594) 2026-04-03 [email protected] refactor: remove material from list_view_viewporting_test and page_forward_transitions_test (flutter/flutter#183564) 2026-04-03 [email protected] [Dot shorthands] Migrate examples/api/lib/cupertino (flutter/flutter#183964) 2026-04-03 [email protected] Downgrade CocoaPods doctor check to warning and fix build error messaging (flutter/flutter#184511) 2026-04-03 [email protected] Roll Skia from 4134f8091147 to 3b0f0f04f97c (2 revisions) (flutter/flutter#184582) 2026-04-03 [email protected] Remove live_text_utils cross-imports from material and cupertino tests (flutter/flutter#184517) 2026-04-03 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[data_assets] Cleanup tests (#184209)" (flutter/flutter#184575) 2026-04-03 [email protected] Roll Packages from 66bf7ec to d31df66 (3 revisions) (flutter/flutter#184578) 2026-04-03 [email protected] Roll Skia from 5d847ba5c4aa to 4134f8091147 (1 revision) (flutter/flutter#184573) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mbcorona
pushed a commit
to mbcorona/flutter
that referenced
this pull request
Apr 15, 2026
…rward_transitions_test (flutter#183564) This PR removes Material imports from list_view_viewporting_test and page_forward_transitions_test. This PR also adds onGenerateRoute on TestWidgetsApp. part of: flutter#177415 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes Material imports from list_view_viewporting_test and page_forward_transitions_test.
This PR also adds onGenerateRoute on TestWidgetsApp.
part of: #177415
Pre-launch Checklist
///).