Skip to content

Conversation

@xster
Copy link
Member

@xster xster commented Jun 9, 2018

No description provided.

@xster xster requested a review from willlarche June 9, 2018 09:41
@willlarche
Copy link
Contributor

@willlarche
Copy link
Contributor

I went ahead and published the package. Doing some Android testing right now. Looks great on iOS.

@willlarche
Copy link
Contributor

Looks good on Android.

@xster
Copy link
Member Author

xster commented Jun 11, 2018

I'll rerun the tests

@xster xster merged commit 304763d into flutter:master Jun 11, 2018
@xster xster deleted the assets_version branch June 11, 2018 18:30
dnfield added a commit to dnfield/flutter that referenced this pull request Jun 12, 2018
Update engine.version

update tests for TextStyle changes in engine (flutter#17982)

* update tests for TextStyle changes in engine

* roll engine, support Foreground on TextStyle

* Support for saving Dart compilation trace on device

(WIP) Expose foreground in framework TextStyle

use identical instead of ==

Add @istest annotation to testGesture (flutter#18311)

Notifies IDEs this is a test method, and helps e.g. the flutter plugin
recognize test methods and display them in the structure view in intellij.

Update gallery assets version with optipng (flutter#18327)

Passing any to named params require the name of the parameter itself. (flutter#18361)

Update typedef syntax to use Function notation and turn on lint for old notation. (flutter#18362)

Now that Dart 1 is turned off, reapplying my change to turn on the prefer_generic_function_type_aliases analysis option, and fix all the typedefs to Dart 2 preferred syntax.

Also eliminated the unused analysis_options_repo.yaml file and turned on public_member_api_docs in analysys_options.yaml.

No logic changes, just changing the typedef syntax for all typedefs, and updating analysis options.

More flexible timeout logic in flutter_test (flutter#18256)

This should reduce the number of flakes without actually increasing
the timeout, so we'll still find out quickly if a test is hanging.

The numbers here might need tweaking. Maybe the default two seconds is
too short for CI bots.

merge/apply/lerp prefer foreground

doc updates and update for copyWith
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants