Handle#6537 third grouped tests by ahmedsameha1 · Pull Request #183059 · flutter/flutter

ahmedsameha1 · 2026-02-28T09:29:11Z

This is my attempt to handle #6537 for the following widgets:
Placeholder
RadioGroup
RawMenuAnchor
RawMenuAnchorGroup
RawRadio
RawTooltip
ReorderableList
ReorderableDragStartListener
ReorderableDelayedDragStartListener
RepeatingAnimationBuilder

gemini-code-assist

Code Review

This pull request adds a series of widget tests to ensure that various widgets do not crash when rendered in a zero-sized area, addressing issue #6537. The new tests cover widgets like Placeholder, RadioGroup, RawMenuAnchor, RawTooltip, and ReorderableList, among others. My review includes a correction for a typo in a test name and a fix for a resource leak where a FocusNode was not being disposed of properly in one of the new tests.

victorsanni · 2026-03-04T00:22:23Z


 import 'package:flutter/foundation.dart';
 import 'package:flutter/gestures.dart';
+import 'package:flutter/material.dart';


We shouldn't import material/ in the widgets library.

victorsanni · 2026-03-04T00:22:46Z

+    tester.view.physicalSize = Size.zero;
+    addTearDown(tester.view.reset);
+    await tester.pumpWidget(
+      MaterialApp(


This can be done without MaterialApp, see TestWidgetsApp etc.

victorsanni · 2026-03-04T00:23:28Z

+
+  testWidgets('RadioGroup does not crash at zero area', (WidgetTester tester) async {
+    await tester.pumpWidget(
+      MaterialApp(


Does TestWidgetsApp work here?

As I see, this commit did not import any files.

We don't want to import material/ in widgets/ tests, see #177415 for more information.

When I followed #180456, I got:
The following assertion was thrown building Radio<int>(dirty, state: _RadioState<int>#c9c88): No Material widget found.

Radio is a Material library widget, I think you can test RadioGroup without using Radio. See RawRadio for instance.

victorsanni · 2026-03-04T00:23:50Z

+
+  testWidgets('ReorderableList does not crash at zero area', (WidgetTester tester) async {
+    await tester.pumpWidget(
+      MaterialApp(


TestWidgetsApp?

As I see, this commit did not import any files.

victorsanni · 2026-03-04T00:24:12Z

+    WidgetTester tester,
+  ) async {
+    await tester.pumpWidget(
+      const MaterialApp(


As I see, this commit did not import any files.

victorsanni · 2026-03-04T00:24:19Z

+    WidgetTester tester,
+  ) async {
+    await tester.pumpWidget(
+      const MaterialApp(


As I see, this commit did not import any files.

dkwingsmt

Generally LGTM except for TestWidgetsApp that @\victorsanni has pointed out.

…vironment

… 0x0 environment

…onment

…rouped-tests

dkwingsmt

LGTM. Thank you!

victorsanni · 2026-03-13T18:30:37Z

+    addTearDown(focusNode2.dispose);
+    await tester.pumpWidget(
+      TestWidgetsApp(
+        home: Scaffold(


Scaffold is a Material widget.

victorsanni · 2026-03-13T18:38:02Z

 import 'package:flutter_test/flutter_test.dart';

 import 'editable_text_tester.dart';
+import 'raw_radio_test.dart';


Why are we importing a test? This is causing the linux analyze failures.

TestRegistry is from 'raw_radio_test.dart', final RadioGroupRegistry<T>? groupRegistry is required for RawRadio.

I recommend copying the TestRegistry class to this file. It's ok since it's a small class.

If in the future there are larger code snippets to be shared between files, they should be placed in dedicated util files such as widgets_app_tester.dart. Test files should never be imported to another.

auto-submit · 2026-03-24T23:38:13Z

autosubmit label was removed for flutter/flutter/183059, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR.

justinmc

Re LGTM now that they've expired 👍

Piinks · 2026-03-31T22:11:12Z

This might get bumped out of autosubmit again, I can't tell if this was a merge or a rebase to update. If it kicks it back out, it should be rebased to update the base commit.

Roll Flutter from fb03253e32ce to 3d69471c0bf9 (69 revisions) flutter/flutter@fb03253...3d69471 2026-04-01 [email protected] Roll Dart SDK from 1308a3076402 to 043a2bfd56ff (1 revision) (flutter/flutter#184453) 2026-04-01 [email protected] Roll Skia from a657b5446209 to c2363c39c283 (2 revisions) (flutter/flutter#184448) 2026-04-01 [email protected] Fix layout overflowed in small screen in SensitiveContent's example (flutter/flutter#184179) 2026-04-01 [email protected] Roll Skia from e0b25041a5d5 to a657b5446209 (1 revision) (flutter/flutter#184445) 2026-04-01 [email protected] Roll Dart SDK from 75a089eb6bf9 to 1308a3076402 (3 revisions) (flutter/flutter#184444) 2026-04-01 [email protected] [AGP 9] Bumping KGP error minimum to 2.0.0 (flutter/flutter#184385) 2026-04-01 [email protected] [ Tool ] Migrate `flutter analyze` to use LSP (flutter/flutter#183785) 2026-04-01 [email protected] Adds uber sdf shader gradients with blend (flutter/flutter#184090) 2026-04-01 [email protected] Add bottom safe area padding to licenses package license page (flutter/flutter#182425) 2026-04-01 [email protected] Handle#6537 third grouped tests (flutter/flutter#183059) 2026-04-01 [email protected] Roll Skia from f37239a7a689 to e0b25041a5d5 (9 revisions) (flutter/flutter#184436) 2026-03-31 [email protected] [Impeller] Do not log an error when wrapping an empty texture as a TextureGLES (flutter/flutter#184377) 2026-03-31 [email protected] Remove the default_git_folder GN argument (flutter/flutter#184152) 2026-03-31 [email protected] Remove the cupertino_icons dependency from the spell_check integration test (flutter/flutter#184398) 2026-03-31 [email protected] Roll Fuchsia Linux SDK from pM94cWC9cSgao0CG0... to fV-JIWUt4FQGeDtEe... (flutter/flutter#184383) 2026-03-31 [email protected] Roll Dart SDK from eaeccf98848d to 75a089eb6bf9 (1 revision) (flutter/flutter#184379) 2026-03-31 [email protected] [web] Fix autofill in iOS 26 Safari (flutter/flutter#182024) 2026-03-31 [email protected] Roll Fuchsia GN SDK from SEfYx3xgueX3aFAY3... to JLBh4Z9PKsjIJcqDU... (flutter/flutter#184368) 2026-03-31 [email protected] [Windows] Restore and enable IAccessibleEx implementation (flutter/flutter#175406) 2026-03-31 [email protected] Revert "Even more awaits (#184042)" (flutter/flutter#184429) 2026-03-31 [email protected] Roll Skia from dfd8f8002800 to f37239a7a689 (2 revisions) (flutter/flutter#184374) 2026-03-31 [email protected] Remove workaround for fake impeller images in iOS simulator. (flutter/flutter#184264) 2026-03-31 [email protected] Even more awaits (flutter/flutter#184042) 2026-03-31 [email protected] Roll Packages from 582f0e7 to b04f3e5 (6 revisions) (flutter/flutter#184393) 2026-03-30 [email protected] Fixes a flake in reload shaders tests (flutter/flutter#184268) 2026-03-30 [email protected] Remove an obsolete script for setting up remote GDB sessions on Android devices (flutter/flutter#184357) 2026-03-30 [email protected] Roll Skia from 8dcde79fef2a to dfd8f8002800 (10 revisions) (flutter/flutter#184363) 2026-03-30 [email protected] Roll Dart SDK from 0aaccc3c8004 to eaeccf98848d (2 revisions) (flutter/flutter#184362) 2026-03-30 [email protected] [ Tool ] Remove `flutter running-apps` command (flutter/flutter#183742) 2026-03-30 [email protected] Roll pub packages (flutter/flutter#184045) 2026-03-30 [email protected] Rick roll triagers on/near April 1st (flutter/flutter#184355) 2026-03-30 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 5.5.0 to 6.0.0 in the all-github-actions group (flutter/flutter#184364) 2026-03-30 [email protected] fix(web): call ui.Picture.onDispose for the original picture only (flutter/flutter#184348) 2026-03-30 [email protected] Roll Skia from e001e6901e3b to 8dcde79fef2a (7 revisions) (flutter/flutter#184356) 2026-03-30 [email protected] [web] Make it safe to call dispose multiple times on a CkSurface (flutter/flutter#184270) 2026-03-30 [email protected] Roll HarfBuzz to 13.2.1 (flutter/flutter#184210) 2026-03-30 [email protected] web_ui: Remove unused parameters in a few places (flutter/flutter#183156) 2026-03-30 [email protected] Update TabBar documentation to clarify indicatorWeight behavior (flutter/flutter#184104) 2026-03-30 [email protected] Add title evaluation (flutter/flutter#184084) 2026-03-30 [email protected] fixes crash when invisible semantics nodes dropped from semantics tree (flutter/flutter#184226) 2026-03-30 [email protected] Roll Skia from cdaae3e3fdef to e001e6901e3b (4 revisions) (flutter/flutter#184345) 2026-03-30 [email protected] Roll Packages from 7ae082a to 582f0e7 (8 revisions) (flutter/flutter#184341) 2026-03-30 [email protected] Add alwaysSizeToContent argument to Overlay. (flutter/flutter#182009) 2026-03-30 [email protected] Roll Dart SDK from 598088a8a67f to 0aaccc3c8004 (1 revision) (flutter/flutter#184331) 2026-03-30 [email protected] Roll Skia from 6d7ade938643 to cdaae3e3fdef (2 revisions) (flutter/flutter#184329) 2026-03-30 [email protected] Roll Fuchsia Linux SDK from EnoD6zNQebz4EYuLk... to pM94cWC9cSgao0CG0... (flutter/flutter#184323) ...

This is my attempt to handle flutter#6537 for the following widgets: Placeholder RadioGroup RawMenuAnchor RawMenuAnchorGroup RawRadio RawTooltip ReorderableList ReorderableDragStartListener ReorderableDelayedDragStartListener RepeatingAnimationBuilder --------- Co-authored-by: Tong Mu <[email protected]> Co-authored-by: Justin McCandless <[email protected]>

Make sure that a Placeholder doesn't crash in 0x0 environment

4def1ea

github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. a: animation Animation APIs labels Feb 28, 2026

gemini-code-assist Bot reviewed Feb 28, 2026

View reviewed changes

Comment thread packages/flutter/test/widgets/raw_radio_test.dart Outdated

Comment thread packages/flutter/test/widgets/radio_group_test.dart Outdated

ahmedsameha1 added 4 commits February 28, 2026 12:01

Make sure that a RadioGroup doesn't crash at 0x0 environment

079d947

Make sure that a RawMenuAnchor doesn't crash in 0x0 environment

f359350

Make sure that a RawMenuAnchorGroup doesn't crash in 0x0 environment

7eb6596

Make sure that a RawRadio doesn't crash in 0x0 environment

8c847c6

ahmedsameha1 force-pushed the handle#6537-third-grouped-tests branch from 1d4e0da to 6f74440 Compare February 28, 2026 10:01

justinmc requested review from dkwingsmt and victorsanni March 3, 2026 23:20

victorsanni reviewed Mar 4, 2026

View reviewed changes

Make sure that a RawTooltip doesn't crash in 0x0 environment

8922851

ahmedsameha1 force-pushed the handle#6537-third-grouped-tests branch from 6f74440 to 065020b Compare March 4, 2026 05:31

dkwingsmt reviewed Mar 5, 2026

View reviewed changes

ahmedsameha1 added 4 commits March 5, 2026 07:16

Make sure that a ReorderableList doesn't crash in 0x0 environment

39cb063

Make sure that a ReorderableDragStartListener doesn't crash in 0x0 en…

d1a9671

…vironment

Make sure that a ReorderableDelayedDragStartListener doesn't crash in…

5018e18

… 0x0 environment

Make sure that a RepeatingAnimationBuilder doesn't crash in 0x0 envir…

02b1cfa

…onment

ahmedsameha1 force-pushed the handle#6537-third-grouped-tests branch from 065020b to 02b1cfa Compare March 5, 2026 05:25

Merge remote-tracking branch 'origin/master' into handle#6537-third-g…

8a59b74

…rouped-tests

justinmc requested review from dkwingsmt and victorsanni March 10, 2026 22:35

dkwingsmt previously approved these changes Mar 13, 2026

View reviewed changes

victorsanni reviewed Mar 13, 2026

View reviewed changes

ahmedsameha1 dismissed dkwingsmt’s stale review via 12b36b8 March 14, 2026 05:20

ahmedsameha1 force-pushed the handle#6537-third-grouped-tests branch from 3e0b84f to 12b36b8 Compare March 14, 2026 05:20

dkwingsmt added CICD Run CI/CD and removed CICD Run CI/CD labels Mar 14, 2026

github-actions Bot removed the CICD Run CI/CD label Mar 17, 2026

dkwingsmt approved these changes Mar 17, 2026

View reviewed changes

dkwingsmt requested a review from victorsanni March 17, 2026 22:45

dkwingsmt added the CICD Run CI/CD label Mar 17, 2026

victorsanni approved these changes Mar 24, 2026

View reviewed changes

victorsanni added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 24, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 24, 2026

Merge branch 'master' into handle#6537-third-grouped-tests

c458ec0

github-actions Bot removed the CICD Run CI/CD label Mar 31, 2026

justinmc requested a review from Piinks March 31, 2026 22:09

justinmc approved these changes Mar 31, 2026

View reviewed changes

Piinks added autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD labels Mar 31, 2026

auto-submit Bot added this pull request to the merge queue Apr 1, 2026

Merged via the queue into flutter:master with commit 292cea7 Apr 1, 2026
79 of 80 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 1, 2026

engine-flutter-autoroll mentioned this pull request Apr 1, 2026

Roll Flutter from fb03253e32ce to 3d69471c0bf9 (69 revisions) flutter/packages#11408

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2026

292cea7a0 Handle#6537 third grouped tests (flutter/flutter#183059)

7869618

engine-flutter-autoroll mentioned this pull request Apr 1, 2026

Roll Flutter from fb03253e32ce to 984d612baac2 (70 revisions) flutter/packages#11409

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2026

292cea7a0 Handle#6537 third grouped tests (flutter/flutter#183059)

27fef12

engine-flutter-autoroll mentioned this pull request Apr 1, 2026

Roll Flutter from fb03253e32ce to 22bc19ec8c34 (71 revisions) flutter/packages#11411

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2026

292cea7a0 Handle#6537 third grouped tests (flutter/flutter#183059)

8479ad9

engine-flutter-autoroll mentioned this pull request Apr 1, 2026

Roll Flutter from fb03253e32ce to 1460ed7e2630 (72 revisions) flutter/packages#11412

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2026

292cea7a0 Handle#6537 third grouped tests (flutter/flutter#183059)

c3d4353

Conversation

ahmedsameha1 commented Feb 28, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dkwingsmt Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

auto-submit Bot commented Mar 24, 2026

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Piinks commented Mar 31, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dkwingsmt Mar 16, 2026 •

edited

Loading