It's time to #deleteDart1 #18293
Merged
It's time to #deleteDart1 #18293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Apologies for the giant patch. Each of the commits is pretty self-contained, which should make review a bit easier. Since there's really no case where it makes sense to partially force the tool to operate in Dart 2 mode, the plan is to squash and merge in one go once it's through review. |
gspencergoog
approved these changes
Jun 8, 2018
Contributor
There was a problem hiding this comment.
You can just say "Include the kernel...", since there is no Dart 1...
Contributor
|
Luckily there are a lot of deletes. Those are pretty easy to review. :-) |
Contributor
|
|
Member
Author
tvolkert
approved these changes
Jun 8, 2018
Contributor
tvolkert
left a comment
tvolkert
left a comment
There was a problem hiding this comment.
We should also be able to get rid of the *_dart1 benchmarks in the devicelab manifest.yaml.
tvolkert
approved these changes
Jun 8, 2018
Contributor
tvolkert
left a comment
tvolkert
left a comment
There was a problem hiding this comment.
LGTM
After this, we get to delete the new usages!
cbracken
added a commit
to cbracken/flutter
that referenced
this pull request
Jun 8, 2018
Several benchmarks started failing during kernel compile: 1. Timeouts: * commands_test * hot_mode_dev_cycle__benchmark * run_machine_concurrent_hot_reload * service_extensions_test 2. Kernel compiler crash: * hot_mode_dev_cycle_linux__benchmark * routing_test 3. Unexpected termination: * hot_mode_dev_cycle_win__benchmark This reverts commit ed63e70.
cbracken
added a commit
that referenced
this pull request
Jun 8, 2018
Several benchmarks started failing during kernel compile: 1. Timeouts: * commands_test * hot_mode_dev_cycle__benchmark * run_machine_concurrent_hot_reload * service_extensions_test 2. Kernel compiler crash: * hot_mode_dev_cycle_linux__benchmark * routing_test 3. Unexpected termination: * hot_mode_dev_cycle_win__benchmark This reverts commit ed63e70.
cbracken
added a commit
to cbracken/flutter
that referenced
this pull request
Jun 8, 2018
Eliminates support for Dart 1 in flutter_tools, and drops our Dart 1 benchmarks. All commands now run in Dart 1 mode only. Eliminates --preview-dart-2 / --no-preview-dart-2 support.
cbracken
added a commit
that referenced
this pull request
Jun 8, 2018
* It's time to #deleteDart1 (#18293) Eliminates support for Dart 1 in flutter_tools, and drops our Dart 1 benchmarks. All commands now run in Dart 1 mode only. Eliminates --preview-dart-2 / --no-preview-dart-2 support. * Fix indentation, remove no longer necessary .toList() * Only push udpated kernel if >0 invalidated srcs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates --preview-dart-2 flag from flutter_tools. All commands now run Dart 2 only.