[web] Roll Chrome to 145 (framework)#182861
Merged
Merged
Conversation
github-actions
Bot
added
engine
mdebbar
force-pushed
the
chrome_145_framework
branch
from
February 26, 2026 18:50
44c1e8c to
1a0f0d2
Compare
github-actions
Bot
added
the
tool
Contributor
|
Greetings from stale PR triage! 👋 |
mdebbar
force-pushed
the
chrome_145_framework
branch
from
May 18, 2026 14:58
adf6309 to
6b20390
Compare
Add support for detecting ARM architecture on macOS.
kevmoo
force-pushed
the
chrome_145_framework
branch
from
May 27, 2026 21:45
47db658 to
442f524
Compare
kevmoo
marked this pull request as ready for review
May 28, 2026 18:23
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Chrome and Chromedriver dependencies to version 145.0.7632.117 across CI configurations and introduces the --password-store=basic and --use-mock-keychain flags to prevent credential store prompts during testing. Additionally, on ARM macOS, the logic forcing native ARM launch is removed in favor of appending the --use-angle=metal flag to bypass SwiftShader limitations. Review feedback suggests restricting this new flag to headless mode only, as the software rendering issue with SwiftShader specifically impacts headless execution.
…orkaround to headless mode - Restrict --use-mock-keychain to macOS platforms. - Restrict the --use-angle=metal SwiftShader workaround on ARM macOS to headless executions. - Update Chrome launcher tests to validate headed, headless, and cross-platform behaviors.
Contributor
|
@mdebbar – did some more tweaks on top of your tweaks and pushed. PTAL! |
kevmoo
reviewed
Jun 1, 2026
…vent CanvasKit hangs Under Chrome 145+, passing --disable-dev-shm-usage unconditionally forces Chrome to write all shared memory IPC buffers to /tmp. While this is required for Wasm/SkWasm multi-threaded tests to avoid crashing on the 64MB /dev/shm limit in containerized environments, it degrades disk IPC performance and causes standard CanvasKit tests to hang/timeout on CI. Restores the previous behavior where --disable-dev-shm-usage is passed only when useWasm is true. CONV=b0179f43-b48a-45ed-8b0f-df9a00890861 TAG=agy
# Conflicts: # .ci.yaml # packages/flutter_tools/test/commands.shard/hermetic/build_macos_test.dart
Increase reloadRestartTimeout and log check timeouts to 30s to reduce flakiness on CI. Format modified files to resolve linux_unopt failures.
This ignores the lint for the debug print we added to capture browser logs. Both should be reverted before merging if CI goes green.
Resolve template change detection failure by formatting the template to match the formatted implementation file.
Clean up the PR by reverting whitespace-only, formatting-only, and other unrelated changes in 17 files to match origin/master.
harryterkelsen
requested changes
Jul 8, 2026
harryterkelsen
requested changes
Jul 8, 2026
harryterkelsen
left a comment
harryterkelsen
left a comment
Contributor
There was a problem hiding this comment.
Thanks, Kevin! A couple more small things I missed on my first pass
Contributor
|
autosubmit label was removed for flutter/flutter/182861, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
This was referenced Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.