Move widget_preview_scaffold into pub workspace by jmagman · Pull Request #182627 · flutter/flutter

jmagman · 2026-02-19T18:38:19Z

I noticed the pub roller is often touching widget_preview_scaffold #182579. However, that should be part of the pub workspace.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

gemini-code-assist

Code Review

The pull request aims to move widget_preview_scaffold into the pub workspace, which involves significant changes to pubspec.yaml and pubspec.lock files. The changes in pubspec.yaml for widget_preview_scaffold remove explicit versioning and publish_to: "none", and replace specific dependency versions with any, indicating that these dependencies will be managed by the workspace. The pubspec.lock file reflects the addition of several transitive dependencies, which is expected when moving a package into a larger workspace. The main pubspec.yaml is updated to include dev/integration_tests/widget_preview_scaffold in the workspace. Overall, the changes align with the goal of integrating widget_preview_scaffold into the pub workspace.

bkonyi · 2026-02-24T19:22:24Z

Thanks! I thought I had done this, but apparently not!

jtmcdole · 2026-03-03T17:19:15Z

I thought this was intentionally not added to workspaces?

I'm updating some android integration tests as well.

Piinks · 2026-03-23T21:41:41Z

Greetings from triage - do we want to land this change?

auto-submit · 2026-04-06T21:39:23Z

autosubmit label was removed for flutter/flutter/182627, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR.

auto-submit · 2026-04-06T21:39:23Z

autosubmit label was removed for flutter/flutter/182627, because Pull request flutter/flutter/182627 is not in a mergeable state.

…utter#182627)

Roll Flutter from c1b14e92dcfb to 31f1802cb859 (46 revisions) flutter/flutter@c1b14e9...31f1802 2026-04-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (#185083)" (flutter/flutter#185145) 2026-04-16 [email protected] Add oval drawing support to the SDF uber shader (flutter/flutter#184903) 2026-04-16 [email protected] Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (flutter/flutter#185083) 2026-04-16 [email protected] Roll Skia from 2c49b3f9c3c2 to 391cdbe3ffe9 (2 revisions) (flutter/flutter#185138) 2026-04-16 [email protected] Roll Dart SDK from 4ee990654146 to fbddcbe0cd96 (1 revision) (flutter/flutter#185137) 2026-04-16 [email protected] Roll Skia from f4e3cd2c2159 to 2c49b3f9c3c2 (14 revisions) (flutter/flutter#185131) 2026-04-16 [email protected] Roll Dart SDK from 87b7c87e7207 to 4ee990654146 (5 revisions) (flutter/flutter#185108) 2026-04-15 [email protected] Use the `flutteractionsbot` token to push the release branch. (flutter/flutter#184833) 2026-04-15 [email protected] Allow period characters in iOS and macOS framework names (flutter/flutter#184335) 2026-04-15 [email protected] Fix SliverResizingHeader semantic focus (flutter/flutter#179690) 2026-04-15 [email protected] ignore avoid_type_to_string lint rule in flutter_tools (flutter/flutter#184766) 2026-04-15 [email protected] Roll Skia from bda7232e6772 to f4e3cd2c2159 (4 revisions) (flutter/flutter#185063) 2026-04-15 [email protected] Add initial AI guidance for issues (flutter/flutter#184885) 2026-04-15 [email protected] Roll Fuchsia Linux SDK from rB8LAuZL_DwHMssTU... to IdBT8fSMYrYSip65j... (flutter/flutter#185064) 2026-04-15 [email protected] Fix an ordering dependency in the services/system_chrome_test.dart test suite (flutter/flutter#185086) 2026-04-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ios][platform_view]Reland hitTest approach (with a few 2026 update) (#183484)" (flutter/flutter#185082) 2026-04-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (#179810)" (flutter/flutter#185067) 2026-04-15 [email protected] Agent rule: Dart editing (flutter/flutter#185045) 2026-04-15 [email protected] [ios][platform_view]Reland hitTest approach (with a few 2026 update) (flutter/flutter#183484) 2026-04-15 [email protected] Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (flutter/flutter#179810) 2026-04-15 [email protected] Roll Dart SDK from ee5afcef0596 to 87b7c87e7207 (4 revisions) (flutter/flutter#185060) 2026-04-15 [email protected] Roll Skia from 4c382df6a25a to bda7232e6772 (7 revisions) (flutter/flutter#185057) 2026-04-15 [email protected] Remove material import from toggleable_test.dart + draggable_test.dart + obscured_animated_image_test.dart + sliver_constraints_test.dart (flutter/flutter#181774) 2026-04-15 [email protected] refactor: Remove material imports from Widget tests (flutter/flutter#184877) 2026-04-14 [email protected] Adds missing `await`s on forgotten cases (flutter/flutter#183466) 2026-04-14 [email protected] Use an if-element in a collection literal instead of a conditional expression (flutter/flutter#184830) 2026-04-14 [email protected] update popular issues documentation (flutter/flutter#183196) 2026-04-14 [email protected] [Android] Add integration test for setting engine flags via the manifest (flutter/flutter#182241) 2026-04-14 [email protected] [fuchsia] Ask for both ambient-replace and VMEX to allow for a softer transition. (flutter/flutter#185042) 2026-04-14 [email protected] Make `multiple_windows` follow repo analyzer rules (flutter/flutter#184753) 2026-04-14 [email protected] Ignore incoming deprecated_web_configuration lint (flutter/flutter#184130) 2026-04-14 [email protected] [AGP 9] Update AGP Error (flutter/flutter#185043) 2026-04-14 [email protected] Move widget_preview_scaffold into pub workspace (flutter/flutter#182627) 2026-04-14 [email protected] Fix gles interactive tests (flutter/flutter#181389) 2026-04-14 [email protected] Update customer tests.version (flutter/flutter#185044) 2026-04-14 [email protected] [SKILL] upgrade-browser (flutter/flutter#184894) 2026-04-14 [email protected] [ci] Split up integration.shard dart_data_asset_test.dart (flutter/flutter#185021) 2026-04-14 [email protected] Hold startup lock until after `pub get` to prevent races (flutter/flutter#184294) 2026-04-14 6226493[email protected] Add `--include-example` flag to `flutter clean` for package example projects (flutter/flutter#183455) 2026-04-14 [email protected] Disable multi-pack-index when calling flutter from Xcode (flutter/flutter#184998) 2026-04-14 [email protected] Fix icon tree shaking when building for desktop (flutter/flutter#184249) 2026-04-14 [email protected] Fix killing wrong xcrun command (flutter/flutter#184831) 2026-04-14 [email protected] Allow Xcode build configuration to not contain flavor name (flutter/flutter#183398) 2026-04-14 [email protected] [web] Async rendering for benchmarks (flutter/flutter#184677) 2026-04-14 [email protected] [ci] Split up integration.shard native_assets_test.dart (flutter/flutter#185020) 2026-04-14 [email protected] Skip flutter widget-preview test that times out frequently (flutter/flutter#184988) ...

…)" This reverts commit f42a086.

flutteractionsbot · 2026-04-16T17:44:45Z

A reason for requesting a revert of flutter/flutter/182627 could not be found or the reason was not properly formatted. Begin a comment with 'Reason for revert:' to tell the bot why this issue is being reverted.

loic-sharma · 2026-04-16T17:45:08Z

Reason for revert: this broke the tree. Example failure: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20packages_autoroller/20101/overview

You can reproduce the error locally by running:

flutter --verbose update-packages --force-upgrade

I suspect the flutter update-packages command needs to be updated. See:

flutter/packages/flutter_tools/lib/src/commands/update_packages.dart

Lines 175 to 181 in 31f1802

    
           // This package is intentionally not part of the workspace as it's a rehydrated template. 
        
           final FlutterProject widgetPreviewScaffoldProject = FlutterProject.fromDirectory( 
        
             rootProject.directory 
        
                 .childDirectory('dev') 
        
                 .childDirectory('integration_tests') 
        
                 .childDirectory('widget_preview_scaffold'), 
        
           );

flutteractionsbot · 2026-04-16T17:46:54Z

Successfully created revert PR: #185164

…)" This reverts commit f42a086.

@loic-sharma

Reverts: [Move widget_preview_scaffold into pub workspace](#182627) Initiated by: @loic-sharma Reason for reverting: this broke the tree. Example failure: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20packages_autoroller/20101/overview Original PR Author: @jmagman Reviewed By: @bkonyi The original PR description is provided below: I noticed the pub roller is often touching widget_preview_scaffold #182579. However, that should be part of the pub workspace. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

jmagman self-assigned this Feb 19, 2026

github-actions Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 19, 2026

jmagman force-pushed the workspace branch from 0df3bec to d691ab2 Compare February 19, 2026 20:20

github-actions Bot removed the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 19, 2026

jmagman marked this pull request as ready for review February 20, 2026 05:48

gemini-code-assist Bot reviewed Feb 20, 2026

View reviewed changes

jmagman requested a review from bkonyi February 20, 2026 21:00

bkonyi previously approved these changes Feb 24, 2026

View reviewed changes

reidbaker previously approved these changes Apr 3, 2026

View reviewed changes

jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 6, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 6, 2026

jmagman mentioned this pull request Apr 6, 2026

Set path_provider_android version #184688

Closed

10 tasks

jmagman dismissed stale reviews from reidbaker and bkonyi via 7e3717c April 6, 2026 23:02

jmagman force-pushed the workspace branch from 142a6e7 to 7e3717c Compare April 6, 2026 23:02

github-actions Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 6, 2026

jmagman added the CICD Run CI/CD label Apr 6, 2026

jmagman force-pushed the workspace branch from e4afc32 to 53dff41 Compare April 6, 2026 23:39

github-actions Bot removed the CICD Run CI/CD label Apr 6, 2026

jmagman added the CICD Run CI/CD label Apr 6, 2026

github-actions Bot removed the CICD Run CI/CD label Apr 7, 2026

jmagman added the CICD Run CI/CD label Apr 7, 2026

jmagman force-pushed the workspace branch from 6abb3f3 to 8569ea5 Compare April 9, 2026 15:39

github-actions Bot removed tool Affects the "flutter" command-line tool. See also t: labels. CICD Run CI/CD labels Apr 9, 2026

bkonyi approved these changes Apr 10, 2026

View reviewed changes

reidbaker approved these changes Apr 10, 2026

View reviewed changes

jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 14, 2026

auto-submit Bot added this pull request to the merge queue Apr 14, 2026

Merged via the queue into flutter:master with commit f42a086 Apr 15, 2026
167 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 15, 2026

engine-flutter-autoroll mentioned this pull request Apr 15, 2026

Roll Flutter from c1b14e92dcfb to 4634b93d8c03 (30 revisions) flutter/packages#11513

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2026

f42a086b6 Move widget_preview_scaffold into pub workspace (flutter/fl…

6cce8ae

…utter#182627)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2026

f42a086b6 Move widget_preview_scaffold into pub workspace (flutter/fl…

6f3848f

…utter#182627)

engine-flutter-autoroll mentioned this pull request Apr 15, 2026

Roll Flutter from c1b14e92dcfb to ab21ec800abf (31 revisions) flutter/packages#11514

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2026

f42a086b6 Move widget_preview_scaffold into pub workspace (flutter/fl…

21b6840

…utter#182627)

engine-flutter-autoroll mentioned this pull request Apr 15, 2026

Roll Flutter from c1b14e92dcfb to 6154f7548c56 (32 revisions) flutter/packages#11515

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 16, 2026

f42a086b6 Move widget_preview_scaffold into pub workspace (flutter/fl…

3bbe5f8

…utter#182627)

engine-flutter-autoroll mentioned this pull request Apr 16, 2026

Roll Flutter from c1b14e92dcfb to 31f1802cb859 (46 revisions) flutter/packages#11518

Merged

loic-sharma added a commit to loic-sharma/flutter that referenced this pull request Apr 16, 2026

Revert "Move widget_preview_scaffold into pub workspace (flutter#182627…

c0653c6

…)" This reverts commit f42a086.

loic-sharma added the revert_wf Revert using Github Workflow label Apr 16, 2026

flutteractionsbot removed the revert_wf Revert using Github Workflow label Apr 16, 2026

loic-sharma added the revert_wf Revert using Github Workflow label Apr 16, 2026

flutteractionsbot mentioned this pull request Apr 16, 2026

Revert "Move widget_preview_scaffold into pub workspace" #185164

Merged

9 tasks

flutteractionsbot removed the revert_wf Revert using Github Workflow label Apr 16, 2026

flutteractionsbot added a commit to flutteractionsbot/flutter that referenced this pull request Apr 16, 2026

Revert "Move widget_preview_scaffold into pub workspace (flutter#182627…

457d957

…)" This reverts commit f42a086.

gaaclarke mentioned this pull request Apr 16, 2026

exclude widget_preview_scaffold from pubspec updates #185167

Closed

10 tasks

gaaclarke mentioned this pull request Apr 16, 2026

Linux packages_autoroller red on pub failure #185161

Closed

Conversation

jmagman commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bkonyi commented Feb 24, 2026

Uh oh!

jtmcdole commented Mar 3, 2026

Uh oh!

Piinks commented Mar 23, 2026

Uh oh!

auto-submit Bot commented Apr 6, 2026

Uh oh!

auto-submit Bot commented Apr 6, 2026

Uh oh!

Uh oh!

flutteractionsbot commented Apr 16, 2026

Uh oh!

loic-sharma commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flutteractionsbot commented Apr 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

jmagman commented Feb 19, 2026 •

edited

Loading

loic-sharma commented Apr 16, 2026 •

edited

Loading