More flexible timeout logic in flutter_test #18256
Conversation
There was a problem hiding this comment.
The advantage of putting them in brackets is that although dartdoc won't hyperlink them, IDEs see it as a reference to the argument, and refactoring tools will automatically rename these references.
There was a problem hiding this comment.
we need a way to distinguish them. The square brackets will suddenly start hyperlinking if something called "callback" is added to the scope, otherwise.
There was a problem hiding this comment.
There was a problem hiding this comment.
This won't cause the test to fail, right? Can we add a test to verify that home-growth timeout logic will correctly cause a slow test to fail?
There was a problem hiding this comment.
haha i was waiting for you to ask for a test... Ok I'll try to figure out how to write one.
dev/bots/test.dart
Outdated
There was a problem hiding this comment.
well this is wrong. oops.
Hixie
force-pushed
the
flake
branch
2 times, most recently
from
6e42f75 to
3c2b06e
Compare
|
@tvolkert PTAL. I've added some smoke tests for this. I've also made the bulk of the smoke tests run in parallel to save some time. (I left the control pass and control fail tests out of the parallelism since those are particularly critical and so if they fail I want them to fail first.) |
|
dev/bots/test.dart
Outdated
There was a problem hiding this comment.
Add a comment about how the main pass and fail tests get special priority but that all other smoke tests belong in the parallel block below.
Hixie
force-pushed
the
flake
branch
2 times, most recently
from
e2f3bb6 to
26fb274
Compare
|
Windows failed... I wonder if it's because making things parallel overloaded the bot. |
tvolkert
left a comment
tvolkert
left a comment
There was a problem hiding this comment.
LGTM, modulo Windows bot failure
This should reduce the number of flakes without actually increasing the timeout, so we'll still find out quickly if a test is hanging. The numbers here might need tweaking. Maybe the default two seconds is too short for CI bots.
Update engine.version update tests for TextStyle changes in engine (flutter#17982) * update tests for TextStyle changes in engine * roll engine, support Foreground on TextStyle * Support for saving Dart compilation trace on device (WIP) Expose foreground in framework TextStyle use identical instead of == Add @istest annotation to testGesture (flutter#18311) Notifies IDEs this is a test method, and helps e.g. the flutter plugin recognize test methods and display them in the structure view in intellij. Update gallery assets version with optipng (flutter#18327) Passing any to named params require the name of the parameter itself. (flutter#18361) Update typedef syntax to use Function notation and turn on lint for old notation. (flutter#18362) Now that Dart 1 is turned off, reapplying my change to turn on the prefer_generic_function_type_aliases analysis option, and fix all the typedefs to Dart 2 preferred syntax. Also eliminated the unused analysis_options_repo.yaml file and turned on public_member_api_docs in analysys_options.yaml. No logic changes, just changing the typedef syntax for all typedefs, and updating analysis options. More flexible timeout logic in flutter_test (flutter#18256) This should reduce the number of flakes without actually increasing the timeout, so we'll still find out quickly if a test is hanging. The numbers here might need tweaking. Maybe the default two seconds is too short for CI bots. merge/apply/lerp prefer foreground doc updates and update for copyWith
3 participants
This should reduce the number of flakes without actually increasing
the timeout, so we'll still find out quickly if a test is hanging.
The numbers here might need tweaking. Maybe the default two seconds is
too short for CI bots.
cc @tvolkert