Compare SemanticsHandler# at end of test to value at beginning of test #18183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
approved these changes
Jun 4, 2018
| _semanticsHandles = null; | ||
| } | ||
|
|
||
| int _semanticsHandles; |
Contributor
There was a problem hiding this comment.
I'd use a more specific name. As is it implies the current number of semantic handles, while you want to convey something like "last recorded", or "before test started".
goderbauer
force-pushed
the
semanticsHandlers
branch
from
53685c6 to
f29e196
Compare
goderbauer
added
framework
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18015
/cc @yjbanov