Remove Material Dependency from `semantics_debugger_test` by rizwan-saleem · Pull Request #181722 · flutter/flutter

rizwan-saleem · 2026-01-30T11:48:33Z

This change refactors semantics_debugger_test.dart to eliminate its dependency on Material widgets, as part of the test reorganization effort to ensure tests only depend on the library code they are testing.

Changes

Replace Material import with widgets import in semantics_debugger_test.dart
Replace ElevatedButton with TestButton (2 tests)
Replace Slider with TestSlider (1 test)
Replace Checkbox with TestCheckbox (2 tests)
Replace TextField with TestTextField (1 test)
Replace MaterialApp with TestWidgetsApp (2 tests)
Remove Material wrapper widgets throughout tests
Replace Colors constants with explicit Color values

New Test Widgets Created

`TestSlider`

A minimal slider with semantics support for testing.

Implements onIncrease / onDecrease semantic actions
Supports min/max range and divisions
Uses a 10% adjustment unit for continuous sliders

`TestCheckbox`

A minimal checkbox with semantics support for testing.

Implements checked state and onTap semantic action
Supports enabled and disabled states

Enhanced Existing Test Widget

`TestTextField`

Updated to better match the Material TextField semantics structure.

Added a Semantics wrapper
Provides enabled state and onTap action
Allows tests to find Semantics descendants as expected

Test Results

All 21 tests pass successfully with the new test widget
Part of #177414

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

This change refactors `semantics_debugger_test.dart` to eliminate its dependency on **Material** widgets, as part of the test reorganization effort to ensure tests only depend on the library code they are testing. --- ## Changes - Replace `Material` import with `widgets` import in `semantics_debugger_test.dart` - Replace `ElevatedButton` with `TestButton` (2 tests) - Replace `Slider` with `TestSlider` (1 test) - Replace `Checkbox` with `TestCheckbox` (2 tests) - Replace `TextField` with `TestTextField` (1 test) - Replace `MaterialApp` with `TestWidgetsApp` (2 tests) - Remove `Material` wrapper widgets throughout tests - Replace `Colors` constants with explicit `Color` values --- ## New Test Widgets Created ### `TestSlider` A minimal slider with semantics support for testing. - Implements `onIncrease` / `onDecrease` semantic actions - Supports min/max range and divisions - Uses a **10% adjustment unit** for continuous sliders ### `TestCheckbox` A minimal checkbox with semantics support for testing. - Implements checked state and `onTap` semantic action - Supports enabled and disabled states --- ## Enhanced Existing Test Widget ### `TestTextField` Updated to better match the Material `TextField` semantics structure. - Added a `Semantics` wrapper - Provides enabled state and `onTap` action - Allows tests to find `Semantics` descendants as expected --- ## Test Results All **21 tests pass** successfully with the new test widget

gemini-code-assist

Code Review

This pull request successfully refactors semantics_debugger_test.dart to eliminate its dependency on Material widgets, which is a great improvement for test modularity. The introduction of minimal test widgets like TestSlider and TestCheckbox is well-executed. My review includes a few suggestions to simplify the implementation of these new test widgets by removing some redundant null checks, which will improve code conciseness.

rizwan-saleem · 2026-02-02T16:03:48Z

@justinmc can you please review the changes in the PR to eliminate its dependency on Material widgets ?

justinmc

Thanks for jumping in and helping here! This wasn't a super easy one but I think you just about got it.

justinmc · 2026-02-03T19:39:47Z

-        showCursor: widget.showCursor,
-        style: widget.style ?? const TextStyle(), // required by editable text.
-        controller: _effectiveController, // required by editable text.
+    return Semantics(


Are you able to do this via EditableText which has a Semantics inside of it? @Renzo-Olivares I wonder what you think about this.

@Renzo-Olivares pointed out to me that EditableText actually does not have onTap in its Semantics:

flutter/packages/flutter/lib/src/widgets/editable_text.dart

Lines 5800 to 5805 in 018a571

child: Semantics(

inputType: inputType,

onCopy: _semanticsOnCopy(controls),

onCut: _semanticsOnCut(controls),

onPaste: _semanticsOnPaste(controls),

child: _ScribbleFocusable(

That is handled in TextField and in CupertinoTextField. We should probably move that semantics logic to EditableText, but after this PR. I'll create an issue.

In the meantime, I think we should move the test "SemanticsDebugger textfield" to material, and keep TestTextField as-is.

Issue: #181873

@rizwan-saleem When you move the test to Material, please add a TODO that references this issue.

justinmc · 2026-02-03T19:44:05Z

+/// This widget provides minimal slider functionality without depending on
+/// Material Design components. It only handles semantic actions for testing
+/// purposes and does not render any visual elements.
+class TestSlider extends StatelessWidget {


Can you add a TODO like this for each of these two new Test classes you wrote?

flutter/packages/flutter/test/widgets/widgets_app_tester.dart

Lines 34 to 35 in 9b30164

// TODO(rkishan516): Move this to flutter_test package.

// Tracking issue: https://github.com/flutter/flutter/issues/181283

Also, I think we should move these classes to their own files, like slider_tester.dart and checkbox_tester.dart. I should probably move TestButton in another PR too, sorry for the misleading example here.

CC @Renzo-Olivares for thoughts.

Sounds good to me!

Renzo-Olivares · 2026-02-03T20:34:26Z

      2000.0,
      warnIfMissed: false,
    ); // hitting the debugger
-    switch (defaultTargetPlatform) {


This test looks like it's testing some specific platform logic based on this switch. I wonder if we should duplicate it in Material.

Good catch, yes I would copy the original test to Material and keep the version you have now here.

Renzo-Olivares · 2026-02-03T20:38:38Z

      Directionality(
        textDirection: TextDirection.ltr,
        child: SemanticsDebugger(
-          child: Material(


I think this test might also be a good candidate to duplicate or outright move to Material since it seems to be specifically testing Checkbox and not just the general functionality.

Unlike SemanticsDebugger interaction test earlier in this file which uses the buttons as a means to add logs to a list, this is testing the Checkbox functionality.

Renzo-Olivares · 2026-02-03T20:42:56Z

        textDirection: TextDirection.ltr,
        child: SemanticsDebugger(
          key: debugger,
-          child: Material(


Similar to my comment https://github.com/flutter/flutter/pull/181722/changes#r2760892419

rizwan-saleem · 2026-02-04T11:15:13Z

Thank you @justinmc @Renzo-Olivares for all the valuable comments on the PR. It really helped to understand how things need to be done for other cross import files too.

I will tag you guys again once I have made the changes. 🙏

…" (#182406)  Reverts: #182395   Initiated by: gaaclarke   Reason for reverting: this is causing breakages on the dashboard example: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8689933991528003217/+/u/run_test.dart_for_framework_tests_shard_and_subshard_libraries/stdout ``` 10:36 +9458 ~24: /b/s/w/ir/x/w/flutter/packages/flutter/test/material/dialog_test.dart: Dialog children padding is correct AlertDialog padding is correct when only icon, title a   Original PR Author: justinmc   Reviewed By: {Renzo-Olivares, victorsanni, navaronbracke}   This change reverts the following previous change: This PR moves: * TestTextField from editable_text_utils.dart to editable_text_tester.dart * TestListTile from list_tile_test_utils.dart to list_tile_tester.dart * TestButton from utils.dart to button_tester.dart The purpose is to align with other Test* widgets, such as TestWidgetsApp in [widgets_app_tester.dart](https://github.com/flutter/flutter/blob/master/packages/flutter/test/widgets/widgets_app_tester.dart) and TestSemantics in [semantics_tester.dart](https://github.com/flutter/flutter/blob/master/packages/flutter/test/widgets/semantics_tester.dart). We should continue to follow this pattern in the future, such as in #181722.  Co-authored-by: auto-submit[bot] <[email protected]>

…ve them from utils.dart

…#182395)" (flutter#182406)  Reverts: flutter#182395   Initiated by: gaaclarke   Reason for reverting: this is causing breakages on the dashboard example: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8689933991528003217/+/u/run_test.dart_for_framework_tests_shard_and_subshard_libraries/stdout ``` 10:36 +9458 ~24: /b/s/w/ir/x/w/flutter/packages/flutter/test/material/dialog_test.dart: Dialog children padding is correct AlertDialog padding is correct when only icon, title a   Original PR Author: justinmc   Reviewed By: {Renzo-Olivares, victorsanni, navaronbracke}   This change reverts the following previous change: This PR moves: * TestTextField from editable_text_utils.dart to editable_text_tester.dart * TestListTile from list_tile_test_utils.dart to list_tile_tester.dart * TestButton from utils.dart to button_tester.dart The purpose is to align with other Test* widgets, such as TestWidgetsApp in [widgets_app_tester.dart](https://github.com/flutter/flutter/blob/master/packages/flutter/test/widgets/widgets_app_tester.dart) and TestSemantics in [semantics_tester.dart](https://github.com/flutter/flutter/blob/master/packages/flutter/test/widgets/semantics_tester.dart). We should continue to follow this pattern in the future, such as in flutter#181722.  Co-authored-by: auto-submit[bot] <[email protected]>

Renzo-Olivares · 2026-02-25T22:51:59Z

Hi @rizwan-saleem, just checking in on how it's going with this pull request. Let me know if you have any questions, happy to help!

justinmc · 2026-02-19T18:25:32Z

+// TODO(rizwan-saleem): Move this to material package.
+// Tracking issue: https://github.com/flutter/flutter/issues/177414


Was this added by mistake or am I misunderstanding? Seems like this file is in the right spot.

justinmc · 2026-02-25T23:26:45Z

I think maybe you misread my comment (#181722 (comment)). I meant that you should move this test into test/material/semantics_debugger_test.dart, and then add a comment with a TODO linking to #181873.

I think this test is fundamentally testing logic that is currently inside of TextField in the Material library, so the test should go in the Material library tool.

justinmc · 2026-03-10T22:18:01Z

@rizwan-saleem Are you still planning to return to this PR and get it ready to merge?

rizwan-saleem · 2026-03-15T00:38:49Z

@justinmc sorry for the delay, I am on it, finishing the work this weekend

# Conflicts: # dev/bots/check_tests_cross_imports.dart # packages/flutter/test/widgets/editable_text_utils.dart

The `SemanticsDebugger` tests for `Slider`, `Checkbox`, and `TextField` have been moved from the `widgets` package to the `material` package. This change ensures that tests for Material-specific implementations of these widgets are located alongside their respective package.

…#182395)" (flutter#182406)  Reverts: flutter#182395   Initiated by: gaaclarke   Reason for reverting: this is causing breakages on the dashboard example: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8689933991528003217/+/u/run_test.dart_for_framework_tests_shard_and_subshard_libraries/stdout ``` 10:36 +9458 ~24: /b/s/w/ir/x/w/flutter/packages/flutter/test/material/dialog_test.dart: Dialog children padding is correct AlertDialog padding is correct when only icon, title a   Original PR Author: justinmc   Reviewed By: {Renzo-Olivares, victorsanni, navaronbracke}   This change reverts the following previous change: This PR moves: * TestTextField from editable_text_utils.dart to editable_text_tester.dart * TestListTile from list_tile_test_utils.dart to list_tile_tester.dart * TestButton from utils.dart to button_tester.dart The purpose is to align with other Test* widgets, such as TestWidgetsApp in [widgets_app_tester.dart](https://github.com/flutter/flutter/blob/master/packages/flutter/test/widgets/widgets_app_tester.dart) and TestSemantics in [semantics_tester.dart](https://github.com/flutter/flutter/blob/master/packages/flutter/test/widgets/semantics_tester.dart). We should continue to follow this pattern in the future, such as in flutter#181722.  Co-authored-by: auto-submit[bot] <[email protected]>

dkwingsmt · 2026-04-08T18:13:03Z

Here's a reminder that there are still analyzer issues. (from triage)

# Conflicts: # dev/bots/check_tests_cross_imports.dart # packages/flutter/test/widgets/checkbox_tester.dart # packages/flutter/test/widgets/semantics_debugger_test.dart

rizwan-saleem · 2026-04-25T19:32:30Z

All comments addressed. Code freeze check is there
cc. @dkwingsmt

rizwan-saleem · 2026-04-25T21:57:13Z

Closing this PR, as semantics_debugger_test is handled in another PR.

github-actions Bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) labels Jan 30, 2026

gemini-code-assist Bot reviewed Jan 30, 2026

View reviewed changes

Comment thread packages/flutter/test/widgets/utils.dart Outdated

Comment thread packages/flutter/test/widgets/utils.dart Outdated

Comment thread packages/flutter/test/widgets/utils.dart Outdated

rizwan-saleem added 3 commits January 30, 2026 15:53

Remove semantics_debugger_test.dart from cross-import check exceptions

32591f5

Format semantics_debugger_test.dart class and utils.dart class

ce4ffaf

Refactor: Use ?.call for nullable callbacks

fb4f856

justinmc mentioned this pull request Feb 3, 2026

(Test cross-imports) Tests should go in the library that they're testing #177414

Open

57 tasks

justinmc requested review from Renzo-Olivares, justinmc and victorsanni and removed request for victorsanni February 3, 2026 19:36

justinmc reviewed Feb 3, 2026

View reviewed changes

Renzo-Olivares reviewed Feb 3, 2026

View reviewed changes

Piinks added this to Test cross-imports Review Queue Feb 10, 2026

github-project-automation Bot moved this to Todo in Test cross-imports Review Queue Feb 10, 2026

rizwan-saleem and others added 2 commits February 13, 2026 16:39

Merge branch 'master' into fix-material-import-semantics-debugger

7fabeb4

Fix: Add trailing comma

341555f

justinmc mentioned this pull request Feb 13, 2026

Standardize on Test* widgets in *_tester.dart files #182395

Merged

rizwan-saleem and others added 3 commits February 14, 2026 21:10

Merge branch 'master' into fix-material-import-semantics-debugger

9b557a3

Add basic checkbox and slider for widget tests

39a2d1b

Refactor: Move TestSlider and TestCheckbox to separate files and Remo…

6528ca9

…ve them from utils.dart

justinmc moved this from Todo to Done in Test cross-imports Review Queue Feb 19, 2026

justinmc moved this from Done to In Progress in Test cross-imports Review Queue Feb 19, 2026

justinmc reviewed Feb 25, 2026

View reviewed changes

Merge branch 'master' into fix-material-import-semantics-debugger

e9fad75

# Conflicts: # dev/bots/check_tests_cross_imports.dart # packages/flutter/test/widgets/editable_text_utils.dart

github-actions Bot removed the a: text input Entering text in a text field or keyboard related problems label Mar 15, 2026

github-actions Bot added the f: material design flutter/packages/flutter/material repository. label Mar 18, 2026

dkwingsmt added the CICD Run CI/CD label Mar 25, 2026

chunhtai added the waiting for response The Flutter team cannot make further progress on this issue until the original reporter responds label Apr 22, 2026

Merge branch 'master' into fix-material-import-semantics-debugger

431cd55

# Conflicts: # dev/bots/check_tests_cross_imports.dart # packages/flutter/test/widgets/checkbox_tester.dart # packages/flutter/test/widgets/semantics_debugger_test.dart

github-actions Bot removed CICD Run CI/CD waiting for response The Flutter team cannot make further progress on this issue until the original reporter responds labels Apr 25, 2026

rizwan-saleem closed this Apr 25, 2026

github-project-automation Bot moved this from In Progress to Done in Test cross-imports Review Queue Apr 25, 2026

rizwan-saleem deleted the fix-material-import-semantics-debugger branch April 25, 2026 21:57

	child: Semantics(
	inputType: inputType,
	onCopy: _semanticsOnCopy(controls),
	onCut: _semanticsOnCut(controls),
	onPaste: _semanticsOnPaste(controls),
	child: _ScribbleFocusable(

	// TODO(rkishan516): Move this to flutter_test package.
	// Tracking issue: https://github.com/flutter/flutter/issues/181283

		// TODO(rizwan-saleem): Move this to material package.
		// Tracking issue: https://github.com/flutter/flutter/issues/177414

Conversation

rizwan-saleem commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

New Test Widgets Created

TestSlider

TestCheckbox

Enhanced Existing Test Widget

TestTextField

Test Results

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rizwan-saleem commented Feb 2, 2026

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rizwan-saleem commented Feb 4, 2026

Uh oh!

Renzo-Olivares commented Feb 25, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

justinmc commented Mar 10, 2026

Uh oh!

rizwan-saleem commented Mar 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dkwingsmt commented Apr 8, 2026

Uh oh!

rizwan-saleem commented Apr 25, 2026

Uh oh!

rizwan-saleem commented Apr 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rizwan-saleem commented Jan 30, 2026 •

edited

Loading

`TestSlider`

`TestCheckbox`

`TestTextField`

rizwan-saleem commented Mar 15, 2026 •

edited

Loading