Remove material from ticker mode test by rkishan516 · Pull Request #181696 · flutter/flutter

rkishan516 · 2026-01-30T03:16:00Z

This PR removes Material imports from ticker_mode_test.dart.

part of: #177415
depends on: #181695

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

gemini-code-assist

Code Review

This pull request removes the dependency on the Material package from ticker_mode_test.dart by enhancing the TestWidgetsApp test helper to support routing. The changes introduce routes and transitionsBuilder properties to TestWidgetsApp, making it a more capable replacement for MaterialApp in tests. The new functionality is well-documented and thoroughly tested in widgets_app_tester_test.dart. The code is clean, correct, and effectively achieves the goal of reducing package dependencies within the test suite. I have no specific comments for improvement.

gemini-code-assist

Code Review

This pull request refactors ticker_mode_test.dart to remove its dependency on the Material library. This is achieved by replacing MaterialApp with TestWidgetsApp and updating the imports accordingly. The change is also reflected in check_tests_cross_imports.dart by removing the test from the allow-list. The changes are correct and align with the goal of cleaning up test dependencies. I have one minor suggestion regarding import formatting to align with the Flutter style guide.

gemini-code-assist · 2026-02-17T01:56:07Z

 import 'package:flutter/foundation.dart';
-import 'package:flutter/material.dart';
 import 'package:flutter/scheduler.dart';
+import 'package:flutter/widgets.dart';
 import 'package:flutter_test/flutter_test.dart';


According to the Flutter style guide, imports should be grouped by type (dart:, package:flutter/, other package:, and relative imports), with blank lines between groups. Running dart format would add a blank line after the package:flutter/* imports to separate them from other package imports.

Suggested change

import 'package:flutter/foundation.dart';

import 'package:flutter/material.dart';

import 'package:flutter/scheduler.dart';

import 'package:flutter/widgets.dart';

import 'package:flutter_test/flutter_test.dart';

import 'package:flutter/foundation.dart';

import 'package:flutter/scheduler.dart';

import 'package:flutter/widgets.dart';

import 'package:flutter_test/flutter_test.dart';

References

All Dart code should be formatted using dart format, which groups and sorts imports. A blank line should separate package:flutter/ imports from other package: imports. ^(link)

This PR removes Material imports from ticker_mode_test.dart. part of: flutter#177415 depends on: flutter#181695 - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.

…11088) Manual roll Flutter from c023e5b2474f to 91b2d41a66d1 (31 revisions) Manual roll requested by [email protected] flutter/flutter@c023e5b...91b2d41 2026-02-19 [email protected] Reland #179643, only scroll hit-testable primary scroll views on status bar tap (flutter/flutter#182391) 2026-02-19 [email protected] Replace References to `flutter/engine` with `flutter/flutter` (flutter/flutter#182600) 2026-02-19 [email protected] Remove specific iOS extended attributes to fix code signing (flutter/flutter#180710) 2026-02-19 [email protected] Manual roll Skia from 7bbdc51ab0aa to ce5854495a3a (flutter/flutter#182637) 2026-02-19 [email protected] [pv]add integration test for original untappable web view link behind context menu bug (flutter/flutter#182111) 2026-02-19 [email protected] Roll pub packages (flutter/flutter#182579) 2026-02-19 [email protected] Remove Material import from scroll_view_test.dart (flutter/flutter#181281) 2026-02-19 [email protected] Add RawTooltip.ignorePointer (flutter/flutter#182527) 2026-02-19 [email protected] [web] Stop double loading fonts for WebParagraph (flutter/flutter#182026) 2026-02-19 [email protected] Migrate abi build paths to use new abi filtering api #AGP9 (flutter/flutter#181828) 2026-02-19 [email protected] [web] Flutter errors should be reported with console.error() (flutter/flutter#178886) 2026-02-19 [email protected] Manual roll Skia from dfe78d132e24 to 7bbdc51ab0aa (8 revisions) (flutter/flutter#182612) 2026-02-19 [email protected] Refactor autofill_group_test.dart to remove Material dependencies (flutter/flutter#181903) 2026-02-19 [email protected] Roll Packages from 59f905c to 9da22bf (8 revisions) (flutter/flutter#182611) 2026-02-19 [email protected] Roll Fuchsia Linux SDK from Ihau0pUz3u5ajw42u... to KfPgw04T0OEADLJA5... (flutter/flutter#182607) 2026-02-19 [email protected] Marks Mac_arm64_mokey entrypoint_dart_registrant unflaky (flutter/flutter#181648) 2026-02-19 [email protected] Remove material from Modal barrier tests (flutter/flutter#181708) 2026-02-19 [email protected] Remove material from ticker mode test (flutter/flutter#181696) 2026-02-19 [email protected] Remove material imports from Inherited Model, Magnifier, SafeArea, UndoHistory, Navigator and Layers test (flutter/flutter#181709) 2026-02-19 [email protected] docs: fix grammar in animation library documentation (flutter/flutter#182461) 2026-02-19 [email protected] Handle#6537 first grouped tests (flutter/flutter#182077) 2026-02-19 [email protected] Move SelectionArea web test from widgets to material folder (flutter/flutter#181951) 2026-02-19 [email protected] Roll Dart SDK from 44895e617182 to 2642761fca94 (6 revisions) (flutter/flutter#182572) 2026-02-19 [email protected] Update create template to always generate both SwiftPM and CocoaPods support for iOS/macOS plugins (flutter/flutter#181251) 2026-02-18 [email protected] Fix(Material): DateRangePicker ignores DatePickerTheme.dayShape (flutter/flutter#181658) 2026-02-18 [email protected] Fixing ExpansionTile expandedAlignment not Accepts AlignmentGeometry … (flutter/flutter#180814) 2026-02-18 [email protected] Give guided error message when CocoaPod and SwiftPM dependency conflicts (flutter/flutter#182392) 2026-02-18 [email protected] Remove material from interactive_viewer_test.dart (flutter/flutter#181465) 2026-02-18 [email protected] Bring Windows misc coverage out of bringup (flutter/flutter#182332) 2026-02-18 [email protected] Update android symbolication instructions (flutter/flutter#181267) 2026-02-18 [email protected] Unmark stable vulkan platform view tests as bringup (flutter/flutter#182554) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: ...

This PR removes Material imports from ticker_mode_test.dart. part of: flutter#177415 depends on: flutter#181695 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.

…lutter#11088) Manual roll Flutter from c023e5b2474f to 91b2d41a66d1 (31 revisions) Manual roll requested by [email protected] flutter/flutter@c023e5b...91b2d41 2026-02-19 [email protected] Reland #179643, only scroll hit-testable primary scroll views on status bar tap (flutter/flutter#182391) 2026-02-19 [email protected] Replace References to `flutter/engine` with `flutter/flutter` (flutter/flutter#182600) 2026-02-19 [email protected] Remove specific iOS extended attributes to fix code signing (flutter/flutter#180710) 2026-02-19 [email protected] Manual roll Skia from 7bbdc51ab0aa to ce5854495a3a (flutter/flutter#182637) 2026-02-19 [email protected] [pv]add integration test for original untappable web view link behind context menu bug (flutter/flutter#182111) 2026-02-19 [email protected] Roll pub packages (flutter/flutter#182579) 2026-02-19 [email protected] Remove Material import from scroll_view_test.dart (flutter/flutter#181281) 2026-02-19 [email protected] Add RawTooltip.ignorePointer (flutter/flutter#182527) 2026-02-19 [email protected] [web] Stop double loading fonts for WebParagraph (flutter/flutter#182026) 2026-02-19 [email protected] Migrate abi build paths to use new abi filtering api #AGP9 (flutter/flutter#181828) 2026-02-19 [email protected] [web] Flutter errors should be reported with console.error() (flutter/flutter#178886) 2026-02-19 [email protected] Manual roll Skia from dfe78d132e24 to 7bbdc51ab0aa (8 revisions) (flutter/flutter#182612) 2026-02-19 [email protected] Refactor autofill_group_test.dart to remove Material dependencies (flutter/flutter#181903) 2026-02-19 [email protected] Roll Packages from 59f905c to 9da22bf (8 revisions) (flutter/flutter#182611) 2026-02-19 [email protected] Roll Fuchsia Linux SDK from Ihau0pUz3u5ajw42u... to KfPgw04T0OEADLJA5... (flutter/flutter#182607) 2026-02-19 [email protected] Marks Mac_arm64_mokey entrypoint_dart_registrant unflaky (flutter/flutter#181648) 2026-02-19 [email protected] Remove material from Modal barrier tests (flutter/flutter#181708) 2026-02-19 [email protected] Remove material from ticker mode test (flutter/flutter#181696) 2026-02-19 [email protected] Remove material imports from Inherited Model, Magnifier, SafeArea, UndoHistory, Navigator and Layers test (flutter/flutter#181709) 2026-02-19 [email protected] docs: fix grammar in animation library documentation (flutter/flutter#182461) 2026-02-19 [email protected] Handle#6537 first grouped tests (flutter/flutter#182077) 2026-02-19 [email protected] Move SelectionArea web test from widgets to material folder (flutter/flutter#181951) 2026-02-19 [email protected] Roll Dart SDK from 44895e617182 to 2642761fca94 (6 revisions) (flutter/flutter#182572) 2026-02-19 [email protected] Update create template to always generate both SwiftPM and CocoaPods support for iOS/macOS plugins (flutter/flutter#181251) 2026-02-18 [email protected] Fix(Material): DateRangePicker ignores DatePickerTheme.dayShape (flutter/flutter#181658) 2026-02-18 [email protected] Fixing ExpansionTile expandedAlignment not Accepts AlignmentGeometry … (flutter/flutter#180814) 2026-02-18 [email protected] Give guided error message when CocoaPod and SwiftPM dependency conflicts (flutter/flutter#182392) 2026-02-18 [email protected] Remove material from interactive_viewer_test.dart (flutter/flutter#181465) 2026-02-18 [email protected] Bring Windows misc coverage out of bringup (flutter/flutter#182332) 2026-02-18 [email protected] Update android symbolication instructions (flutter/flutter#181267) 2026-02-18 [email protected] Unmark stable vulkan platform view tests as bringup (flutter/flutter#182554) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: ...

This PR removes Material imports from ticker_mode_test.dart. part of: flutter#177415 depends on: flutter#181695 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.

github-actions Bot added the framework flutter/packages/flutter repository. See also f: labels. label Jan 30, 2026

gemini-code-assist Bot reviewed Jan 30, 2026

View reviewed changes

rkishan516 force-pushed the ticker-mode-cross-imports branch 5 times, most recently from c9d4c33 to 5b738cb Compare January 31, 2026 03:20

justinmc requested review from justinmc and victorsanni February 3, 2026 23:28

victorsanni reviewed Feb 5, 2026

View reviewed changes

Comment thread packages/flutter/test/widgets/widgets_app_tester.dart

rkishan516 marked this pull request as draft February 5, 2026 02:06

Piinks added this to Test cross-imports Review Queue Feb 10, 2026

github-project-automation Bot moved this to Todo in Test cross-imports Review Queue Feb 10, 2026

rkishan516 added 3 commits February 17, 2026 07:11

refactor: update formatting

0440459

refactor: remove unintentional update to doc

0ed1ee4

refactor: replace material with widget tester

5edd7e7

rkishan516 force-pushed the ticker-mode-cross-imports branch from 5b738cb to 5edd7e7 Compare February 17, 2026 01:43

rkishan516 marked this pull request as ready for review February 17, 2026 01:54

gemini-code-assist Bot reviewed Feb 17, 2026

View reviewed changes

victorsanni approved these changes Feb 18, 2026

View reviewed changes

rkishan516 mentioned this pull request Feb 19, 2026

(Test cross-imports) Don't import Material in tests for convenience #177415

Open

rkishan516 added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 19, 2026

auto-submit Bot added this pull request to the merge queue Feb 19, 2026

Merged via the queue into flutter:master with commit 8a80222 Feb 19, 2026
150 checks passed

github-project-automation Bot moved this from Todo to Done in Test cross-imports Review Queue Feb 19, 2026

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 19, 2026

engine-flutter-autoroll mentioned this pull request Feb 19, 2026

Roll Flutter from c023e5b2474f to 06df71c51446 (17 revisions) flutter/packages#11069

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2026

8a80222e4 Remove material from ticker mode test (flutter/flutter#181696)

d532af6

engine-flutter-autoroll mentioned this pull request Feb 19, 2026

Roll Flutter from c023e5b2474f to d33442bedb88 (19 revisions) flutter/packages#11071

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2026

8a80222e4 Remove material from ticker mode test (flutter/flutter#181696)

5b1bcb6

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2026

8a80222e4 Remove material from ticker mode test (flutter/flutter#181696)

cdc2125

This was referenced Feb 19, 2026

Roll Flutter from c023e5b2474f to a8911cbac88e (20 revisions) flutter/packages#11072

Closed

Roll Flutter from c023e5b2474f to 9af4145b8ecb (21 revisions) flutter/packages#11073

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2026

8a80222e4 Remove material from ticker mode test (flutter/flutter#181696)

7052975

engine-flutter-autoroll mentioned this pull request Feb 19, 2026

Roll Flutter from c023e5b2474f to 935b8f70305b (22 revisions) flutter/packages#11074

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2026

8a80222e4 Remove material from ticker mode test (flutter/flutter#181696)

fd65356

rkishan516 deleted the ticker-mode-cross-imports branch February 20, 2026 03:08

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2026

8a80222e4 Remove material from ticker mode test (flutter/flutter#181696)

f541212

This was referenced Feb 20, 2026

Roll Flutter from c023e5b2474f to 91b2d41a66d1 (31 revisions) flutter/packages#11083

Closed

Roll Flutter from c023e5b2474f to 91b2d41a66d1 (31 revisions) flutter/packages#11086

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2026

8a80222e4 Remove material from ticker mode test (flutter/flutter#181696)

1609869

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2026

8a80222e4 Remove material from ticker mode test (flutter/flutter#181696)

d6e5081

engine-flutter-autoroll mentioned this pull request Feb 20, 2026

Manual roll Flutter from c023e5b2474f to 91b2d41a66d1 (31 revisions) flutter/packages#11087

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2026

8a80222e4 Remove material from ticker mode test (flutter/flutter#181696)

b85f258

engine-flutter-autoroll mentioned this pull request Feb 20, 2026

Manual roll Flutter from c023e5b2474f to 91b2d41a66d1 (31 revisions) flutter/packages#11088

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove material from ticker mode test#181696

Remove material from ticker mode test#181696
auto-submit[bot] merged 3 commits into
flutter:masterfrom
rkishan516:ticker-mode-cross-imports

rkishan516 commented Jan 30, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Feb 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

rkishan516 commented Jan 30, 2026

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants