Repository navigation
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Code Review
This pull request enforces Swift 6 strict concurrency by adding the -strict-concurrency=complete flag to the Swift compiler. The change is applied in both the GN build configuration and the swiftc.py build script. While this correctly enables the desired feature, it introduces redundancy. My review includes a suggestion to remove this duplication for better maintainability.
|
My first version of this actually worked, but we don't have warnings-as-errors on: |
|
|
Closing this, @LongCatIsLooong is going to take it over during the larger Swift 6 concurrency work. |
Enforce Swift 6 strict concurrency during swift compilation to catch thread checker and other main actor errors and regressions as we migrate the engine to Swift 6 #181684
See https://www.swift.org/documentation/concurrency.
This only enforces for our few Swift files, not Objective-C headers being called from Swift.