[Impeller] Fix off-by-one indices in the SimilarPointPair/SimilarPointTrio functions used by ShadowPathGeometryTest#181623
Merged
auto-submit[bot] merged 1 commit intoJan 29, 2026
Conversation
…tTrio functions used by ShadowPathGeometryTest
github-actions
Bot
added
engine
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly fixes an off-by-one indexing error in the SimilarPointPair and SimilarPointTrio test helper functions, which was causing out-of-bounds memory access. The logic is now sound. I've added a couple of suggestions to improve the conciseness and readability of these functions by combining multiple if statements into a single boolean expression, in line with the style guide's emphasis on readability.
Comment on lines
+53
to
58
| if (SimilarPoint(pair1[0], pair2[0]) && SimilarPoint(pair1[1], pair2[1])) { | ||
| return true; | ||
| } | ||
| if (SimilarPoint(pair1[1], pair2[2]) && SimilarPoint(pair1[2], pair2[1])) { | ||
| if (SimilarPoint(pair1[0], pair2[1]) && SimilarPoint(pair1[1], pair2[0])) { | ||
| return true; | ||
| } |
Contributor
There was a problem hiding this comment.
To improve readability and conciseness, this series of if statements can be combined into a single boolean expression using ||.
return (SimilarPoint(pair1[0], pair2[0]) && SimilarPoint(pair1[1], pair2[1])) ||
(SimilarPoint(pair1[0], pair2[1]) && SimilarPoint(pair1[1], pair2[0]));References
- Code should be optimized for readability, as it is read more often than it is written. Using a single return statement with a boolean expression can make the function's logic clearer and more direct. (link)
Comment on lines
+63
to
74
| if (SimilarPoint(trio1[0], trio2[0]) && | ||
| SimilarPointPair({trio1[1], trio1[2]}, {trio2[1], trio2[2]})) { | ||
| return true; | ||
| } | ||
| if (SimilarPoint(trio1[1], trio2[2]) && | ||
| SimilarPointPair({trio1[2], trio1[3]}, {trio2[1], trio2[3]})) { | ||
| if (SimilarPoint(trio1[0], trio2[1]) && | ||
| SimilarPointPair({trio1[1], trio1[2]}, {trio2[0], trio2[2]})) { | ||
| return true; | ||
| } | ||
| if (SimilarPoint(trio1[1], trio2[3]) && | ||
| SimilarPointPair({trio1[2], trio1[3]}, {trio2[1], trio2[2]})) { | ||
| if (SimilarPoint(trio1[0], trio2[2]) && | ||
| SimilarPointPair({trio1[1], trio1[2]}, {trio2[0], trio2[1]})) { | ||
| return true; | ||
| } |
Contributor
There was a problem hiding this comment.
This function can be made more concise by combining the if conditions into a single return statement with a boolean expression. This improves readability by presenting the logic more directly.
return (SimilarPoint(trio1[0], trio2[0]) &&
SimilarPointPair({trio1[1], trio1[2]}, {trio2[1], trio2[2]})) ||
(SimilarPoint(trio1[0], trio2[1]) &&
SimilarPointPair({trio1[1], trio1[2]}, {trio2[0], trio2[2]})) ||
(SimilarPoint(trio1[0], trio2[2]) &&
SimilarPointPair({trio1[1], trio1[2]}, {trio2[0], trio2[1]}));References
- Code should be optimized for readability, as it is read more often than it is written. Using a single return statement with a boolean expression can make the function's logic clearer and more direct. (link)
jason-simmons
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 30, 2026
…imilarPointTrio functions used by ShadowPathGeometryTest (flutter/flutter#181623)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 30, 2026
…imilarPointTrio functions used by ShadowPathGeometryTest (flutter/flutter#181623)
This was referenced Jan 30, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 30, 2026
…imilarPointTrio functions used by ShadowPathGeometryTest (flutter/flutter#181623)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 30, 2026
…imilarPointTrio functions used by ShadowPathGeometryTest (flutter/flutter#181623)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 30, 2026
…imilarPointTrio functions used by ShadowPathGeometryTest (flutter/flutter#181623)
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jan 30, 2026
Roll Flutter from da72d5936d69 to 1d9d6a9a5ef6 (33 revisions) flutter/flutter@da72d59...1d9d6a9 2026-01-30 [email protected] enable enhanced debugging for GLES playground (flutter/flutter#181157) 2026-01-30 [email protected] Make the Windows windowing_test in .ci.yaml have bringup as false (flutter/flutter#181664) 2026-01-30 [email protected] Roll Packages from cd4fd61 to 510dd40 (4 revisions) (flutter/flutter#181726) 2026-01-30 [email protected] Roll Skia from edbf7e9eb846 to 4745eb2fe837 (1 revision) (flutter/flutter#181725) 2026-01-30 [email protected] Enhance error handling of WidgetsBindingObserver callbacks (flutter/flutter#181174) 2026-01-30 [email protected] Roll Skia from 05d3cb9d2be9 to edbf7e9eb846 (2 revisions) (flutter/flutter#181715) 2026-01-30 [email protected] Roll Skia from c198e5fa9cd9 to 05d3cb9d2be9 (1 revision) (flutter/flutter#181712) 2026-01-30 [email protected] Roll Dart SDK from 920b7e24583e to 2703fd9733ce (2 revisions) (flutter/flutter#181693) 2026-01-30 [email protected] Roll Skia from b9f40c193e7a to c198e5fa9cd9 (6 revisions) (flutter/flutter#181692) 2026-01-30 [email protected] Roll pub packages (flutter/flutter#181690) 2026-01-30 [email protected] Extend the Windows tool_integration_tests_2_9 shard timeout to 1 hour (flutter/flutter#181678) 2026-01-29 [email protected] Add `android_sdk` dependency to `android_engine_opengles_tests` (flutter/flutter#181681) 2026-01-29 [email protected] Roll Dart SDK from a0685c8e946b to 920b7e24583e (3 revisions) (flutter/flutter#181680) 2026-01-29 [email protected] Roll Skia from 128b5213711e to b9f40c193e7a (14 revisions) (flutter/flutter#181675) 2026-01-29 [email protected] [Impeller] Ensure that HostBuffers/DeviceBuffers allocated by RendererTest tests are valid for the lifetime of the RenderPass (flutter/flutter#181635) 2026-01-29 [email protected] [Impeller] Fix off-by-one indices in the SimilarPointPair/SimilarPointTrio functions used by ShadowPathGeometryTest (flutter/flutter#181623) 2026-01-29 [email protected] 180162 fix radio list tile and switch list tile accept widget states controller (flutter/flutter#180367) 2026-01-29 [email protected] Remove unused test file (flutter/flutter#181671) 2026-01-29 [email protected] Roll libpng to version 1.6.54 (flutter/flutter#181625) 2026-01-29 [email protected] Remove nonstandard ndkpath for `hybrid_android_views` integration test (flutter/flutter#181666) 2026-01-29 [email protected] Add TestWidgetsApp utility and refactor widget tests to use WidgetsApp (flutter/flutter#180456) 2026-01-29 [email protected] Add `TestTextField` and migrate tests (flutter/flutter#180494) 2026-01-29 [email protected] Merge changelog for 3.38.9 (flutter/flutter#181668) 2026-01-29 [email protected] [flutter_tools] Deprecate `plugin_ffi` template (flutter/flutter#181588) 2026-01-29 [email protected] Deprecate onReorder callback (flutter/flutter#178242) 2026-01-29 [email protected] [web] Use defensive null check in text editing placeElement (flutter/flutter#180795) 2026-01-29 [email protected] Roll Packages from 1cb2148 to cd4fd61 (4 revisions) (flutter/flutter#181663) 2026-01-29 [email protected] Roll Skia from 89df65f8324c to 128b5213711e (2 revisions) (flutter/flutter#181651) 2026-01-29 [email protected] [hooks] Don't run build hooks for code assets in `flutter run` (flutter/flutter#181542) 2026-01-29 [email protected] Roll Dart SDK from f10dcbfca98f to a0685c8e946b (5 revisions) (flutter/flutter#181653) 2026-01-29 [email protected] Fixes getUniformX for Vulkan (flutter/flutter#181286) 2026-01-29 [email protected] Roll Fuchsia Linux SDK from adhoq9ouVRh0xzkm3... to isy1ARvK-3bsvtfc-... (flutter/flutter#181641) 2026-01-29 [email protected] Add isDark, isLight, and isSystem getters to ThemeMode (flutter/flutter#181475) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: ...
LongCatIsLooong
pushed a commit
to LongCatIsLooong/flutter
that referenced
this pull request
Feb 6, 2026
…tTrio functions used by ShadowPathGeometryTest (flutter#181623)
flutter-zl
pushed a commit
to flutter-zl/flutter
that referenced
this pull request
Feb 10, 2026
…tTrio functions used by ShadowPathGeometryTest (flutter#181623)
rickhohler
pushed a commit
to rickhohler/flutter
that referenced
this pull request
Feb 19, 2026
…tTrio functions used by ShadowPathGeometryTest (flutter#181623)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.