Fixes metal vec3 uniform padding by gaaclarke · Pull Request #181340 · flutter/flutter

gaaclarke · 2026-01-22T19:36:49Z

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

This reverts commit 686d632.

fluttergithubbot · 2026-01-22T21:27:21Z

An existing Git SHA, 89cef184de21c39d5957838e6bd79f50c248f416, was detected, and no actions were taken.

To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with --force) that already was pushed before, push a blank commit (git commit --allow-empty -m "Trigger Build") or rebase to continue.

gaaclarke · 2026-01-22T21:47:15Z

      entry_point_name);

  Reflector::Options reflector_options;
+  reflector_options.target_platform = GetParam();


This is just a residual change from when gemini was fiddling with the compiler tests. I kept it since it's a good change.

gemini-code-assist

Code Review

This pull request addresses an issue with vec3 uniform padding on the Metal backend. The core of the fix involves updating the shader reflector to correctly account for Metal's specific alignment rules for vec3 and mat3 types. Additionally, the code is refactored to use a more descriptively named padding_layout instead of struct_layout, and uniform emplacement is optimized to avoid creating an intermediate buffer. My review identifies a critical bug in the uniform size calculation that would lead to incorrect buffer allocations, and a minor code cleanup opportunity to remove unused variables.

gemini-code-assist · 2026-01-23T02:16:47Z

+      size_t floats_per_element = 0;
+      size_t padding_floats = 0;
+      if (spir_type.vecsize == 3 && spir_type.columns == 1) {
+        // float3
+        floats_per_element = 3;
+        padding_floats = 1;
+      } else if (spir_type.vecsize == 3 && spir_type.columns == 3) {
+        // float3x3
+        floats_per_element = 9;
+      }


The variables floats_per_element and padding_floats are declared and assigned values but are never used later in the function. They should be removed to improve code clarity and avoid confusion.

b-luk

I'm not very familiar with this code, so I just have a bunch of nits for you and don't have any higher level thoughts on the overall approach. Maybe walley892 can probably be helpful for that.

walley892

I'm not sure of the overall approach in the long term, but this looks good for now. Could of comments

walley892 · 2026-01-23T20:43:12Z

+  if (type == kStruct) {
+    size += sizeof(float) * padding_layout.size();
+  }


Can you document that GetSize has two different meanings?

myStruct::GetSize is the total physical size of the thing. I.e, what we send to the GPU including padding

myArrayUniform::GetSize is the logical size of the thing, not what we actually send over to the GPU.

Yea, I'm not a huge fan of this either. I'll spend some time trying to detangle this. Unfortunately the docstring is kind of ambiguous. This is what I'd expect the implementation to be:

size_t RuntimeUniformDescription::GetSize() const { size_t size = 0; if (padding_layout.empty()) { size = dimensions.rows * dimensions.cols * bit_width / 8u; } else { size = sizeof(float) * padding_layout.size(); } if (array_elements.value_or(0) > 0) { // Covered by check on the line above. // NOLINTNEXTLINE(bugprone-unchecked-optional-access) size *= array_elements.value(); } return size; }

If it works it works for now I guess

Ugh, this is bothering me. For the vec3array in the test the current GetSize returns 24 bytes, but the proposed one returns 32 bytes. This causes the test to fail. This is not working as intended and shouldn't be landed until this is addressed. My brain is spent for now. I'll look monday =(

Okay, got it sorted out. There is a difference between the size a uniform takes up in the float buffer from dart and the size it will take up on the GPU because there is no padding in the dart float buffer. I've gotten rid of the oddity and split the names apart. This should clear everything up. I'm not 100% happy with it but this gives the next person looking at the code an understanding of what is actually going on.

b-luk

lgtm as long as walley approves

QuncCccccc · 2026-01-26T22:56:05Z

Hi I'm the gardener this week:) and when I'm investigating the closed tree, I noticed there are some skia gold failures showing up. Could you help triage the images?

--EDIT:
Ah sorry the tree is green now but seems the gold website still shows un-triaged images😂.

gaaclarke · 2026-01-26T23:43:22Z

Here's a link to those golden failures: https://flutter-gold.skia.org/search?blame=001000027422&corpus=flutter

There are definitely some problematic images. They are all in vulkan though, this test should have affected metal only. I'll see if I can reproduce them locally.

gaaclarke · 2026-01-27T17:20:23Z

Reason for revert: golden failures and known logical errors that didn't have test coverage

This reverts commit aea4435.

Reverts: #181340   Initiated by: gaaclarke   Reason for reverting: golden failures and known logical errors that didn't have test coverage   Original PR Author: gaaclarke   Reviewed By: {walley892, b-luk}   This change reverts the following previous change: fixes #180873 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md  Co-authored-by: auto-submit[bot] <[email protected]>

gaaclarke · 2026-01-27T18:38:27Z

@QuncCccccc I reverted this change and marked those goldens as negative

QuncCccccc · 2026-01-27T19:24:14Z

@QuncCccccc I reverted this change and marked those goldens as negative

Thanks!

flutter/flutter@7165649...dfd92b7 2026-01-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fixes metal vec3 uniform padding (#181340)" (flutter/flutter#181552) 2026-01-27 [email protected] Change update_engine_version documenation (flutter/flutter#181508) 2026-01-27 [email protected] Roll Packages from e712bfa to e37af11 (7 revisions) (flutter/flutter#181544) 2026-01-27 [email protected] Roll FreeType to 2.14.1 (flutter/flutter#181428) 2026-01-27 [email protected] Roll Skia from 566d202962d3 to c2754838b077 (3 revisions) (flutter/flutter#181536) 2026-01-27 [email protected] [Material] modernize time picker components with Dart 3 switch expressions (flutter/flutter#181356) 2026-01-27 [email protected] Roll Skia from 55a87b50a368 to 566d202962d3 (1 revision) (flutter/flutter#181528) 2026-01-27 [email protected] Roll Dart SDK from f55d4538469a to 4c7cb0a1d07d (2 revisions) (flutter/flutter#181526) 2026-01-27 [email protected] Replace `pub run` mentions with `dart run` (flutter/flutter#181317) 2026-01-27 [email protected] Roll Skia from 1a15ed6b17f2 to 55a87b50a368 (1 revision) (flutter/flutter#181523) 2026-01-27 [email protected] Marks linux_chrome_dev_mode to be unflaky (flutter/flutter#181352) 2026-01-27 [email protected] Roll Skia from f2c1aa140b79 to 1a15ed6b17f2 (2 revisions) (flutter/flutter#181514) 2026-01-27 [email protected] Fix Range Slider issue where indescrete ranges lead to out of range r… (flutter/flutter#181082) 2026-01-26 [email protected] Roll Dart SDK from ba23b5ed0a97 to f55d4538469a (2 revisions) (flutter/flutter#181512) 2026-01-26 [email protected] Add `alignment` to `SizeTransition` (flutter/flutter#177895) 2026-01-26 [email protected] Roll Fuchsia Linux SDK from T4qTEa3T5CCSCIoJY... to akraNGn2lw4T1msgZ... (flutter/flutter#181509) 2026-01-26 [email protected] Roll Skia from be280d242a60 to f2c1aa140b79 (3 revisions) (flutter/flutter#181504) 2026-01-26 [email protected] Fixes metal vec3 uniform padding (flutter/flutter#181340) 2026-01-26 [email protected] Fixes duplicated import in accessibility test library (flutter/flutter#181506) 2026-01-26 [email protected] [Reland] Don't strip symbols from `libapp.so` on android by default (flutter/flutter#181275) 2026-01-26 [email protected] Fix Gradle path in Android Platform Embedder README. (flutter/flutter#181501) 2026-01-26 [email protected] Remove unused `ActivityLifecycleListener` class (flutter/flutter#181406) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Re-landing of #181340 incorporating #181550. Vec3 uniforms on the metal backend are vec4-aligned. This PR accounts for that padding. --------- Co-authored-by: gaaclarke <[email protected]>

…181552)  Reverts: flutter#181340   Initiated by: gaaclarke   Reason for reverting: golden failures and known logical errors that didn't have test coverage   Original PR Author: gaaclarke   Reviewed By: {walley892, b-luk}   This change reverts the following previous change: fixes flutter#180873 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md  Co-authored-by: auto-submit[bot] <[email protected]>

Re-landing of flutter#181340 incorporating flutter#181550. Vec3 uniforms on the metal backend are vec4-aligned. This PR accounts for that padding. --------- Co-authored-by: gaaclarke <[email protected]>

Reland `Enabled some disabled impeller fragment shader dart tests` (flutter#180788) relands flutter#180759 changes since revert: 1) waits for async tests now 1) keeps 2 tests that don't pass on impeller disabled - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md Enables fragment shader test for impeller (fixes mat2 on vulkan) (flutter#181013) This rearranges the packing of mat2 fields in structs which was causing an existing fragment shader test to fail. The test still doesn't work on Metal, but this PR fixes it for Vulkan. I suspect the fix for metal may be similar but since the uniforms aren't in a virtual struct the code isn't hitting this fix. issue: flutter#180873 - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md Account for vec3 padding in Metal (flutter#181563) Re-landing of flutter#181340 incorporating flutter#181550. Vec3 uniforms on the metal backend are vec4-aligned. This PR accounts for that padding. --------- Co-authored-by: gaaclarke <[email protected]> Fixes getUniformX for Vulkan (flutter#181286) Does what it says on the tin! This PR adds struct member information to the runtime flatbuffer format. This allows dart code to introspect structs at runtime. Also modifies the runtime_stage tests to verify formats for all supported uniform types. Bubbles up struct member information to dart, and uses that information to grab struct members in `getUniformX` related functions. This is necessary on Vulkan because all uniforms are packaged into a single struct. Also re-enables tests - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. Organize and update fragment shader uniform tests. (flutter#181822) Adds more comprehensive testing for setFloat and getUniform* on fragment shaders. Deletes redundant tests. Fixes getUniformVecX indexing errors. Update web ui fragment shader tests (flutter#181877) Adds a bunch of tests for uniform setting functionality for custom fragment shaders on the web. Deletes redundant tests. Fixes a discovered issue in the uniform offset calculation. We were previously using the `location`, which is the integer offset of the uniform, not the offset in floats.

gaaclarke added 5 commits January 22, 2026 10:38

Reenabled metal uniform array test by fixing metal padding

afd5386

disabled compiler tests again, will follow up

6f31d9c

renamed EmplaceVulkanUniform

1a223c3

trimmed generated comments

32678fd

renamed struct_layout to padding_layout to better match what it used for

da9c5c7

github-actions Bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Jan 22, 2026

gaaclarke added 2 commits January 22, 2026 11:40

revert compiler test

686d632

Revert "revert compiler test"

89cef18

This reverts commit 686d632.

gaaclarke force-pushed the metal-vec3-padding branch from 2baef3b to 89cef18 Compare January 22, 2026 21:27

revert some mat2 changes

bc33acc

gaaclarke force-pushed the metal-vec3-padding branch from 9524871 to bc33acc Compare January 22, 2026 21:34

gaaclarke commented Jan 22, 2026

View reviewed changes

gaaclarke added 2 commits January 22, 2026 16:34

rolled up array padding layout

b277883

renamed flatbuffer field

4ad9fc9

gaaclarke marked this pull request as ready for review January 23, 2026 02:13

gaaclarke requested review from b-luk and walley892 January 23, 2026 02:13

gemini-code-assist Bot reviewed Jan 23, 2026

View reviewed changes

removed dead code

98c1785

b-luk reviewed Jan 23, 2026

View reviewed changes

bluk feedback

0c8de5d

gaaclarke requested a review from b-luk January 23, 2026 19:52

walley892 reviewed Jan 23, 2026

View reviewed changes

Comment thread engine/src/flutter/impeller/compiler/reflector.cc

walley892 reviewed Jan 23, 2026

View reviewed changes

b-luk mentioned this pull request Jan 23, 2026

Re-enable fragment_shader_tests.dart 'Shader Compiler appropriately pads vec3 uniform arrays' test #180932

Closed

gaaclarke added 2 commits January 23, 2026 14:58

wally feedback

f20fbb5

bluk2

22c3665

b-luk approved these changes Jan 24, 2026

View reviewed changes

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 27, 2026

aea4435c0 Fixes metal vec3 uniform padding (flutter/flutter#181340)

8b59b2c

engine-flutter-autoroll mentioned this pull request Jan 27, 2026

Roll Flutter from 716564969037 to bece46a36128 (18 revisions) flutter/packages#10909

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 27, 2026

aea4435c0 Fixes metal vec3 uniform padding (flutter/flutter#181340)

da6c57f

engine-flutter-autoroll mentioned this pull request Jan 27, 2026

Roll Flutter from 716564969037 to 4d0b927b0213 (19 revisions) flutter/packages#10910

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 27, 2026

aea4435c0 Fixes metal vec3 uniform padding (flutter/flutter#181340)

439af24

engine-flutter-autoroll mentioned this pull request Jan 27, 2026

Roll Flutter from 716564969037 to 4bff775cc724 (20 revisions) flutter/packages#10911

Closed

walley892 mentioned this pull request Jan 27, 2026

Updates GetDartSize to return the number of non-padding bytes #181550

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 27, 2026

aea4435c0 Fixes metal vec3 uniform padding (flutter/flutter#181340)

cf17f09

engine-flutter-autoroll mentioned this pull request Jan 27, 2026

Roll Flutter from 716564969037 to d7d35fdd9f06 (21 revisions) flutter/packages#10912

Closed

gaaclarke added the revert Autorevert PR (with "Reason for revert:" comment) label Jan 27, 2026

auto-submit Bot pushed a commit that referenced this pull request Jan 27, 2026

Revert "Fixes metal vec3 uniform padding (#181340)"

ca06231

This reverts commit aea4435.

auto-submit Bot mentioned this pull request Jan 27, 2026

Reverts "Fixes metal vec3 uniform padding (#181340)" #181552

Merged

9 tasks

auto-submit Bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Jan 27, 2026

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 27, 2026

aea4435c0 Fixes metal vec3 uniform padding (flutter/flutter#181340)

dca6cb4

engine-flutter-autoroll mentioned this pull request Jan 27, 2026

Roll Flutter from 716564969037 to dfd92b773219 (22 revisions) flutter/packages#10914

Merged

walley892 mentioned this pull request Jan 27, 2026

Account for vec3 padding in Metal #181563

Merged

Conversation

gaaclarke commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

fluttergithubbot commented Jan 22, 2026

Uh oh!

gaaclarke Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

b-luk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

walley892 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

walley892 Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

gaaclarke Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

walley892 Jan 24, 2026

Choose a reason for hiding this comment

Uh oh!

gaaclarke Jan 24, 2026

Choose a reason for hiding this comment

Uh oh!

gaaclarke Jan 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

b-luk left a comment

Choose a reason for hiding this comment

Uh oh!

QuncCccccc commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gaaclarke commented Jan 26, 2026

Uh oh!

gaaclarke commented Jan 27, 2026

Uh oh!

gaaclarke commented Jan 27, 2026

Uh oh!

QuncCccccc commented Jan 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gaaclarke commented Jan 22, 2026 •

edited

Loading

QuncCccccc commented Jan 26, 2026 •

edited

Loading