Re-enable fragment_shader_tests.dart 'Shader Compiler appropriately pads vec3 uniform arrays' test on Vulkan#181292
Merged
auto-submit[bot] merged 2 commits intoJan 23, 2026
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request re-enables a disabled test for Vulkan by correcting uniform indices and adds a skip for Metal. It also commendably fixes a latent endian-related bug in the _expectShaderRendersColor test helper, making pixel color verification more robust. The changes are well-explained, significantly improving test correctness and coverage. I have one suggestion to make the test helper code more idiomatic.
Comment on lines
850
to
+856
| test(name, () async { | ||
| if (!impellerEnabled) { | ||
| print('skipped for Skia'); | ||
| return; | ||
| } | ||
| await callback(); | ||
| }); | ||
| }, skip: skip); |
Contributor
There was a problem hiding this comment.
The test function from package:test provides a skip parameter that can be used to conditionally skip tests. Using it would make the intent clearer and is more idiomatic. You can combine the existing !impellerEnabled check with the new skip parameter to simplify this helper function.
test(
name,
callback,
skip: !impellerEnabled ? 'skipped for Skia' : skip,
);
auto-submit
Bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/flutter/181292, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
flutter-dashboard
Bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 23, 2026
…priately pads vec3 uniform arrays' test on Vulkan (flutter/flutter#181292)
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jan 23, 2026
Roll Flutter from 48c2475 to bfc9041eb118 (173 revisions) flutter/flutter@48c2475...bfc9041 2026-01-23 [email protected] No longer exiting the application when the RegularWindow is destroyed + resolving the window created promise after runWidget (flutter/flutter#181339) 2026-01-23 [email protected] Remove unnecessary Material import from dialog_test.dart (flutter/flutter#181249) 2026-01-23 [email protected] Roll Skia from 8e516fe6828f to db10db8bd55f (1 revision) (flutter/flutter#181379) 2026-01-23 [email protected] Reset TextFormField to initial value after state change (flutter/flutter#181199) 2026-01-23 [email protected] Roll Dart SDK from 980b2b41d36e to e82d7ad1855e (1 revision) (flutter/flutter#181375) 2026-01-23 [email protected] Roll Skia from 3e86f377d300 to 8e516fe6828f (4 revisions) (flutter/flutter#181370) 2026-01-23 [email protected] Remove unnecessary Material import from sliver_visibility_test (flutter/flutter#181248) 2026-01-23 [email protected] Add bottom navigation bar item semantics label (flutter/flutter#180577) 2026-01-23 [email protected] Make topGap not required for CupertinoSheetTransition (flutter/flutter#181269) 2026-01-23 [email protected] Roll Fuchsia Linux SDK from b4cLyhuxciUC-4zCJ... to n7NohL9DPpEuPjNt9... (flutter/flutter#181365) 2026-01-23 [email protected] Roll Dart SDK from 806f04638561 to 980b2b41d36e (1 revision) (flutter/flutter#181364) 2026-01-23 [email protected] Reland hybrid views test (flutter/flutter#181336) 2026-01-23 [email protected] Revert DropdownMenu non-nullable breaking change (flutter/flutter#181074) 2026-01-23 [email protected] Fix leaks in `flutter_test` tests (flutter/flutter#180879) 2026-01-23 [email protected] Re-enable fragment_shader_tests.dart 'Shader Compiler appropriately pads vec3 uniform arrays' test on Vulkan (flutter/flutter#181292) 2026-01-23 [email protected] [ Tool ] Fix `update-packages` failing due to mismatched dependencies between flutter_tools and the framework (flutter/flutter#181335) 2026-01-23 [email protected] [Impeller] Make dynamically created shader metadata for runtime effects consistent with metadata for built-in shaders (flutter/flutter#181201) 2026-01-23 [email protected] Broaden the applicability of `Color` fix_data rules from flutter/painting.dart (flutter/flutter#181093) 2026-01-23 [email protected] Fixes macOS App.framework not being codesigned or find framework (flutter/flutter#181348) 2026-01-22 [email protected] Roll Fuchsia GN SDK from NAEC5tfgSl8g94nwp... to JLBh4Z9PKsjIJcqDU... (flutter/flutter#181139) 2026-01-22 [email protected] Roll Dart SDK from ab4640ea82e9 to 806f04638561 (2 revisions) (flutter/flutter#181347) 2026-01-22 [email protected] Add ExpansibleController.toggle method. (flutter/flutter#181320) 2026-01-22 [email protected] Fixes Typo in codebase (flutter/flutter#181256) 2026-01-22 [email protected] Roll Skia from 4766615bcc96 to 3e86f377d300 (3 revisions) (flutter/flutter#181346) 2026-01-22 [email protected] Make sure that a Hero doesn't crash in 0x0 environment (flutter/flutter#180954) 2026-01-22 [email protected] Reland "Fix capitalization of the path to FlutterWindowControllerTest.mm in the macOS platform build script" (flutter/flutter#181200) 2026-01-22 [email protected] Roll Skia from 6e9746be8c4a to 4766615bcc96 (3 revisions) (flutter/flutter#181331) 2026-01-22 [email protected] Fix remove material import textfield (flutter/flutter#181254) 2026-01-22 [email protected] Add FlutterFramework as an Xcode SwiftPM local package override (flutter/flutter#179512) 2026-01-22 [email protected] Roll Dart SDK from 7bd4c68b625c to ab4640ea82e9 (1 revision) (flutter/flutter#181324) 2026-01-22 [email protected] Roll Packages from d80c60e to 9010299 (9 revisions) (flutter/flutter#181323) 2026-01-22 [email protected] Roll Dart SDK from 2d53a77adc5d to 7bd4c68b625c (2 revisions) (flutter/flutter#181316) 2026-01-22 [email protected] Roll Skia from 3f6949bc5780 to 6e9746be8c4a (2 revisions) (flutter/flutter#181311) 2026-01-22 [email protected] Roll Skia from ef6efc358b4a to 3f6949bc5780 (2 revisions) (flutter/flutter#181307) 2026-01-22 [email protected] Roll Dart SDK from 5d7c8faf2e41 to 2d53a77adc5d (1 revision) (flutter/flutter#181305) 2026-01-22 [email protected] [Material] update hourFormat to use Dart 3 switch expression (flutter/flutter#181041) 2026-01-22 [email protected] Use null-aware elements in cupertino/nav_bar.dart (flutter/flutter#181237) 2026-01-22 [email protected] Roll Fuchsia Linux SDK from b2KIEXVAlEqImQ9VO... to b4cLyhuxciUC-4zCJ... (flutter/flutter#181297) 2026-01-22 [email protected] Roll pub packages (flutter/flutter#181295) 2026-01-22 [email protected] Enables fragment shader test for impeller (fixes mat2 on vulkan) (flutter/flutter#181013) 2026-01-21 [email protected] Roll Dart SDK from 366200db1aa1 to 5d7c8faf2e41 (4 revisions) (flutter/flutter#181290) 2026-01-21 [email protected] Roll Skia from b5ec89e31f59 to ef6efc358b4a (19 revisions) (flutter/flutter#181289) 2026-01-21 [email protected] fix description for semantics finders (flutter/flutter#181214) 2026-01-21 [email protected] Make sure that an Icon doesn't crash in 0x0 environment (flutter/flutter#181021) 2026-01-21 [email protected] Make sure that a GridPaper doesn't crash in 0x0 environment (flutter/flutter#180906) 2026-01-21 [email protected] Bring Linux coverage out of bringup (flutter/flutter#181280) ...
flutter-zl
pushed a commit
to flutter-zl/flutter
that referenced
this pull request
Feb 10, 2026
…ads vec3 uniform arrays' test on Vulkan (flutter#181292) - The [shader](https://github.com/flutter/flutter/blob/3b206173454ec192938126322c58b5a1f090652f/engine/src/flutter/lib/ui/fixtures/shaders/general_shaders/vec3_uniform.frag) has `uniform vec3[4] color_array;` and sets `fragColor = vec4(color_array[3].xyz, 1);`. Update the test to use the correct indexes for `color_array[3]`: 9, 10, 11 instead of 12, 13, 14. - Skip the test for metal. Metal seems like it has some weird index padding issue. From testing it out: - `color_array[0].xyz` is set when setting indexes 0, 1, 2, as expected. - `color_array[1].xyz` should use indexes 3, 4, 5. But it seems to use indexes 4, 5, 6. Maybe there's some incorrect math making it skip index 3. - `color_array[2].xyz` should use indexes 6, 7, 8. But it seems to use indexes 8, 9, 10. Maybe there's some incorrect math making it skip indexes 3 and 7. - `color_array[3].xyz` should use indexes 9, 10, 11. But it seems to be impossible to set. Maybe it skips indexes 3, 7, and 11 and then tries to look at out-of-bounds indexes 12, 13, 14? - Fix incorrect logic in the `_expectShaderRendersColor()` method. - The 4 bytes for each pixel of an image are in the format `0xRRGGBBAA`. - This method used to use `renderedBytes.buffer.asUint32List()`. This reads 4 bytes to a Uint32, but uses `Endian.host` endianness. Maybe this differs on different platforms, but on my Mac this is little endian. So the image's `0xRRGGBBAA` bytes are read into a Uint32 as `0xAABBGGRR`. - This is then compared to the target `Color.value`, which is in ARGB32 format: `0xAARRGGBB`. - So it's comparing the each image's pixel as `0xAABBGGRR` to the target color as `0xAARRGGBB`. It switches the RR and BB channels for every comparison. - This did not result in any test failures because `_expectShaderRendersColor()` is only ever used as a helper function for `_expectShaderRendersGreen()` and `_expectShaderRendersBlack()`. And (un)luckily, those perfectly ignore the RR and BB channels. - Fix the logic by reading each pixel's bytes with separate `getUint8()` calls and parsing them into a `Color` with `fromARGB()`, using the correct byte offsets for each channel. Partially addresses flutter#180932. Re-enables the test for Vulkan, but it's still disabled for Metal. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uniform vec3[4] color_array;and setsfragColor = vec4(color_array[3].xyz, 1);. Update the test to use the correct indexes forcolor_array[3]: 9, 10, 11 instead of 12, 13, 14.color_array[0].xyzis set when setting indexes 0, 1, 2, as expected.color_array[1].xyzshould use indexes 3, 4, 5. But it seems to use indexes 4, 5, 6. Maybe there's some incorrect math making it skip index 3.color_array[2].xyzshould use indexes 6, 7, 8. But it seems to use indexes 8, 9, 10. Maybe there's some incorrect math making it skip indexes 3 and 7.color_array[3].xyzshould use indexes 9, 10, 11. But it seems to be impossible to set. Maybe it skips indexes 3, 7, and 11 and then tries to look at out-of-bounds indexes 12, 13, 14?_expectShaderRendersColor()method.0xRRGGBBAA.renderedBytes.buffer.asUint32List(). This reads 4 bytes to a Uint32, but usesEndian.hostendianness. Maybe this differs on different platforms, but on my Mac this is little endian. So the image's0xRRGGBBAAbytes are read into a Uint32 as0xAABBGGRR.Color.value, which is in ARGB32 format:0xAARRGGBB.0xAABBGGRRto the target color as0xAARRGGBB. It switches the RR and BB channels for every comparison._expectShaderRendersColor()is only ever used as a helper function for_expectShaderRendersGreen()and_expectShaderRendersBlack(). And (un)luckily, those perfectly ignore the RR and BB channels.getUint8()calls and parsing them into aColorwithfromARGB(), using the correct byte offsets for each channel.Partially addresses #180932. Re-enables the test for Vulkan, but it's still disabled for Metal.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.