update GLFW to latest and use EGL context creation on linux#181259
Merged
Conversation
github-actions
Bot
added
engine
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates GLFW and enables EGL context creation on Linux. The change adds a preprocessor block to set a GLFW window hint for Linux. My review includes one suggestion to refactor the platform-specific code for macOS and Linux to avoid code duplication and improve maintainability.
Comment on lines
+82
to
+86
| #if FML_OS_LINUX | ||
| // Use EGL even on X11 then the client can select the GLES implementation | ||
| // by defining __EGL_VENDOR_LIBRARY_FILENAMES | ||
| ::glfwWindowHint(GLFW_CONTEXT_CREATION_API, GLFW_EGL_CONTEXT_API); | ||
| #endif |
Contributor
There was a problem hiding this comment.
This change introduces a duplicated call to ::glfwWindowHint(GLFW_CONTEXT_CREATION_API, GLFW_EGL_CONTEXT_API). The same call exists in the #if FML_OS_MACOSX block on line 80.
To improve maintainability and adhere to the 'Don't Repeat Yourself' (DRY) principle, it would be better to combine these. You could use a single preprocessor block for both platforms:
#if FML_OS_MACOSX
FML_CHECK(use_angle_) << "Must use Angle on macOS for OpenGL ES.";
#endif // FML_OS_MACOSX
#if FML_OS_MACOSX || FML_OS_LINUX
// On macOS, EGL is used for ANGLE.
// On Linux, EGL is used to allow the user to select the GLES implementation
// by defining __EGL_VENDOR_LIBRARY_FILENAMES.
::glfwWindowHint(GLFW_CONTEXT_CREATION_API, GLFW_EGL_CONTEXT_API);
#endifThis would require moving the glfwWindowHint call from the FML_OS_MACOSX block into this new combined block.
References
- The style guide advises to 'Avoid duplicating state' and 'Write what you need and no more'. This change introduces code duplication which can be avoided for better maintainability. (link)
Contributor
Author
There was a problem hiding this comment.
Happy to make this change if requested by a human reviewer, but this is just duplicating the preprocessor condition instead of duplicating the code.
planetmarshall
force-pushed
the
glfw-update
branch
from
f5722d4 to
ee8a313
Compare
gaaclarke
approved these changes
Jan 27, 2026
gaaclarke
left a comment
gaaclarke
left a comment
Member
There was a problem hiding this comment.
This looks good as long as CI is happy. I think the failures we saw are flakes (we have an ongoing flake we are trying to address). I kicked the bots for you.
jason-simmons
approved these changes
Jan 27, 2026
jason-simmons
force-pushed
the
glfw-update
branch
from
ee8a313 to
9d1cb5e
Compare
gaaclarke
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 31, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 31, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 1, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 1, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 1, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 2, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 2, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 2, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 2, 2026
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Feb 2, 2026
flutter/flutter@1d9d6a9...9eafba4 2026-02-01 [email protected] Roll Skia from a8ceddc2bca0 to 4ee9eb659ae0 (1 revision) (flutter/flutter#181773) 2026-02-01 [email protected] Roll Skia from a5a535bc21a3 to a8ceddc2bca0 (1 revision) (flutter/flutter#181772) 2026-02-01 [email protected] Roll Dart SDK from cde322c518b9 to 84abc8d58ec8 (1 revision) (flutter/flutter#181767) 2026-02-01 [email protected] Roll Dart SDK from c72b3f527a07 to cde322c518b9 (1 revision) (flutter/flutter#181763) 2026-01-31 [email protected] Roll Dart SDK from 43de79f08887 to c72b3f527a07 (1 revision) (flutter/flutter#181762) 2026-01-31 [email protected] Roll Fuchsia Linux SDK from 27OsrsrKcrr2pOaqY... to nI52U4LJMrBv8G1M9... (flutter/flutter#181760) 2026-01-31 [email protected] Roll Dart SDK from a0aac59705e5 to 43de79f08887 (1 revision) (flutter/flutter#181758) 2026-01-31 [email protected] Roll Skia from b704afbcd8e7 to a5a535bc21a3 (1 revision) (flutter/flutter#181757) 2026-01-31 [email protected] Roll Dart SDK from d6f77f9098e1 to a0aac59705e5 (1 revision) (flutter/flutter#181756) 2026-01-31 [email protected] Roll Skia from 6f9511ce11ba to b704afbcd8e7 (4 revisions) (flutter/flutter#181753) 2026-01-31 [email protected] Roll Dart SDK from 0cf997832948 to d6f77f9098e1 (2 revisions) (flutter/flutter#181749) 2026-01-31 [email protected] Roll Skia from 33c00c0f3b8b to 6f9511ce11ba (1 revision) (flutter/flutter#181744) 2026-01-31 [email protected] Roll Dart SDK from be3ffc51d407 to 0cf997832948 (1 revision) (flutter/flutter#181740) 2026-01-30 [email protected] Roll Skia from b62d43b59dd6 to 33c00c0f3b8b (1 revision) (flutter/flutter#181735) 2026-01-30 [email protected] [Impeller] Fix type conversion warnings seen on Windows when Impeller GL API wrappers log arguments with function types (flutter/flutter#181734) 2026-01-30 [email protected] Update New Android API Docs (flutter/flutter#180604) 2026-01-30 [email protected] Roll Fuchsia Linux SDK from isy1ARvK-3bsvtfc-... to 27OsrsrKcrr2pOaqY... (flutter/flutter#181733) 2026-01-30 [email protected] Fix P3-to-sRGB color conversion to operate in linear light (flutter/flutter#181720) 2026-01-30 [email protected] chore: deflake Linux_mokey flutter_engine_group_performance (flutter/flutter#181624) 2026-01-30 [email protected] Roll Dart SDK from 2703fd9733ce to be3ffc51d407 (1 revision) (flutter/flutter#181729) 2026-01-30 [email protected] Ensure content-sizing resize is run on UI thread (flutter/flutter#181686) 2026-01-30 [email protected] [ Tool ] Cleanup `ResidentCompiler` initialization logic (flutter/flutter#181421) 2026-01-30 [email protected] [native assets] Split debug info into `.dsym` files (flutter/flutter#181533) 2026-01-30 [email protected] Roll Skia from 4745eb2fe837 to b62d43b59dd6 (1 revision) (flutter/flutter#181727) 2026-01-30 [email protected] add ccache support for custom toolchain (flutter/flutter#180737) 2026-01-30 [email protected] update GLFW to latest and use EGL context creation on linux (flutter/flutter#181259) 2026-01-30 [email protected] add stacktrace support when requested for host builds (flutter/flutter#181264) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LongCatIsLooong
pushed a commit
to LongCatIsLooong/flutter
that referenced
this pull request
Feb 6, 2026
…181259) Updates the GLFW dependency to master and uses the EGL context creation API on Linux. This allows Linux users to select an OpenGL implementation when running the impeller playground tests by defining `__EGL_VENDOR_LIBRARY_FILENAMES`. For example, running ``` $ impeller_unittests --gtest_filter=Play/AiksTest.ToImageFromImage/OpenGLES ``` gives, in `description_gles.cc` , ``` gl_version_string_ // OpenGL ES 3.2 NVIDIA 590.48.01 ``` Then running ``` $ __EGL_VENDOR_LIBRARY_FILENAMES=/usr/share/glvnd/egl_vendor.d/50_mesa.json impeller_unittests --gtest_filter=Play/AiksTest.ToImageFromImage/OpenGLES ``` ``` gl_version_string_ // OpenGL ES 3.2 Mesa 25.3.3-arch1.3 ``` Fixes flutter#181258 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
flutter-zl
pushed a commit
to flutter-zl/flutter
that referenced
this pull request
Feb 10, 2026
…181259) Updates the GLFW dependency to master and uses the EGL context creation API on Linux. This allows Linux users to select an OpenGL implementation when running the impeller playground tests by defining `__EGL_VENDOR_LIBRARY_FILENAMES`. For example, running ``` $ impeller_unittests --gtest_filter=Play/AiksTest.ToImageFromImage/OpenGLES ``` gives, in `description_gles.cc` , ``` gl_version_string_ // OpenGL ES 3.2 NVIDIA 590.48.01 ``` Then running ``` $ __EGL_VENDOR_LIBRARY_FILENAMES=/usr/share/glvnd/egl_vendor.d/50_mesa.json impeller_unittests --gtest_filter=Play/AiksTest.ToImageFromImage/OpenGLES ``` ``` gl_version_string_ // OpenGL ES 3.2 Mesa 25.3.3-arch1.3 ``` Fixes flutter#181258 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
rickhohler
pushed a commit
to rickhohler/flutter
that referenced
this pull request
Feb 19, 2026
…181259) Updates the GLFW dependency to master and uses the EGL context creation API on Linux. This allows Linux users to select an OpenGL implementation when running the impeller playground tests by defining `__EGL_VENDOR_LIBRARY_FILENAMES`. For example, running ``` $ impeller_unittests --gtest_filter=Play/AiksTest.ToImageFromImage/OpenGLES ``` gives, in `description_gles.cc` , ``` gl_version_string_ // OpenGL ES 3.2 NVIDIA 590.48.01 ``` Then running ``` $ __EGL_VENDOR_LIBRARY_FILENAMES=/usr/share/glvnd/egl_vendor.d/50_mesa.json impeller_unittests --gtest_filter=Play/AiksTest.ToImageFromImage/OpenGLES ``` ``` gl_version_string_ // OpenGL ES 3.2 Mesa 25.3.3-arch1.3 ``` Fixes flutter#181258 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the GLFW dependency to master and uses the EGL context creation API on Linux. This allows Linux users to select an OpenGL implementation when running the impeller playground tests by defining
__EGL_VENDOR_LIBRARY_FILENAMES.For example, running
gives, in
description_gles.cc,Then running
Fixes #181258
Pre-launch Checklist
///).