Roll pub packages#180900
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Code Review
This pull request updates several pub package dependencies. While most are minor patch version bumps, the webview_flutter package in dev/integration_tests/widget_preview_scaffold/pubspec.yaml is being downgraded from 4.13.0 to 4.9.0. This is an unexpected change for a dependency roll using --force-upgrade and should be investigated to avoid potential regressions.
| web_socket: 1.0.1 | ||
| web_socket_channel: 3.0.3 | ||
| webview_flutter: 4.13.0 | ||
| webview_flutter: 4.9.0 |
There was a problem hiding this comment.
The webview_flutter package is being downgraded from 4.13.0 to 4.9.0. Since this PR was generated with --force-upgrade, a downgrade is unexpected and may indicate a dependency conflict that prevents using a newer version. This could re-introduce issues that were fixed between versions 4.9.0 and 4.13.0. Please verify that this downgrade is intentional and necessary.
Manual roll requested by [email protected] flutter/flutter@793b0b8...b45a73b 2026-01-13 [email protected] Roll pub packages (flutter/flutter#180900) 2026-01-13 [email protected] Roll Dart SDK from 34318de9874b to ebaf52c13799 (1 revision) (flutter/flutter#180870) 2026-01-13 [email protected] Make sure that an ErrorWidget doesn't crash in 0x0 environment (flutter/flutter#180830) 2026-01-13 [email protected] Make sure that a Banner doesn't crash in 0x0 environment (flutter/flutter#180254) 2026-01-13 [email protected] Adds metal background to engine dart tests (flutter/flutter#180700) 2026-01-13 [email protected] Add TabBar API example for scroll notification integration (flutter/flutter#180728) 2026-01-13 [email protected] Roll Skia from 714d0af2eda7 to 8f3134206e8d (1 revision) (flutter/flutter#180874) 2026-01-13 [email protected] Add build-time checks for ImpellerC's SkSL compiler (flutter/flutter#180861) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This PR was generated by `flutter update-packages --force-upgrade`.
) Manual roll requested by [email protected] flutter/flutter@793b0b8...b45a73b 2026-01-13 [email protected] Roll pub packages (flutter/flutter#180900) 2026-01-13 [email protected] Roll Dart SDK from 34318de9874b to ebaf52c13799 (1 revision) (flutter/flutter#180870) 2026-01-13 [email protected] Make sure that an ErrorWidget doesn't crash in 0x0 environment (flutter/flutter#180830) 2026-01-13 [email protected] Make sure that a Banner doesn't crash in 0x0 environment (flutter/flutter#180254) 2026-01-13 [email protected] Adds metal background to engine dart tests (flutter/flutter#180700) 2026-01-13 [email protected] Add TabBar API example for scroll notification integration (flutter/flutter#180728) 2026-01-13 [email protected] Roll Skia from 714d0af2eda7 to 8f3134206e8d (1 revision) (flutter/flutter#180874) 2026-01-13 [email protected] Add build-time checks for ImpellerC's SkSL compiler (flutter/flutter#180861) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
) Manual roll requested by [email protected] flutter/flutter@793b0b8...b45a73b 2026-01-13 [email protected] Roll pub packages (flutter/flutter#180900) 2026-01-13 [email protected] Roll Dart SDK from 34318de9874b to ebaf52c13799 (1 revision) (flutter/flutter#180870) 2026-01-13 [email protected] Make sure that an ErrorWidget doesn't crash in 0x0 environment (flutter/flutter#180830) 2026-01-13 [email protected] Make sure that a Banner doesn't crash in 0x0 environment (flutter/flutter#180254) 2026-01-13 [email protected] Adds metal background to engine dart tests (flutter/flutter#180700) 2026-01-13 [email protected] Add TabBar API example for scroll notification integration (flutter/flutter#180728) 2026-01-13 [email protected] Roll Skia from 714d0af2eda7 to 8f3134206e8d (1 revision) (flutter/flutter#180874) 2026-01-13 [email protected] Add build-time checks for ImpellerC's SkSL compiler (flutter/flutter#180861) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This PR was generated by
flutter update-packages --force-upgrade.