macOS: Implement tooltip window controller by knopp · Pull Request #180895 · flutter/flutter

knopp · 2026-01-13T13:45:15Z

This PR implements tooltip windows on macOS.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

flutter-dashboard · 2026-01-13T13:45:23Z

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

gemini-code-assist

Code Review

This pull request introduces the implementation for tooltip window controllers on macOS, leveraging new sizing and positioning capabilities. This involves significant changes across Objective-C++ and Swift native code, as well as Dart FFI bindings and a new _WindowControllerMixin for shared logic. The changes appear well-structured and necessary for the new feature. The introduction of FlutterViewSizingDelegate and the sizedToContents property in FlutterView provides a robust mechanism for content-driven window sizing. The FlutterRunLoop modifications ensure smooth animation during native sheet transitions. The _WindowControllerMixin is a good step towards improving maintainability and reducing code duplication across different window controller types.

flutter-dashboard · 2026-01-13T18:19:56Z

CI had a failure that stopped further tests from running. We need to investigate to determine the root cause.

SHA at time of execution: 85d9d42.

Possible causes:

Configuration Changes: The .ci.yaml file might have been modified between the creation of this pull request and the start of this test run. This can lead to ci yaml validation errors.
Infrastructure Issues: Problems with the CI environment itself (e.g., quota) could have caused the failure.

A blank commit, or merging to head, will be required to resume running CI for this PR.

Error Details:

GitHub Error: You have exceeded a secondary rate limit. Please wait a few minutes before you try again. For more on scraping GitHub and how it may affect your rights, please review our Terms of Service (https://docs.github.com/en/site-policy/github-terms/github-terms-of-service) If you reach out to GitHub Support for help, please include the request ID D5FC:F00B5:208AB1C:8D8E825:69668CCC.

Stack trace:

#0      GitHub.handleStatusCode (package:github/src/common/github.dart:486:5)
#1      GitHub.request (package:github/src/common/github.dart:422:7)
<asynchronous suspension>
#2      GitHub.requestJson (package:github/src/common/github.dart:323:22)
<asynchronous suspension>
#3      RetryOptions.retry (package:retry/retry.dart:131:16)
<asynchronous suspension>
#4      LuciBuildService.scheduleTryBuilds (package:cocoon_service/src/service/luci_build_service.dart:246:24)
<asynchronous suspension>
#5      Scheduler._runCiTestingStage (package:cocoon_service/src/service/scheduler.dart:1254:9)
<asynchronous suspension>
#6      Scheduler.proceedToCiTestingStage (package:cocoon_service/src/service/scheduler.dart:1315:7)
<asynchronous suspension>
#7      Scheduler._closeSuccessfulEngineBuildStage (package:cocoon_service/src/service/scheduler.dart:1122:5)
<asynchronous suspension>
#8      Scheduler.processCheckRunCompleted (package:cocoon_service/src/service/scheduler.dart:1055:9)
<asynchronous suspension>
#9      PresubmitLuciSubscription.post (package:cocoon_service/src/request_handlers/presubmit_luci_subscription.dart:135:7)
<asynchronous suspension>
#10     RequestHandler.service (package:cocoon_service/src/request_handling/request_handler.dart:45:20)
<asynchronous suspension>
#11     SubscriptionHandler.service (package:cocoon_service/src/request_handling/subscription_handler.dart:140:5)
<asynchronous suspension>
#12     createServer.<anonymous closure> (package:cocoon_service/server.dart:351:7)
<asynchronous suspension>

loic-sharma · 2026-01-16T00:48:47Z

This looks good to me at a high-level! Feel free to ping me on Discord when this is ready for another look.

mattkae

A few notes, but looks good overall 👍

mattkae

One nit, but looks good otherwise 🚀 Maybe contact Justin + Loic if they want input though

mattkae · 2026-01-21T18:33:10Z

+      ..ref.onWillClose = onWillClose
+      ..ref.onNotifyListeners = onNotifyListeners
+      ..ref.onGetWindowPosition = onGetWindowPosition
+      ..ref.parentViewId = parentViewId ?? 0;


This null check is useless now?

LouiseHsu · 2026-01-22T22:39:43Z

@knopp from triage: do you think you could add a description for future reference? :)

loic-sharma · 2026-01-29T01:31:13Z

+- (NSSize)minimumViewSize:(FlutterView*)view {
+  return _creationRequest.has_constraints ? NSMakeSize(_creationRequest.constraints.min_width,
+                                                       _creationRequest.constraints.min_height)
+                                          : NSZeroSize;


For minimumViewSize and maximumViewSize, I don't like that these these return NSZeroSize. I worry that this magic value could cause weird bugs in the future if one uses these methods on a view that might not be sized to content.

Could we instead return the current size of the view if it's not sized to content? If not, could we have an assertion that this method is only called if the view is sized to content?

I will change it to std::optional<NSSize> instead.

loic-sharma

LGTM modulo one nitpick!

hellohuanlin · 2026-02-04T04:12:13Z

+  /// Displaying sheet animation (beginSheet) uses a private run loop mode for the animation
+  /// duration. FlutterRunLoop needs to work in this mode in order to render the window content
+  /// correctly during the sheet animation.
+  private static let moveTimerRunLoopMode = CFRunLoopMode("_NSMoveTimerRunLoopMode" as CFString)


this private api usage could result in app rejections.

I have removed this. It shouldn't have been in this PR anyway as it is unrelated to tooltips.

I've found a workaround where I can trigger a very quick invisible NSMoveHelper animation which uses the run loop mode, which can then be queried through CFRunLoopCopyAllModes and does not need specified explicitly.

hellohuanlin

LGTM

…#180895)

Roll Flutter from f916dd6887bf to e8f9dc50356d (34 revisions) flutter/flutter@f916dd6...e8f9dc5 2026-02-08 [email protected] Roll Skia from 9325111e6ee4 to b7db9f35f0f2 (1 revision) (flutter/flutter#182062) 2026-02-08 [email protected] Roll Skia from 3167229206b5 to 9325111e6ee4 (1 revision) (flutter/flutter#182061) 2026-02-08 [email protected] Roll Fuchsia Linux SDK from sYqpDF9l9-kldd9_Q... to iqtwdXlgKIyZkL5Li... (flutter/flutter#182058) 2026-02-08 [email protected] Roll Skia from ae78024b261e to 3167229206b5 (1 revision) (flutter/flutter#182055) 2026-02-07 [email protected] Roll Dart SDK from ad6368edbe02 to 965b51c219d3 (1 revision) (flutter/flutter#182050) 2026-02-07 [email protected] Roll Skia from a471f253b941 to ae78024b261e (1 revision) (flutter/flutter#182049) 2026-02-07 [email protected] Roll Fuchsia Linux SDK from IOzzhWfhdzhu3zHsz... to sYqpDF9l9-kldd9_Q... (flutter/flutter#182043) 2026-02-07 [email protected] Roll Dart SDK from 02092faa97c5 to ad6368edbe02 (2 revisions) (flutter/flutter#182040) 2026-02-07 [email protected] Roll Skia from 9a983f6c2c06 to a471f253b941 (24 revisions) (flutter/flutter#182039) 2026-02-07 [email protected] Add buffer around rerasterized input to fragment shaders to maintain coordinate space when clipped (flutter/flutter#181743) 2026-02-07 [email protected] Update Flutter's style guide for dot shorthands and extension methods (flutter/flutter#181934) 2026-02-06 [email protected] Manual roll Skia from 39aa2a70213a to 9a983f6c2c06 (flutter/flutter#181986) 2026-02-06 [email protected] Update doc in foundation to match the style guide (flutter/flutter#181972) 2026-02-06 [email protected] Roll Dart SDK from ec674bdb3ae4 to 02092faa97c5 (11 revisions) (flutter/flutter#182017) 2026-02-06 [email protected] Roll Packages from c197455 to 7805d3e (4 revisions) (flutter/flutter#182016) 2026-02-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[cupertino.dart] Implement CupertinoMenuAnchor and CupertinoMenuItem using RawMenuAnchor (#174695)" (flutter/flutter#182010) 2026-02-06 [email protected] Update Dart SDK to 3.12 beta1 (flutter/flutter#181948) 2026-02-06 [email protected] [cupertino.dart] Implement CupertinoMenuAnchor and CupertinoMenuItem using RawMenuAnchor (flutter/flutter#174695) 2026-02-06 [email protected] `flutter_tool` : Remove redundant enum types inside the enum definition scope (flutter/flutter#181910) 2026-02-06 [email protected] Roll pub packages (flutter/flutter#181973) 2026-02-05 [email protected] Roll Fuchsia Linux SDK from J2QdLcY2gyt4NP_xV... to IOzzhWfhdzhu3zHsz... (flutter/flutter#181971) 2026-02-05 [email protected] Directly generate a Mach-O dynamic library using gen_snapshot. [reland] (flutter/flutter#181539) 2026-02-05 [email protected] macOS: Implement tooltip window controller (flutter/flutter#180895) 2026-02-05 [email protected] Constrain RawAutocomplete options by soft keyboard (flutter/flutter#181930) 2026-02-05 [email protected] Roll Skia from 079d092f49e6 to 39aa2a70213a (1 revision) (flutter/flutter#181970) 2026-02-05 [email protected] perf: web ui loadFontFromList (flutter/flutter#181440) 2026-02-05 [email protected] Improve accessibility contrast for pre-test message (flutter/flutter#180469) 2026-02-05 [email protected] Roll pub packages (flutter/flutter#181965) 2026-02-05 [email protected] Roll Skia from 8543ce512d5c to 079d092f49e6 (8 revisions) (flutter/flutter#181964) 2026-02-05 [email protected] Add `clearError` API to Form and FormFieldState (flutter/flutter#180752) 2026-02-05 [email protected] Bump minimum required Xcode version to 15 and recommended to 16 (flutter/flutter#180531) 2026-02-05 [email protected] Rename "widgetTester" parameter to "tester" in "WidgetTesterCallback" (flutter/flutter#180944) 2026-02-05 [email protected] Roll Packages from 3bddf2c to c197455 (3 revisions) (flutter/flutter#181962) 2026-02-05 [email protected] Temporarily remove the Pixel 9/API 36 device from the Firebase Test Lab tests. (flutter/flutter#181956) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 ...

This PR implements tooltip windows on macOS. *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. a: desktop Running on desktop platform-macos labels Jan 13, 2026

gemini-code-assist Bot reviewed Jan 13, 2026

View reviewed changes

knopp changed the title ~~WIP: macOS: Implement tooltip window controller~~ macOS: Implement tooltip window controller Jan 14, 2026

loic-sharma requested review from loic-sharma and mattkae January 14, 2026 19:58

loic-sharma reviewed Jan 16, 2026

View reviewed changes

Comment thread engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEngine.mm Outdated

loic-sharma reviewed Jan 16, 2026

View reviewed changes

Comment thread engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterView.mm Outdated

loic-sharma reviewed Jan 16, 2026

View reviewed changes

Comment thread engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterWindowController.mm Outdated

loic-sharma reviewed Jan 16, 2026

View reviewed changes

Comment thread engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterWindowController.mm Outdated

knopp force-pushed the macos_tooltip2 branch from 7405ac9 to fe99710 Compare January 16, 2026 12:26

mattkae requested changes Jan 16, 2026

View reviewed changes

justinmc self-requested a review January 20, 2026 23:10

mattkae approved these changes Jan 21, 2026

View reviewed changes

knopp force-pushed the macos_tooltip2 branch from 13ce2e5 to 54de7db Compare January 22, 2026 12:56

loic-sharma reviewed Jan 29, 2026

View reviewed changes

loic-sharma approved these changes Jan 29, 2026

View reviewed changes

LongCatIsLooong requested a review from hellohuanlin January 29, 2026 22:44

hellohuanlin reviewed Feb 4, 2026

View reviewed changes

knopp force-pushed the macos_tooltip2 branch from 54de7db to 9fdeb8a Compare February 4, 2026 18:05

hellohuanlin approved these changes Feb 4, 2026

View reviewed changes

knopp added 3 commits February 5, 2026 15:19

Common code

7d0f703

MacOS tooltip implementation

8548121

wip

846e91a

knopp added 4 commits February 5, 2026 15:19

Add additional test

8585961

Fix linter issues

49c7cd9

Nits

57598e7

remove accidental code

011c10a

knopp force-pushed the macos_tooltip2 branch from 8abb0c2 to 011c10a Compare February 5, 2026 14:20

Use std::nullopt instead of relying on magical value.

69d0c0f

knopp enabled auto-merge February 5, 2026 22:21

knopp added this pull request to the merge queue Feb 5, 2026

Merged via the queue into flutter:master with commit 692dbb7 Feb 5, 2026
181 checks passed

knopp deleted the macos_tooltip2 branch February 5, 2026 23:44

engine-flutter-autoroll mentioned this pull request Feb 6, 2026

Roll Flutter from f916dd6887bf to a12bfe69b6a1 (18 revisions) flutter/packages#10971

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2026

692dbb71e macOS: Implement tooltip window controller (flutter/flutter…

644c2f0

…#180895)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2026

692dbb71e macOS: Implement tooltip window controller (flutter/flutter…

b974cd3

…#180895)

engine-flutter-autoroll mentioned this pull request Feb 6, 2026

Roll Flutter from f916dd6887bf to fa51de92648d (19 revisions) flutter/packages#10972

Closed

Piinks mentioned this pull request Feb 6, 2026

Flutter Notable Commits - 2026 #181433

Open

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2026

692dbb71e macOS: Implement tooltip window controller (flutter/flutter…

01a0367

…#180895)

engine-flutter-autoroll mentioned this pull request Feb 7, 2026

Roll Flutter from f916dd6887bf to 010cd4f383b4 (30 revisions) flutter/packages#10974

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2026

692dbb71e macOS: Implement tooltip window controller (flutter/flutter…

4bc72f6

…#180895)

engine-flutter-autoroll mentioned this pull request Feb 7, 2026

Roll Flutter from f916dd6887bf to 010cd4f383b4 (30 revisions) flutter/packages#10975

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2026

692dbb71e macOS: Implement tooltip window controller (flutter/flutter…

808d35c

…#180895)

engine-flutter-autoroll mentioned this pull request Feb 8, 2026

Roll Flutter from f916dd6887bf to e8f9dc50356d (34 revisions) flutter/packages#10978

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2026

692dbb71e macOS: Implement tooltip window controller (flutter/flutter…

38779c4

…#180895)

engine-flutter-autoroll mentioned this pull request Feb 8, 2026

Roll Flutter from f916dd6887bf to e8f9dc50356d (34 revisions) flutter/packages#10979

Merged

stuartmorgan-g added platform-macos Building on or for macOS specifically and removed platform-macos labels Apr 16, 2026

Conversation

knopp commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard Bot commented Jan 13, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

flutter-dashboard Bot commented Jan 13, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

loic-sharma commented Jan 16, 2026

Uh oh!

mattkae left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mattkae left a comment

Choose a reason for hiding this comment

Uh oh!

mattkae Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

LouiseHsu commented Jan 22, 2026

Uh oh!

loic-sharma Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

knopp Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

loic-sharma left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hellohuanlin Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

knopp Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hellohuanlin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

knopp commented Jan 13, 2026 •

edited

Loading