clean up usages of resetXyz for TestFlutterView by navaronbracke · Pull Request #180840 · flutter/flutter

navaronbracke · 2026-01-12T11:09:09Z

While reviewing #180728 we noticed that usage of TestFlutterView.resetXyz() was quite liberal and some places benefit from using TestFlutterView.reset(), to avoid repetition.

This PR cleans that up.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

navaronbracke · 2026-01-12T11:10:01Z

    tester.view.physicalSize = const Size(200, 160);
    tester.view.devicePixelRatio = 1.0;
-    addTearDown(tester.view.resetPhysicalSize);
+    addTearDown(tester.view.reset);


This sounds like a bug, since tester.view.devicePixelRatio was not reset?

navaronbracke · 2026-01-12T11:10:33Z

+    // Regression test for https://github.com/flutter/flutter/issues/112163

    tester.view.physicalSize = const Size(540, 340);
+    addTearDown(tester.view.resetPhysicalSize);


Moved it upwards, so that it is easy to see that the teardown is there, instead of putting it at the bottom of the test.

gemini-code-assist

Code Review

This pull request cleans up the usage of resetXyz methods for TestFlutterView in several tests, preferring TestFlutterView.reset() for conciseness and correctness. The changes are generally good, replacing multiple reset calls with a single one and fixing a bug where not all modified view properties were being reset. I've found one place where the cleanup could be improved by using addTearDown for more robust test cleanup, consistent with the changes in other files.

huycozy

LGTM with one nit! Thanks for cleaning this!

Can you also make this for

flutter/packages/flutter/test/material/navigation_drawer_test.dart

Line 594 in d7965e1

tester.view.physicalSize = Size(viewWidth * dpi, viewHeight * dpi);

as well?

navaronbracke · 2026-01-13T08:01:51Z

@Piinks Turns out that cleaning this up does reveal that usages of TestFlutterView's various test-only setters could probably use a custom lint rule for flutter/flutter. (there's a bunch of things, such as addTearDown being set up multiple times, the tear down being in an odd place in the test etc)

Who is in charge of figuring out which manual checks in dev/bots can be converted into lint rules? I'd like to reach out an propose a lint rule that makes this easier to clean up / catch in the future.

huycozy

LGTM! Thank you!

huycozy · 2026-01-13T09:10:10Z

Requesting @justinmc review: ~~to trigger Google testing~~(looks like my approval triggered it somehow, I have no idea 🤷‍♂️)
, and also think this is good to be included and merged in test cleanup work to serve in decoupling project too.

navaronbracke · 2026-01-13T13:54:07Z

Requesting @justinmc review: to trigger Google testing, and also think this is good to be included and merged in test cleanup work to serve in decoupling project too.

I don't quite follow? TestFlutterView is unrelated to that project.

huycozy · 2026-01-13T14:27:00Z

I don't quite follow? TestFlutterView is unrelated to that project.

It's just my thought. Sorry for not making it clearer. Because I personally think it's better to complete this work before two separate packages are out, rather than 3 PRs in the future (material, cupertino and flutter repo(s)). Does this make sense?

navaronbracke · 2026-01-13T14:33:53Z

Right, all three do use TestFlutterView for some things in tests. My bad. Although the Material / Cupertino split on its own is going to take a while. I also think that if there is a flutter_lints specific lint rule for TestFlutterView, Cupertino and Material could adopt said rule independently.

justinmc

Great catches on all of these, thanks for cleaning these up! LGTM 👍

…utter#180840)

While reviewing flutter#180728 we noticed that usage of `TestFlutterView.resetXyz()` was quite liberal and some places benefit from using `TestFlutterView.reset()`, to avoid repetition. This PR cleans that up. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…utter#180840)

While reviewing flutter#180728 we noticed that usage of `TestFlutterView.resetXyz()` was quite liberal and some places benefit from using `TestFlutterView.reset()`, to avoid repetition. This PR cleans that up. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

clean up usages of resetXyz for TestFlutterView

b1fbabd

navaronbracke commented Jan 12, 2026

View reviewed changes

gemini-code-assist Bot reviewed Jan 12, 2026

View reviewed changes

Comment thread packages/flutter/test/widgets/two_dimensional_viewport_test.dart Outdated

huycozy reviewed Jan 13, 2026

View reviewed changes

feedback

86f4864

navaronbracke requested a review from huycozy January 13, 2026 07:58

github-actions Bot added the f: cupertino flutter/packages/flutter/cupertino repository label Jan 13, 2026

huycozy approved these changes Jan 13, 2026

View reviewed changes

huycozy requested a review from justinmc January 13, 2026 09:10

justinmc approved these changes Jan 16, 2026

View reviewed changes

justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 16, 2026

auto-submit Bot added this pull request to the merge queue Jan 17, 2026

Merged via the queue into flutter:master with commit 74f162d Jan 17, 2026
71 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 17, 2026

engine-flutter-autoroll mentioned this pull request Jan 17, 2026

Roll Flutter from 48c247582e45 to 7bc5493d88bf (70 revisions) flutter/packages#10823

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 17, 2026

74f162d18 clean up usages of resetXyz for TestFlutterView (flutter/fl…

d23d557

…utter#180840)

engine-flutter-autoroll mentioned this pull request Jan 17, 2026

Roll Flutter from 48c247582e45 to 7bc5493d88bf (70 revisions) flutter/packages#10824

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 17, 2026

74f162d18 clean up usages of resetXyz for TestFlutterView (flutter/fl…

4de1f25

…utter#180840)

engine-flutter-autoroll mentioned this pull request Jan 18, 2026

Roll Flutter from 48c247582e45 to d20405293d08 (78 revisions) flutter/packages#10826

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 18, 2026

74f162d18 clean up usages of resetXyz for TestFlutterView (flutter/fl…

872964d

…utter#180840)

engine-flutter-autoroll mentioned this pull request Jan 18, 2026

Roll Flutter from 48c247582e45 to d20405293d08 (78 revisions) flutter/packages#10827

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 18, 2026

74f162d18 clean up usages of resetXyz for TestFlutterView (flutter/fl…

67ab677

…utter#180840)

engine-flutter-autoroll mentioned this pull request Jan 19, 2026

Roll Flutter from 48c247582e45 to 8329989d2978 (79 revisions) flutter/packages#10829

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2026

74f162d18 clean up usages of resetXyz for TestFlutterView (flutter/fl…

2871493

…utter#180840)

engine-flutter-autoroll mentioned this pull request Jan 19, 2026

Roll Flutter from 48c247582e45 to d21322b1b67b (80 revisions) flutter/packages#10830

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2026

74f162d18 clean up usages of resetXyz for TestFlutterView (flutter/fl…

c1973bc

…utter#180840)

engine-flutter-autoroll mentioned this pull request Jan 19, 2026

Roll Flutter from 48c247582e45 to 58260a7f0a51 (82 revisions) flutter/packages#10831

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2026

74f162d18 clean up usages of resetXyz for TestFlutterView (flutter/fl…

7caae76

…utter#180840)

engine-flutter-autoroll mentioned this pull request Jan 20, 2026

Roll Flutter from 48c247582e45 to 841e195e8356 (96 revisions) flutter/packages#10834

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 20, 2026

74f162d18 clean up usages of resetXyz for TestFlutterView (flutter/fl…

42949c9

…utter#180840)

engine-flutter-autoroll mentioned this pull request Jan 20, 2026

Roll Flutter from 48c247582e45 to 4628fdbcde3c (97 revisions) flutter/packages#10835

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 20, 2026

74f162d18 clean up usages of resetXyz for TestFlutterView (flutter/fl…

59d07ee

…utter#180840)

engine-flutter-autoroll mentioned this pull request Jan 20, 2026

Roll Flutter from 48c247582e45 to 1d70a351c96f (98 revisions) flutter/packages#10837

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 20, 2026

74f162d18 clean up usages of resetXyz for TestFlutterView (flutter/fl…

c5c3d9e

…utter#180840)

engine-flutter-autoroll mentioned this pull request Jan 20, 2026

Roll Flutter from 48c247582e45 to 2d7c3105aa22 (99 revisions) flutter/packages#10838

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 20, 2026

74f162d18 clean up usages of resetXyz for TestFlutterView (flutter/fl…

1abd613

…utter#180840)

engine-flutter-autoroll mentioned this pull request Jan 20, 2026

Manual roll Flutter from 48c247582e45 to 8cbe1be5e6cf (104 revisions) flutter/packages#10840

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 20, 2026

74f162d18 clean up usages of resetXyz for TestFlutterView (flutter/fl…

2a6d1e3

…utter#180840)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 21, 2026

74f162d18 clean up usages of resetXyz for TestFlutterView (flutter/fl…

2b72081

…utter#180840)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 21, 2026

74f162d18 clean up usages of resetXyz for TestFlutterView (flutter/fl…

ef5701d

…utter#180840)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 21, 2026

74f162d18 clean up usages of resetXyz for TestFlutterView (flutter/fl…

d21df23

…utter#180840)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2026

74f162d18 clean up usages of resetXyz for TestFlutterView (flutter/fl…

3a9df2e

…utter#180840)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2026

74f162d18 clean up usages of resetXyz for TestFlutterView (flutter/fl…

4626798

…utter#180840)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2026

74f162d18 clean up usages of resetXyz for TestFlutterView (flutter/fl…

7296176

…utter#180840)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2026

74f162d18 clean up usages of resetXyz for TestFlutterView (flutter/fl…

f33041f

…utter#180840)

navaronbracke deleted the test_view_reset_cleanup branch January 30, 2026 07:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

clean up usages of resetXyz for TestFlutterView#180840

clean up usages of resetXyz for TestFlutterView#180840
auto-submit[bot] merged 2 commits into
flutter:masterfrom
navaronbracke:test_view_reset_cleanup

navaronbracke commented Jan 12, 2026

Uh oh!

navaronbracke Jan 12, 2026

Uh oh!

navaronbracke Jan 12, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

huycozy left a comment

Uh oh!

navaronbracke commented Jan 13, 2026

Uh oh!

huycozy left a comment

Uh oh!

huycozy commented Jan 13, 2026 •

edited

Loading

Uh oh!

navaronbracke commented Jan 13, 2026

Uh oh!

huycozy commented Jan 13, 2026

Uh oh!

navaronbracke commented Jan 13, 2026

Uh oh!

justinmc left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

navaronbracke commented Jan 12, 2026

Pre-launch Checklist

Uh oh!

navaronbracke Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

navaronbracke Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

huycozy left a comment

Choose a reason for hiding this comment

Uh oh!

navaronbracke commented Jan 13, 2026

Uh oh!

huycozy left a comment

Choose a reason for hiding this comment

Uh oh!

huycozy commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

navaronbracke commented Jan 13, 2026

Uh oh!

huycozy commented Jan 13, 2026

Uh oh!

navaronbracke commented Jan 13, 2026

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

huycozy commented Jan 13, 2026 •

edited

Loading