[W] Clean up output of "flutter run --release" #18049
Conversation
|
cc @tvolkert |
There was a problem hiding this comment.
It's a derivative work of a 2017 test.
There was a problem hiding this comment.
'Failed to run test app; runner exited with exit code $runExitCode.'
There was a problem hiding this comment.
Add a timeout in case the tool is failing to properly quit
There was a problem hiding this comment.
IIRC all devicelab tests have a built-in timeout.
There was a problem hiding this comment.
Let's add proper Dartdoc to this method instead.
dev/devicelab/manifest.yaml
Outdated
There was a problem hiding this comment.
file says to always add tests with flaky:true initially, to test it on devicelab as a dry run before exposing everyone else to the test.
dev/devicelab/manifest.yaml
Outdated
There was a problem hiding this comment.
Seems like it'd be good to have this on iOS too
There was a problem hiding this comment.
Though the test is pretty Android-centric in its expectations of the output...
There was a problem hiding this comment.
Yeah. Let's start with an Android test and add the iOS test separately if it makes sense.
There was a problem hiding this comment.
The indentation of the comments looks weird here
There was a problem hiding this comment.
It's lined up with the the expression to which they refer
There was a problem hiding this comment.
Should this not consult the return value of printHelpDetails()?
There was a problem hiding this comment.
oh I meant to remove the return value. Turns out to do it strictly correct you'd need to be able to get the return value without calling it (or we could change it to have it return a string or list of strings instead of printing), and in practice it doesn't really matter that much since we can predict how it will react in the cases that matter.
Hixie
changed the title
|
I accidentally ended up cleaning up @tvolkert PTAL. |
|
will land on green. |
|
Going to revert, had two failures. |
3 participants
No description provided.