Make sure that a LongPressDraggable doesn't crash in 0x0 environment#180408
Merged
auto-submit[bot] merged 5 commits intoJan 12, 2026
Merged
Conversation
github-actions
Bot
added
framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a test to ensure LongPressDraggable doesn't crash in a zero-size environment. The test correctly sets up the scenario with a zero-sized widget. However, it misses simulating the long press gesture, which is the actual trigger for the crash described in the associated issue. I've added suggestions to complete the test by adding the long press action and also to improve code style by using const constructors.
| ), | ||
| ), | ||
| ); | ||
| expect(tester.getSize(find.byType(LongPressDraggable<bool>)), Size.zero); |
Contributor
There was a problem hiding this comment.
This test is intended to verify that LongPressDraggable doesn't crash in a zero-sized environment, as per the issue description. However, it only checks that the widget can be created with a zero size. It doesn't simulate a long press, which is the action that would trigger the crash.
To properly test the fix, you should simulate a long press gesture on the widget.
expect(tester.getSize(find.byType(LongPressDraggable<bool>)), Size.zero);
// This should not crash.
await tester.longPress(find.byType(LongPressDraggable<bool>));
await tester.pump();
Comment on lines
+130
to
+131
| feedback: Text('Y'), | ||
| child: Text('X'), |
Contributor
There was a problem hiding this comment.
For better performance and to follow Dart best practices, it's recommended to use const for constructors of widgets that do not change, like Text with a constant string.
Suggested change
| feedback: Text('Y'), | |
| child: Text('X'), | |
| feedback: const Text('Y'), | |
| child: const Text('X'), |
victorsanni
approved these changes
Jan 5, 2026
Comment on lines
+130
to
+131
| feedback: Text('Y'), | ||
| child: Text('X'), |
dkwingsmt
reviewed
Jan 6, 2026
dkwingsmt
left a comment
dkwingsmt
left a comment
Contributor
There was a problem hiding this comment.
Since an overlay is involved, I think we should set the viewport size instead.
dkwingsmt
approved these changes
Jan 12, 2026
dkwingsmt
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 12, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 12, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 12, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 12, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 12, 2026
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jan 12, 2026
flutter/flutter@3134be8...d81cd3e 2026-01-12 [email protected] Migrate doc and code to use sendAnnounce (flutter/flutter#180776) 2026-01-12 [email protected] Roll Packages from 51fe1d9 to e57e7f4 (3 revisions) (flutter/flutter#180846) 2026-01-12 [email protected] Fix: Allow dartpad embed clipboard-write permission for "Copy to clipboard" functionality (flutter/flutter#178057) 2026-01-12 [email protected] Roll Dart SDK from 87fbfd5381b6 to 42fd9ef68c1a (1 revision) (flutter/flutter#180836) 2026-01-12 [email protected] Roll Skia from aefdde600f1e to 487a9943210b (3 revisions) (flutter/flutter#180835) 2026-01-12 [email protected] Bump ffigen (flutter/flutter#180507) 2026-01-12 [email protected] Roll Skia from d42a43daa6cf to aefdde600f1e (1 revision) (flutter/flutter#180829) 2026-01-12 [email protected] Make sure that a LongPressDraggable doesn't crash in 0x0 environment (flutter/flutter#180408) 2026-01-12 [email protected] Make sure that a FlutterLogo doesn't crash in 0x0 environment (flutter/flutter#180617) 2026-01-12 [email protected] Roll Fuchsia Linux SDK from T_HOCpDjLgzi1SUMq... to VYeyMPe1lyCtlcl-V... (flutter/flutter#180825) 2026-01-11 [email protected] Roll Skia from f39cc645b1dd to d42a43daa6cf (2 revisions) (flutter/flutter#180819) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ivan-vanyusho
pushed a commit
to ivan-vanyusho/packages
that referenced
this pull request
Jan 26, 2026
flutter/flutter@3134be8...d81cd3e 2026-01-12 [email protected] Migrate doc and code to use sendAnnounce (flutter/flutter#180776) 2026-01-12 [email protected] Roll Packages from 51fe1d9 to e57e7f4 (3 revisions) (flutter/flutter#180846) 2026-01-12 [email protected] Fix: Allow dartpad embed clipboard-write permission for "Copy to clipboard" functionality (flutter/flutter#178057) 2026-01-12 [email protected] Roll Dart SDK from 87fbfd5381b6 to 42fd9ef68c1a (1 revision) (flutter/flutter#180836) 2026-01-12 [email protected] Roll Skia from aefdde600f1e to 487a9943210b (3 revisions) (flutter/flutter#180835) 2026-01-12 [email protected] Bump ffigen (flutter/flutter#180507) 2026-01-12 [email protected] Roll Skia from d42a43daa6cf to aefdde600f1e (1 revision) (flutter/flutter#180829) 2026-01-12 [email protected] Make sure that a LongPressDraggable doesn't crash in 0x0 environment (flutter/flutter#180408) 2026-01-12 [email protected] Make sure that a FlutterLogo doesn't crash in 0x0 environment (flutter/flutter#180617) 2026-01-12 [email protected] Roll Fuchsia Linux SDK from T_HOCpDjLgzi1SUMq... to VYeyMPe1lyCtlcl-V... (flutter/flutter#180825) 2026-01-11 [email protected] Roll Skia from f39cc645b1dd to d42a43daa6cf (2 revisions) (flutter/flutter#180819) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
flutter/flutter@3134be8...d81cd3e 2026-01-12 [email protected] Migrate doc and code to use sendAnnounce (flutter/flutter#180776) 2026-01-12 [email protected] Roll Packages from 51fe1d9 to e57e7f4 (3 revisions) (flutter/flutter#180846) 2026-01-12 [email protected] Fix: Allow dartpad embed clipboard-write permission for "Copy to clipboard" functionality (flutter/flutter#178057) 2026-01-12 [email protected] Roll Dart SDK from 87fbfd5381b6 to 42fd9ef68c1a (1 revision) (flutter/flutter#180836) 2026-01-12 [email protected] Roll Skia from aefdde600f1e to 487a9943210b (3 revisions) (flutter/flutter#180835) 2026-01-12 [email protected] Bump ffigen (flutter/flutter#180507) 2026-01-12 [email protected] Roll Skia from d42a43daa6cf to aefdde600f1e (1 revision) (flutter/flutter#180829) 2026-01-12 [email protected] Make sure that a LongPressDraggable doesn't crash in 0x0 environment (flutter/flutter#180408) 2026-01-12 [email protected] Make sure that a FlutterLogo doesn't crash in 0x0 environment (flutter/flutter#180617) 2026-01-12 [email protected] Roll Fuchsia Linux SDK from T_HOCpDjLgzi1SUMq... to VYeyMPe1lyCtlcl-V... (flutter/flutter#180825) 2026-01-11 [email protected] Roll Skia from f39cc645b1dd to d42a43daa6cf (2 revisions) (flutter/flutter#180819) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my attempt to handle #6537 for the LongPressDraggable widget.