Migrate CalendarDatePicker to declarative live regions for accessibility by Franklyn-R-Silva · Pull Request #180131 · flutter/flutter

Franklyn-R-Silva · 2025-12-19T18:11:16Z

Description

This PR migrates the CalendarDatePicker and _MonthPicker widgets from the deprecated SemanticsService.sendAnnouncement to a declarative approach using liveRegion: true.

As specified in #180096 and #177785, SemanticsService.sendAnnouncement is deprecated on Android as of API 36. By using a live region, we ensure that state change announcements (like month navigation and date selection) remain accessible and compliant with modern platform standards.

Changes:

Added _announcementText to _CalendarDatePickerState and _MonthPickerState to track accessibility messages.
Introduced an invisible Semantics widget with liveRegion: true in the build methods to process these announcements.
Updated calendar_date_picker_test.dart to verify the SemanticsFlag.isLiveRegion on the semantics tree instead of capturing imperatice announcements.

Related Issues

Fixes #177785
Relates to #180096

Tests

Updated packages/flutter/test/material/calendar_date_picker_test.dart to verify the new declarative announcement logic.

gemini-code-assist

Code Review

This pull request successfully migrates CalendarDatePicker and _MonthPicker from the deprecated SemanticsService.sendAnnouncement to a declarative approach using Semantics with liveRegion: true. The changes are well-implemented, replacing imperative announcements with state updates that drive a live region for accessibility announcements.

My main feedback is on the test file calendar_date_picker_test.dart. While the test was correctly updated to reflect the new implementation, I found the logic for verifying semantics announcements to be brittle and contain a subtle bug. I've provided a suggestion to refactor the test for improved robustness and readability.

Overall, this is a solid improvement for accessibility compliance.

hannah-hyj · 2025-12-19T18:47:18Z

Hi @Franklyn-R-Silva,
Thank you for your attention to this a11y issue!
Not sure if you've had a chance to test this on Android yet. from the first glance, you're adding a live region outside of a SizedBox.shrink() and it will result in a zero-size node, which will cause it to be dropped from the semantics tree, and nothing will be announced.
To actually address this issue we need to wrap the semantics live region with a relevant widget and use accessiblityFocusBlockType to make sure focus traversal is still correct after adding the live region and test on an android device. Also we will only remove the a11y announcement for android but keep it on other platform.

…icker - Wrap Semantics live region with SizedBox and Column to avoid zero-size nodes. - Add accessiblityFocusBlockType to ensure correct focus traversal. - Maintain imperative announcements for non-Android platforms in _handleDayChanged and _handleMonthPageChanged.

Franklyn-R-Silva · 2025-12-19T19:44:32Z

Hi @Franklyn-R-Silva, Thank you for your attention to this a11y issue! Not sure if you've had a chance to test this on Android yet. from the first glance, you're adding a live region outside of a SizedBox.shrink() and it will result in a zero-size node, which will cause it to be dropped from the semantics tree, and nothing will be announced. To actually address this issue we need to wrap the semantics live region with a relevant widget and use accessiblityFocusBlockType to make sure focus traversal is still correct after adding the live region and test on an android device. Also we will only remove the a11y announcement for android but keep it on other platform.

Hi @hannah-hyj, thank you for the feedback!

I have updated the code to address the accessibility concerns:

Visibility: I wrapped the Semantics live regions with widgets that have physical dimensions (SizedBox and Column) to ensure they are not dropped from the semantics tree.

Focus Traversal: I added accessiblityFocusBlockType: AccessiblityFocusBlockType.none to maintain correct traversal after adding the live regions.

Platform Parity: I refactored the announcement logic to ensure Android uses the declarative approach while maintaining imperative announcements for other platforms.

Note: I am still working on updating the tests in calendar_date_picker_test.dart to reflect these changes and will push them shortly. I will ping you again once the tests are ready for review.

…egion

Franklyn-R-Silva · 2025-12-19T19:59:17Z

Hi @Franklyn-R-Silva, Thank you for your attention to this a11y issue! Not sure if you've had a chance to test this on Android yet. from the first glance, you're adding a live region outside of a SizedBox.shrink() and it will result in a zero-size node, which will cause it to be dropped from the semantics tree, and nothing will be announced. To actually address this issue we need to wrap the semantics live region with a relevant widget and use accessiblityFocusBlockType to make sure focus traversal is still correct after adding the live region and test on an android device. Also we will only remove the a11y announcement for android but keep it on other platform.

Hi @hannah-hyj,

I’ve updated the PR to address your feedback:

Visibility: Wrapped Semantics in visible containers (SizedBox/Column) to prevent zero-size nodes.

Focus: Added accessiblityFocusBlockType to ensure correct traversal.

Platforms: Refactored logic to use declarative live regions on Android and maintain imperative announcements on other platforms.

Tests: Updated tests using the Android variant to verify the isLiveRegion flag.

Ready for another look!

…egion

hannah-hyj

Hi @Franklyn-R-Silva I just got back from the vacation and I'm taking a look at this PR again!

Co-authored-by: Hannah Jin <[email protected]>

…egion

Franklyn-R-Silva

review

hannah-hyj · 2026-01-14T00:44:11Z

    return Stack(
      children: <Widget>[
-        SizedBox(height: _subHeaderHeight + scaledMaxDayPickerHeight, child: _buildPicker()),
+        Semantics(


we should only add this Semantics widget here if platform == TargetPlatform.android.

hannah-hyj · 2026-01-14T00:53:07Z

-            '${_localizations.selectedDateLabel} ${widget.calendarDelegate.formatFullDate(_selectedDate!, _localizations)}$semanticLabelSuffix',
-            _textDirection,
-          );
-        case TargetPlatform.android:


It looks like the previous behavior was to use sendAnnouncement only on Linux, macOS, and Windows, but not on Android or iOS. I'm not sure why that was the case. However, since the goal of this PR is to remove the deprecated sendAnnouncement usage on Android, I don't think we need to change anything in this code block (L313–L328).

hannah-hyj · 2026-01-14T00:54:43Z

Hi @Franklyn-R-Silva ! this PR looks good to me over all and i just left a few more comments!

Co-authored-by: Hannah Jin <[email protected]>

…egion

hannah-hyj · 2026-01-16T22:07:16Z

looks like some tests in calendar_date_picker_test.dart is failing, could you take a look?

…egion

Franklyn-R-Silva · 2026-01-20T12:42:18Z

looks like some tests in calendar_date_picker_test.dart is failing, could you take a look?

Yes, I'll check it out. I'm very busy at work and haven't had time to check everything yet.

flutter-dashboard · 2026-02-09T12:43:22Z

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

justinmc · 2026-02-17T23:08:02Z

@Franklyn-R-Silva Do you still plan to come back and finish this PR?

hannah-hyj · 2026-02-25T20:37:53Z

hi @Franklyn-R-Silva, thank you for your attention to this issue. I will now mark this PR as inactive and close it, and create a new PR based on it.

Migrate CalendarDatePicker to declarative live regions for accessibility

fe099e2

github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels Dec 19, 2025

Franklyn-R-Silva mentioned this pull request Dec 19, 2025

Remove CalendarDatepicker usage of Semantic Announcements #180096

Closed

gemini-code-assist Bot reviewed Dec 19, 2025

View reviewed changes

Comment thread packages/flutter/test/material/calendar_date_picker_test.dart Resolved

test: Refactor semantics test logic and fix lint warnings

cacf0ab

This was referenced Dec 19, 2025

Remove ExpansionTile usage of Semantic Announcements #177785

Closed

Replace semantic announcements for Android #165510

Closed

Merge branch 'master' into migrate-datepicker-announcements-to-live-r…

1634e09

…egion

Franklyn-R-Silva added 2 commits December 20, 2025 08:13

Merge branch 'master' into migrate-datepicker-announcements-to-live-r…

92014e2

…egion

Merge branch 'master' into migrate-datepicker-announcements-to-live-r…

338f99d

…egion

hannah-hyj self-requested a review January 6, 2026 21:21

hannah-hyj requested changes Jan 7, 2026

View reviewed changes

Franklyn-R-Silva and others added 7 commits January 10, 2026 09:08

Update packages/flutter/lib/src/material/calendar_date_picker.dart

5d18c94

Co-authored-by: Hannah Jin <[email protected]>

Update packages/flutter/lib/src/material/calendar_date_picker.dart

c99fcb2

Co-authored-by: Hannah Jin <[email protected]>

Update packages/flutter/lib/src/material/calendar_date_picker.dart

2a58f3d

Co-authored-by: Hannah Jin <[email protected]>

Update packages/flutter/lib/src/material/calendar_date_picker.dart

a40c72f

Co-authored-by: Hannah Jin <[email protected]>

Update packages/flutter/lib/src/material/calendar_date_picker.dart

36bd0cb

Co-authored-by: Hannah Jin <[email protected]>

Update packages/flutter/lib/src/material/calendar_date_picker.dart

7297040

Co-authored-by: Hannah Jin <[email protected]>

Merge branch 'master' into migrate-datepicker-announcements-to-live-r…

1428338

…egion

Franklyn-R-Silva commented Jan 10, 2026

View reviewed changes

Franklyn-R-Silva requested a review from hannah-hyj January 10, 2026 12:15

hannah-hyj reviewed Jan 14, 2026

View reviewed changes

Franklyn-R-Silva and others added 2 commits January 14, 2026 08:43

Update packages/flutter/lib/src/material/calendar_date_picker.dart

ba76f05

Co-authored-by: Hannah Jin <[email protected]>

Update packages/flutter/lib/src/material/calendar_date_picker.dart

de043e7

Co-authored-by: Hannah Jin <[email protected]>

Merge branch 'master' into migrate-datepicker-announcements-to-live-r…

9514ea4

…egion

hannah-hyj added the a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) label Jan 16, 2026

Merge branch 'master' into migrate-datepicker-announcements-to-live-r…

0ed99b0

…egion

github-actions Bot removed the a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) label Jan 20, 2026

hannah-hyj closed this Feb 25, 2026

Conversation

Franklyn-R-Silva commented Dec 19, 2025

Description

Changes:

Related Issues

Tests

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

hannah-hyj commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Franklyn-R-Silva commented Dec 19, 2025

Uh oh!

Franklyn-R-Silva commented Dec 19, 2025

Uh oh!

hannah-hyj left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Franklyn-R-Silva left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hannah-hyj Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

hannah-hyj Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

hannah-hyj commented Jan 14, 2026

Uh oh!

hannah-hyj commented Jan 16, 2026

Uh oh!

Franklyn-R-Silva commented Jan 20, 2026

Uh oh!

flutter-dashboard Bot commented Feb 9, 2026

Uh oh!

justinmc commented Feb 17, 2026

Uh oh!

hannah-hyj commented Feb 25, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hannah-hyj commented Dec 19, 2025 •

edited

Loading