-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Platform View Hide/Show Integration test #179902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4f7655a to
1831a92
Compare
b3f3832 to
38f7c5c
Compare
...ntegration_tests/android_engine_test/test_driver/platform_view/hide_show_hide_main_test.dart
Show resolved
Hide resolved
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Adds an integration test that would have caught the issue with #176063
The test is simple. It hides, shows, then hides at platform view. If the issue is present, the UI will be come frozen and the button text will not correctly update. So you'll see no platform view showing, but the button will read, "Hide Platform View" instead of "Show Platform View". Checking this through the FlutterDriver is not enough (because the widget tree is updated). The actual UI rendered to the Android device needs to be checked (thus the golden screenshot is necessary).
Adding this integration test should ensure content sizing does not cause this issue again.
Test failing with Content Sizing changes:
PlatformView Integration Test Failing.webm
Test passing with Content Sizing changes w/fix:
PlatformView Integration Test Passing.webm
Pre-launch Checklist
///).