Skip to content

Conversation

@mboetger
Copy link
Contributor

@mboetger mboetger commented Dec 15, 2025

Adds an integration test that would have caught the issue with #176063

The test is simple. It hides, shows, then hides at platform view. If the issue is present, the UI will be come frozen and the button text will not correctly update. So you'll see no platform view showing, but the button will read, "Hide Platform View" instead of "Show Platform View". Checking this through the FlutterDriver is not enough (because the widget tree is updated). The actual UI rendered to the Android device needs to be checked (thus the golden screenshot is necessary).

Adding this integration test should ensure content sizing does not cause this issue again.

Test failing with Content Sizing changes:
PlatformView Integration Test Failing.webm

Test passing with Content Sizing changes w/fix:
PlatformView Integration Test Passing.webm

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added platform-android Android applications specifically engine flutter/engine related. See also e: labels. team-android Owned by Android platform team labels Dec 15, 2025
@github-actions github-actions bot removed platform-android Android applications specifically engine flutter/engine related. See also e: labels. team-android Owned by Android platform team labels Dec 16, 2025
@mboetger mboetger changed the title Surface Image Revert Integration test Platform View Hide/Show Integration test Dec 16, 2025
@mboetger mboetger marked this pull request as ready for review December 16, 2025 21:51
@mboetger mboetger requested a review from a team December 16, 2025 22:10
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #179902 at sha 601bc68

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Dec 17, 2025
@mboetger mboetger added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 17, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Dec 17, 2025
Merged via the queue into flutter:master with commit 90211b9 Dec 17, 2025
150 of 151 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 17, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

will affect goldens Changes to golden files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants