Skip to content

Conversation

@zijiehe-google-com
Copy link
Contributor

@zijiehe-google-com zijiehe-google-com commented Dec 15, 2025

Reverts #179744

https://ci.chromium.org/ui/p/flutter/builders/staging/Linux%20linux_fuchsia_tests?limit=200
Fuchsia builder is green now, the disabled test is actively investigated by @caroqliu . We can move fuchsia back to prod to avoid unexpected breakages.

@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Dec 15, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts a previous change by removing the bringup: true flag from the Linux linux_fuchsia_tests target in the engine/src/flutter/.ci.yaml configuration file. This modification re-enables the test, making it a blocking check in the CI pipeline again.

Copy link
Member

@jtmcdole jtmcdole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

██╗      ██████╗████████╗███╗   ███╗
██║     ██╔════╝╚══██╔══╝████╗ ████║
██║     ██║  ███╗  ██║   ██╔████╔██║
██║     ██║   ██║  ██║   ██║╚██╔╝██║
███████╗╚██████╔╝  ██║   ██║ ╚═╝ ██║
╚══════╝ ╚═════╝   ╚═╝   ╚═╝     ╚═╝

@zijiehe-google-com zijiehe-google-com added this pull request to the merge queue Dec 16, 2025
Merged via the queue into master with commit d81baab Dec 16, 2025
183 of 184 checks passed
@zijiehe-google-com zijiehe-google-com deleted the revert-179744-fuchsia_flakes branch December 16, 2025 04:58
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 16, 2025
@jtmcdole
Copy link
Member

@zijiehe-google-com - next time please use the autosubmit label. The tree status check was red; the autosubmit bot would merge for you after that status was cleared.

@zijiehe-google-com
Copy link
Contributor Author

Oh, I thought "Merge when ready" was the updated version of "autosubmit" label. Thank you for pointing it out, John.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants