-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Revert "chore: linux fuchsia tests are flaking" #179897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit f96739c.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request reverts a previous change by removing the bringup: true flag from the Linux linux_fuchsia_tests target in the engine/src/flutter/.ci.yaml configuration file. This modification re-enables the test, making it a blocking check in the CI pipeline again.
jtmcdole
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
██╗ ██████╗████████╗███╗ ███╗
██║ ██╔════╝╚══██╔══╝████╗ ████║
██║ ██║ ███╗ ██║ ██╔████╔██║
██║ ██║ ██║ ██║ ██║╚██╔╝██║
███████╗╚██████╔╝ ██║ ██║ ╚═╝ ██║
╚══════╝ ╚═════╝ ╚═╝ ╚═╝ ╚═╝
|
@zijiehe-google-com - next time please use the |
|
Oh, I thought "Merge when ready" was the updated version of "autosubmit" label. Thank you for pointing it out, John. |
Reverts #179744
https://ci.chromium.org/ui/p/flutter/builders/staging/Linux%20linux_fuchsia_tests?limit=200
Fuchsia builder is green now, the disabled test is actively investigated by @caroqliu . We can move fuchsia back to prod to avoid unexpected breakages.