Skip to content

Conversation

@mboetger
Copy link
Contributor

Reverts #179698

Relands Content Sizing

Android Embedder implementation of content sizing.

Fixes: #149033

@github-actions github-actions bot added platform-android Android applications specifically engine flutter/engine related. See also e: labels. team-android Owned by Android platform team labels Dec 11, 2025
@mboetger mboetger marked this pull request as ready for review December 12, 2025 00:18
@mboetger mboetger requested a review from a team as a code owner December 12, 2025 00:18
@mboetger
Copy link
Contributor Author

After looking at it. The integration tests don't work with engine changes in the same PR - so it seems like they need to be a follow-on PR: #179772

@reidbaker
Copy link
Contributor

I think you can make engine changes and framework changes in the same pr. What I dont think you can do is add a ci target and run it in presubmit.

Maybe add the target in a parallel pr and make it always passing then modify it in this pr?

@mboetger
Copy link
Contributor Author

mboetger commented Dec 16, 2025

I think you can make engine changes and framework changes in the same pr. What I dont think you can do is add a ci target and run it in presubmit.

Maybe add the target in a parallel pr and make it always passing then modify it in this pr?

I made an integration test to check for the bug that was caused by the initial PR: #179902

However, this is not an add-to-app that actually checks to see if content sizing correctly works. That integration test is here: #179772

The way the flutter build is run, it does not necessarily use local engine changes (unless it's doing something in the background). I admit it wouldn't be a good test unless it actually did use local engine changes. That said, when I run it locally, it does not. Hopefully CI is smarter than that.

@mboetger
Copy link
Contributor Author

Confirmed that the new integration test passes:

00:02 �[32m+0�[0m: Should be able to hide and show platform view multiple times�[0m
D/ProfileInstaller( 7529): Installing profile for com.example.android_engine_test
Updating golden file: android_engine_test.opengles.hide_show_hide_platform_view.png (22918 bytes)...
Skia Gold comparison succeeded comparing "android_engine_test.opengles.hide_show_hide_platform_view.png".
00:05 �[32m+1�[0m: (tearDownAll)�[0m
00:05 �[32m+1�[0m: All tests passed!�[0m

@mboetger mboetger added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 17, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Dec 17, 2025
Merged via the queue into master with commit 103dfa6 Dec 17, 2025
186 checks passed
@auto-submit auto-submit bot deleted the revert-179698-revert-176063-android-impl-149033 branch December 17, 2025 23:05
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine flutter/engine related. See also e: labels. platform-android Android applications specifically team-android Owned by Android platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow an embedded Flutter View on Android to size itself

3 participants