-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Revert "Revert "Android implementation of content sizing"" #179753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Revert "Android implementation of content sizing"" #179753
Conversation
This reverts commit 86c12c1.
|
After looking at it. The integration tests don't work with engine changes in the same PR - so it seems like they need to be a follow-on PR: #179772 |
|
I think you can make engine changes and framework changes in the same pr. What I dont think you can do is add a ci target and run it in presubmit. Maybe add the target in a parallel pr and make it always passing then modify it in this pr? |
I made an integration test to check for the bug that was caused by the initial PR: #179902 However, this is not an add-to-app that actually checks to see if content sizing correctly works. That integration test is here: #179772 The way the |
|
Confirmed that the new integration test passes: |
Reverts #179698
Relands Content Sizing
Android Embedder implementation of content sizing.
Fixes: #149033