Revert "Android implementation of content sizing" #179698

mboetger · 2025-12-10T18:31:24Z

Git bisect:

❯ git bisect log
# bad: [5b74a3b8e8f8f94e887b64470d6eb793e4459930] Check for a null cached image in SingleFrameCodec::getNextFrame (#179483)
# good: [66dd93f9a27ffe2a9bfc8297506ce066ff51265f] Bump engine version for Flutter 3.38.4 stable hotfix. (#179424)
git bisect start 'master' 'flutter-3.38-candidate.0'
# good: [df87ee3db00df61d882f99e655a3dc5f8387f806] Roll Skia from d10a0d877ff4 to ea7cdbc6b986 (15 revisions) (#176686)
git bisect good df87ee3db00df61d882f99e655a3dc5f8387f806
# good: [951b25d2400a298f77a10e6a790905d045f62ddf] Check for devicectl launch logs from std and file (#178167)
git bisect good 951b25d2400a298f77a10e6a790905d045f62ddf
# good: [337bbfbe042a89c0a887c895fa3aa364decc7077] Potentially fixing the flakiness in win32 windowing tests, but it needs some running (#178499)
git bisect good 337bbfbe042a89c0a887c895fa3aa364decc7077
# good: [8e952d62976dfe77e54849e9e110e5ebb7ef7f71] Roll Skia from c20f797ab6f9 to 81a9a0751f00 (5 revisions) (#179417)
git bisect good 8e952d62976dfe77e54849e9e110e5ebb7ef7f71
# good: [723fec502fd9788c94fb039464ab9418b3ca9a3e] Roll Skia from e19670f70406 to dccd48c6c6ab (6 revisions) (#179524)
git bisect good 723fec502fd9788c94fb039464ab9418b3ca9a3e
# bad: [96c65251a604a3960a9186b3011a70ee6883148f] Roll Dart SDK from 3c07646cdcb9 to 019cb923bf62 (1 revision) (#179595)
git bisect bad 96c65251a604a3960a9186b3011a70ee6883148f
# good: [4000ce2b4e576e356ee0f8a3841bbb5e280cac2c] Implementation of `TestWindowingOwner` for testing multi-window (#179355)
git bisect good 4000ce2b4e576e356ee0f8a3841bbb5e280cac2c
# good: [26f311ca5e8519f31b10a2fca6f10b6eaa028e04] Roll Dart SDK from 75899721aa42 to 3c07646cdcb9 (1 revision) (#179587)
git bisect good 26f311ca5e8519f31b10a2fca6f10b6eaa028e04
# bad: [8cc9feed310df448d80798bfc710e950cdbba4a8] Roll Skia from b1936c760645 to 00e6fc407968 (5 revisions) (#179589)
git bisect bad 8cc9feed310df448d80798bfc710e950cdbba4a8
# bad: [b37b6fa92736083e8c24a56da8b4b3d326df1c31] Change GenerateFilledArcStrip to use non-overlapping triangles (#179292)
git bisect bad b37b6fa92736083e8c24a56da8b4b3d326df1c31
# bad: [f197a3a00ca9483435b8c04bb972fbcfa7737f25] Android implementation of content sizing (#176063)
git bisect bad f197a3a00ca9483435b8c04bb972fbcfa7737f25
# first bad commit: [f197a3a00ca9483435b8c04bb972fbcfa7737f25] Android implementation of content sizing (#176063)

This reverts commit f197a3a.

gemini-code-assist

Code Review

This pull request reverts the 'Android implementation of content sizing' feature. The changes remove code across multiple files in the Android embedding, including Java sources, C++ implementation, and build files. The FlutterMeasureSpec.java and FlutterUiResizeListener.java classes are removed, along with associated logic for handling content-based view sizing. Modifications in FlutterView, FlutterJNI, FlutterRenderer, and their native counterparts remove fields, methods, and JNI calls related to this feature. Test files are also updated to remove tests for the reverted functionality. The changes appear to fully revert the original commit.

auto-submit · 2025-12-10T19:35:30Z

autosubmit label was removed for flutter/flutter/179698, because - The status or check suite Linux linux_fuchsia_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

…flutter#179698)

This reverts commit 86c12c1.

…flutter#179698)

flutter/flutter@e25d71b...6e1aa82 2025-12-12 [email protected] Add documentation for what to do when bumping the minimum sdk version supported by flutter (flutter/flutter#179795) 2025-12-12 [email protected] Roll Skia from ee08571bbf67 to e66816c3645e (2 revisions) (flutter/flutter#179792) 2025-12-12 [email protected] Roll Packages from 36383d6 to 0ac7a03 (1 revision) (flutter/flutter#179793) 2025-12-12 [email protected] Roll Fuchsia Linux SDK from QssSL8DkxIbMvf89C... to fppT9ZrwbFx7iYrIh... (flutter/flutter#179785) 2025-12-12 [email protected] Roll Skia from 4251aa7454da to ee08571bbf67 (1 revision) (flutter/flutter#179783) 2025-12-12 [email protected] Roll Skia from 344ff9c41fb6 to 4251aa7454da (2 revisions) (flutter/flutter#179779) 2025-12-12 [email protected] Fix draggable scrollable sheet example drag speed is off (flutter/flutter#179179) 2025-12-12 [email protected] [ios][pv] accept/reject gesture based on hitTest (with new widget API) (flutter/flutter#179659) 2025-12-12 [email protected] Roll Skia from 7ad91f64b468 to 344ff9c41fb6 (1 revision) (flutter/flutter#179774) 2025-12-12 [email protected] [fuchsia] temporarily disable touch-input-test due to the flakiness (flutter/flutter#179747) 2025-12-12 [email protected] Roll Skia from 979b7ae09145 to 7ad91f64b468 (6 revisions) (flutter/flutter#179770) 2025-12-12 [email protected] Exit with code 1 when calling `flutter build` without arguments (flutter/flutter#175900) 2025-12-12 [email protected] [ Tool ] Assemble: "Improper" validation error when dealing with base64 encoded dart-define value (flutter/flutter#178737) 2025-12-12 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ Analysis ] Added initial implementation of the `flutter_analyzer_plugin` (#175679)" (flutter/flutter#179766) 2025-12-11 [email protected] Add 3.38.5 changelog (flutter/flutter#179750) 2025-12-11 [email protected] Roll Dart SDK from 3d4b989bdc41 to 9a65db770758 (2 revisions) (flutter/flutter#179746) 2025-12-11 [email protected] fix: fresh install of windows support (flutter/flutter#179720) 2025-12-11 [email protected] [ Analysis ] Added initial implementation of the `flutter_analyzer_plugin` (flutter/flutter#175679) 2025-12-11 [email protected] Roll Skia from d570e2317110 to 979b7ae09145 (4 revisions) (flutter/flutter#179742) 2025-12-11 [email protected] chore: linux fuchsia tests are flaking (flutter/flutter#179744) 2025-12-11 [email protected] Roll Packages from 74a5a53 to 36383d6 (4 revisions) (flutter/flutter#179740) 2025-12-11 [email protected] Revert "Android implementation of content sizing" (flutter/flutter#179698) 2025-12-11 [email protected] [skia] Disable legacy image decoders (flutter/flutter#179277) 2025-12-11 [email protected] Roll Skia from deb0153719dd to d570e2317110 (2 revisions) (flutter/flutter#179734) 2025-12-11 [email protected] Roll Dart SDK from dbcb567e2432 to 3d4b989bdc41 (1 revision) (flutter/flutter#179733) 2025-12-11 [email protected] Roll Fuchsia Linux SDK from u5vxWTRT0HlxOP5_r... to QssSL8DkxIbMvf89C... (flutter/flutter#179729) 2025-12-11 [email protected] Roll Skia from 59c6cad539f7 to deb0153719dd (2 revisions) (flutter/flutter#179721) 2025-12-11 [email protected] Roll Dart SDK from 077062c5e515 to dbcb567e2432 (2 revisions) (flutter/flutter#179715) 2025-12-11 [email protected] Use kPreventOverdraw for arcs with overlapping stroke caps (flutter/flutter#179312) 2025-12-11 [email protected] Roll Skia from e61cc6d073fd to 59c6cad539f7 (22 revisions) (flutter/flutter#179714) 2025-12-10 [email protected] Reland: Add framework-side hitTestBehavior support to Semantics (#178817) (flutter/flutter#179352) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Reverts #179698 Relands Content Sizing Android Embedder implementation of content sizing. Fixes: #149033

Revert "Android implementation of content sizing (#176063)"

4cbd008

This reverts commit f197a3a.

mboetger requested a review from a team as a code owner December 10, 2025 18:31

github-actions bot added platform-android Android applications specifically engine flutter/engine related. See also e: labels. team-android Owned by Android platform team labels Dec 10, 2025

reidbaker approved these changes Dec 10, 2025

View reviewed changes

gemini-code-assist bot reviewed Dec 10, 2025

View reviewed changes

gmackall approved these changes Dec 10, 2025

View reviewed changes

mboetger added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 10, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 10, 2025

mboetger added 2 commits December 10, 2025 12:26

Merge branch 'master' into revert-176063-android-impl-149033

48656c4

Merge branch 'master' into revert-176063-android-impl-149033

621a2aa

jmagman mentioned this pull request Dec 10, 2025

Allow an embedded Flutter View on Android to size itself #149033

Closed

mboetger added 2 commits December 10, 2025 17:08

Merge branch 'master' into revert-176063-android-impl-149033

52f4e95

Merge branch 'master' into revert-176063-android-impl-149033

db3556c

mboetger added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 11, 2025

auto-submit bot added this pull request to the merge queue Dec 11, 2025

Merged via the queue into master with commit 86c12c1 Dec 11, 2025
186 checks passed

auto-submit bot deleted the revert-176063-android-impl-149033 branch December 11, 2025 17:09

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 11, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2025

86c12c1ed Revert "Android implementation of content sizing" (flutter/…

69444e9

…flutter#179698)

engine-flutter-autoroll mentioned this pull request Dec 11, 2025

Roll Flutter from e25d71b086d6 to 86c12c1ed059 (10 revisions) flutter/packages#10603

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2025

86c12c1ed Revert "Android implementation of content sizing" (flutter/…

8925d3b

…flutter#179698)

engine-flutter-autoroll mentioned this pull request Dec 11, 2025

Roll Flutter from e25d71b086d6 to 96d5711f3dba (11 revisions) flutter/packages#10604

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2025

86c12c1ed Revert "Android implementation of content sizing" (flutter/…

bd0371f

…flutter#179698)

engine-flutter-autoroll mentioned this pull request Dec 11, 2025

Roll Flutter from e25d71b086d6 to f96739c63f90 (12 revisions) flutter/packages#10605

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2025

86c12c1ed Revert "Android implementation of content sizing" (flutter/…

8fed223

…flutter#179698)

engine-flutter-autoroll mentioned this pull request Dec 11, 2025

Roll Flutter from e25d71b086d6 to a4bb36f61d57 (13 revisions) flutter/packages#10606

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2025

86c12c1ed Revert "Android implementation of content sizing" (flutter/…

2b570c4

…flutter#179698)

engine-flutter-autoroll mentioned this pull request Dec 11, 2025

Roll Flutter from e25d71b086d6 to 5ec8a97c7d3e (14 revisions) flutter/packages#10607

Closed

mboetger added a commit that referenced this pull request Dec 11, 2025

Revert "Revert "Android implementation of content sizing" (#179698)"

6ec4b69

This reverts commit 86c12c1.

mboetger mentioned this pull request Dec 11, 2025

Revert "Revert "Android implementation of content sizing"" #179753

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2025

86c12c1ed Revert "Android implementation of content sizing" (flutter/…

c4eab2f

…flutter#179698)

engine-flutter-autoroll mentioned this pull request Dec 11, 2025

Manual roll Flutter from e25d71b086d6 to 6225f39dfe5c (16 revisions) flutter/packages#10609

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2025

86c12c1ed Revert "Android implementation of content sizing" (flutter/…

b0e286a

…flutter#179698)

engine-flutter-autoroll mentioned this pull request Dec 12, 2025

Roll Flutter from e25d71b086d6 to 77bd1b558e49 (28 revisions) flutter/packages#10611

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2025

86c12c1ed Revert "Android implementation of content sizing" (flutter/…

caaabb3

…flutter#179698)

engine-flutter-autoroll mentioned this pull request Dec 12, 2025

Roll Flutter from e25d71b086d6 to 61b5084e3b0e (29 revisions) flutter/packages#10613

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2025

86c12c1ed Revert "Android implementation of content sizing" (flutter/…

0b6925d

…flutter#179698)

engine-flutter-autoroll mentioned this pull request Dec 12, 2025

Roll Flutter from e25d71b086d6 to 2c6cd4a98de0 (30 revisions) flutter/packages#10614

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2025

86c12c1ed Revert "Android implementation of content sizing" (flutter/…

de896fc

…flutter#179698)

engine-flutter-autoroll mentioned this pull request Dec 12, 2025

Roll Flutter from e25d71b086d6 to 6e1aa823523d (31 revisions) flutter/packages#10615

Merged

github-merge-queue bot pushed a commit that referenced this pull request Dec 17, 2025

Revert "Revert "Android implementation of content sizing"" (#179753)

103dfa6

Reverts #179698 Relands Content Sizing Android Embedder implementation of content sizing. Fixes: #149033

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Revert "Android implementation of content sizing" #179698

Revert "Android implementation of content sizing" #179698

mboetger commented Dec 10, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

auto-submit bot commented Dec 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Revert "Android implementation of content sizing" #179698

Revert "Android implementation of content sizing" #179698

Conversation

mboetger commented Dec 10, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

auto-submit bot commented Dec 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants