Skip to content

Conversation

@eyebrowsoffire
Copy link
Contributor

No description provided.

@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@reidbaker reidbaker self-requested a review December 3, 2025 21:16
@reidbaker
Copy link
Contributor

Rslgtm

@eyebrowsoffire eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 3, 2025
@auto-submit auto-submit bot merged commit 66dd93f into flutter:flutter-3.38-candidate.0 Dec 3, 2025
5 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 4, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2025
github-merge-queue bot pushed a commit that referenced this pull request Dec 11, 2025
Reverts #176063

Fixes: #179667

Git bisect:
```
❯ git bisect log
# bad: [5b74a3b] Check for a null cached image in SingleFrameCodec::getNextFrame (#179483)
# good: [66dd93f] Bump engine version for Flutter 3.38.4 stable hotfix. (#179424)
git bisect start 'master' 'flutter-3.38-candidate.0'
# good: [df87ee3] Roll Skia from d10a0d877ff4 to ea7cdbc6b986 (15 revisions) (#176686)
git bisect good df87ee3
# good: [951b25d] Check for devicectl launch logs from std and file (#178167)
git bisect good 951b25d
# good: [337bbfb] Potentially fixing the flakiness in win32 windowing tests, but it needs some running (#178499)
git bisect good 337bbfb
# good: [8e952d6] Roll Skia from c20f797ab6f9 to 81a9a0751f00 (5 revisions) (#179417)
git bisect good 8e952d6
# good: [723fec5] Roll Skia from e19670f70406 to dccd48c6c6ab (6 revisions) (#179524)
git bisect good 723fec5
# bad: [96c6525] Roll Dart SDK from 3c07646cdcb9 to 019cb923bf62 (1 revision) (#179595)
git bisect bad 96c6525
# good: [4000ce2] Implementation of `TestWindowingOwner` for testing multi-window (#179355)
git bisect good 4000ce2
# good: [26f311c] Roll Dart SDK from 75899721aa42 to 3c07646cdcb9 (1 revision) (#179587)
git bisect good 26f311c
# bad: [8cc9fee] Roll Skia from b1936c760645 to 00e6fc407968 (5 revisions) (#179589)
git bisect bad 8cc9fee
# bad: [b37b6fa] Change GenerateFilledArcStrip to use non-overlapping triangles (#179292)
git bisect bad b37b6fa
# bad: [f197a3a] Android implementation of content sizing (#176063)
git bisect bad f197a3a
# first bad commit: [f197a3a] Android implementation of content sizing (#176063)
```
@eyebrowsoffire eyebrowsoffire deleted the enginebump-3.38.4 branch December 12, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants