Skip to content

Conversation

@fluttergithubbot
Copy link
Contributor

The issue #173337 has been closed, and the test has been passing for 50 consecutive runs.
This test can be marked as unflaky.

@flutter-dashboard flutter-dashboard bot added c: flake Tests that sometimes, but not always, incorrectly pass c: tech-debt Technical debt, code quality, testing, etc. labels Dec 3, 2025
@github-actions github-actions bot removed the c: tech-debt Technical debt, code quality, testing, etc. label Dec 3, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the bringup: true flag for the Linux_pixel_7pro new_gallery_opengles_impeller__transition_perf test in .ci.yaml. This change marks the test as stable, re-enabling it as a standard test in CI. The change is consistent with the process for handling previously flaky tests that have been fixed and validated.

@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 3, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Dec 3, 2025
Merged via the queue into flutter:master with commit 69d8710 Dec 3, 2025
151 of 152 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 3, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 3, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Dec 3, 2025
flutter/flutter@e274574...69d8710

2025-12-03 [email protected] Marks Linux_pixel_7pro new_gallery_opengles_impeller__transition_perf to be unflaky (flutter/flutter#179389)
2025-12-03 [email protected] Roll Fuchsia Linux SDK from l0DvmZrMHlF12frrX... to VtDPX2k1kosHxjKUE... (flutter/flutter#179408)
2025-12-03 [email protected] Marks Linux_pixel_7pro hello_world_impeller to be unflaky (flutter/flutter#179388)
2025-12-03 [email protected] Roll Packages from 148dcd2 to 8cb4903 (3 revisions) (flutter/flutter#179407)
2025-12-03 [email protected] Roll Skia from db4c79d41513 to c20f797ab6f9 (1 revision) (flutter/flutter#179403)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
reidbaker pushed a commit to AbdeMohlbi/flutter that referenced this pull request Dec 10, 2025
… to be unflaky (flutter#179389)

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_pixel_7pro
new_gallery_opengles_impeller__transition_perf"
}
-->
The issue flutter#173337 has been
closed, and the test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_pixel_7pro%20new_gallery_opengles_impeller__transition_perf%22).
This test can be marked as unflaky.

Co-authored-by: gaaclarke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: flake Tests that sometimes, but not always, incorrectly pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants