-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Marks Linux_pixel_7pro hello_world_impeller to be unflaky #179388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request marks the Linux_pixel_7pro hello_world_impeller test as no longer flaky by removing the bringup: true flag in the .ci.yaml configuration file. This change means that failures in this test will now be considered blocking for post-submit CI.
gaaclarke
approved these changes
Dec 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 3, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Dec 3, 2025
flutter/flutter@e274574...69d8710 2025-12-03 [email protected] Marks Linux_pixel_7pro new_gallery_opengles_impeller__transition_perf to be unflaky (flutter/flutter#179389) 2025-12-03 [email protected] Roll Fuchsia Linux SDK from l0DvmZrMHlF12frrX... to VtDPX2k1kosHxjKUE... (flutter/flutter#179408) 2025-12-03 [email protected] Marks Linux_pixel_7pro hello_world_impeller to be unflaky (flutter/flutter#179388) 2025-12-03 [email protected] Roll Packages from 148dcd2 to 8cb4903 (3 revisions) (flutter/flutter#179407) 2025-12-03 [email protected] Roll Skia from db4c79d41513 to c20f797ab6f9 (1 revision) (flutter/flutter#179403) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
…9388) <!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Linux_pixel_7pro hello_world_impeller" } --> The issue flutter#173698 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_pixel_7pro%20hello_world_impeller%22). This test can be marked as unflaky.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue #173698 has been closed, and the test has been passing for 50 consecutive runs.
This test can be marked as unflaky.