Skip to content

Conversation

@jesswrd
Copy link
Contributor

@jesswrd jesswrd commented Dec 1, 2025

We have confirmed that the screenshot tests failing on the 36 emulator successfully passes when using the latest emulator from Android Studio (36.1). However, the tests in CI are not passing when we test against an internal chromium provided emulator (and not the emulator provided by Android Studio). We hypothesize the previous failure could be because Flutter is depending on a next-gen renderer but the avd version we were testing against did not depend on the next-gen renderer.

We found an internal avd build version here where the next-gen Android renderer IS being used.

Using the AVD https://chrome-infra-packages.appspot.com/p/chromium/tools/android/avd/linux-amd64/+/okfRuASrBt9uNu5KYv7JXmEYJ76SXbWE5SMwMzvA2dMC from the comment here.

Partially Addresses #163071
Partially Addresses #170024

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@jesswrd jesswrd marked this pull request as ready for review December 1, 2025 22:43
@jesswrd jesswrd requested a review from reidbaker December 1, 2025 22:44
@jesswrd
Copy link
Contributor Author

jesswrd commented Dec 1, 2025

It looks like that emulator we want to experiment testing against (by updating emu_unstable) does not exist at the path we have been previously using chromium/tools/android/avd/linux-amd64 here.

The emulator we want to experiment testing against exists at this other path chromium/third_party/android_sdk/public/avds/android-36/google_apis/x86_64 here. I am unsure how to specify this new path. Probably requires a recipe change.

Edit: Ah the code that controls how Flutter launches avd is: https://source.corp.google.com/h/flutter/codesearch/+/main:recipes/recipe_modules/android_virtual_device/api.py
specifically this line here.

@jesswrd jesswrd added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 4, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Dec 5, 2025
Merged via the queue into flutter:master with commit e5ffd42 Dec 5, 2025
152 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Dec 5, 2025
Roll Flutter from 69d8710fadcd to 5b8720312a94 (42 revisions)

flutter/flutter@69d8710...5b87203

2025-12-05 [email protected] Roll Packages from d39e481 to b17d3ff (3 revisions) (flutter/flutter#179505)
2025-12-05 [email protected] Move target_cpu into use_rbe block in Fuchsia build (flutter/flutter#179458)
2025-12-05 [email protected] Roll Skia from fe6bf18a3f6b to a31411879251 (3 revisions) (flutter/flutter#179499)
2025-12-05 [email protected] Force WASM single threading in Chrome extensions. (flutter/flutter#179400)
2025-12-05 [email protected] Roll Skia from aea282ea0bcd to fe6bf18a3f6b (7 revisions) (flutter/flutter#179489)
2025-12-05 [email protected] fix: check both pointer count and action before reusing MotionEvent (flutter/flutter#178528)
2025-12-05 [email protected] Roll Fuchsia Linux SDK from VtDPX2k1kosHxjKUE... to vDeTl_KBeLJY8nCAx... (flutter/flutter#179478)
2025-12-05 [email protected] [ Widget Preview ] Add embedded Widget Inspector support (flutter/flutter#178116)
2025-12-05 [email protected] bubble up fragment shader errors (flutter/flutter#179363)
2025-12-05 [email protected] Roll Dart SDK from eda82318e193 to 42fe3327abca (1 revision) (flutter/flutter#179472)
2025-12-05 [email protected] [Android 16] Use AVD With New Android Renderer (flutter/flutter#179306)
2025-12-05 [email protected] Unpin `package:dwds` dependency (flutter/flutter#179462)
2025-12-05 [email protected] [Impeller] include uniform info in impellerc json reflections (flutter/flutter#179317)
2025-12-05 [email protected] Roll Skia from 1591b066f49b to aea282ea0bcd (1 revision) (flutter/flutter#179468)
2025-12-04 [email protected] Roll Skia from e1923478562b to 1591b066f49b (3 revisions) (flutter/flutter#179460)
2025-12-04 [email protected] Cherry-pick flutter 3.38.4 changelog back to master. (flutter/flutter#179463)
2025-12-04 [email protected] [web] Add clone method to LayerPicture and dispose pictures in PictureLayer (flutter/flutter#179162)
2025-12-04 [email protected] Fixes merge conflict from high bitrate texture tests (flutter/flutter#179416)
2025-12-04 [email protected] Fix typos in `VirtualDisplayController.java` (flutter/flutter#179411)
2025-12-04 [email protected] Roll Dart SDK from 2de44cc08970 to eda82318e193 (1 revision) (flutter/flutter#179453)
2025-12-04 [email protected] Roll Skia from 55d94a54f453 to e1923478562b (1 revision) (flutter/flutter#179449)
2025-12-04 [email protected] Roll Packages from 8cb4903 to d39e481 (8 revisions) (flutter/flutter#179451)
2025-12-04 [email protected] Add DropdownMenu.selectOnly (flutter/flutter#179189)
2025-12-04 [email protected] Roll Dart SDK from 7e6bfc6af55c to 2de44cc08970 (6 revisions) (flutter/flutter#179443)
2025-12-04 [email protected] Roll Skia from b8f79d7316c0 to 55d94a54f453 (1 revision) (flutter/flutter#179439)
2025-12-04 [email protected] Revise README for link updates and terminology changes (flutter/flutter#179357)
2025-12-04 [email protected] Roll Skia from ce19122e3982 to b8f79d7316c0 (3 revisions) (flutter/flutter#179436)
2025-12-04 [email protected] Update some BottomNavigationBar comments to reflect theme normalization (flutter/flutter#179404)
2025-12-04 [email protected] Replace use of eglCreateImage with eglCreateImageKHR to reduce EGL requirement (flutter/flutter#179310)
2025-12-04 [email protected] Roll Skia from 81a9a0751f00 to ce19122e3982 (5 revisions) (flutter/flutter#179430)
2025-12-04 [email protected] [impellerc] adds entry prefix flag to avoid shader collisions (flutter/flutter#179160)
2025-12-04 [email protected] [Windows] Allow apps to prefer high power GPUs (flutter/flutter#177653)
2025-12-04 [email protected] [ Infra ] Shard `Windows tool_tests_commands` (flutter/flutter#179409)
2025-12-04 [email protected] [flutter_tools] Fix filename typo (flutter/flutter#179427)
2025-12-04 [email protected] Marks Linux_pixel_7pro draw_arcs_all_stroke_styles_perf__timeline_summary to be unflaky (flutter/flutter#179392)
2025-12-03 [email protected] Marks Mac_ios draw_arcs_all_fill_styles_perf_ios__timeline_summary to be unflaky (flutter/flutter#179391)
2025-12-03 [email protected] Marks Linux_pixel_7pro draw_arcs_all_fill_styles_perf__timeline_summary to be unflaky (flutter/flutter#179390)
2025-12-03 [email protected] Roll Abseil to 564023aa5376 (flutter/flutter#179421)
2025-12-03 [email protected] Made wide gamut tests give more information in their failure (flutter/flutter#179415)
2025-12-03 [email protected] Roll Skia from c20f797ab6f9 to 81a9a0751f00 (5 revisions) (flutter/flutter#179417)
2025-12-03 [email protected] Migrate samples and docs to RadioGroup (flutter/flutter#179158)
2025-12-03 [email protected] Roll Dart SDK to 3.11.0-200.1.beta (flutter/flutter#179399)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
...
reidbaker pushed a commit to AbdeMohlbi/flutter that referenced this pull request Dec 10, 2025
We have confirmed that the [screenshot
tests](flutter#170024 (comment))
failing on the 36 emulator successfully passes when using the latest
emulator from Android Studio (36.1). However, the tests in CI are not
passing when we test against an internal chromium provided emulator (and
not the emulator provided by Android Studio). We hypothesize the
previous failure could be because Flutter is depending on a next-gen
renderer but the avd version we were testing against did not depend on
the next-gen renderer.

We found an internal avd build version
[here](https://issuetracker.google.com/issues/425720132?pli=1#:~:text=are%20created%20in-,https%3A//ci.chromium.org/b/8702355247321119617,-Also%20switch%20GPU)
where the next-gen Android renderer IS being used.

Using the AVD
https://chrome-infra-packages.appspot.com/p/chromium/tools/android/avd/linux-amd64/+/okfRuASrBt9uNu5KYv7JXmEYJ76SXbWE5SMwMzvA2dMC
from the comment
[here](flutter#170024 (comment)).



Partially Addresses flutter#163071
Partially Addresses flutter#170024

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants