[CP-stable][ Widget Preview ] Ignore changes under ios/.symlinks
#179300
Conversation
This directory should have been filtered as part of the fix for flutter#178317 Fixes flutter#179008
|
@bkonyi please fill out the PR description above, afterwards the release team will review this request. |
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
github-actions
bot
added
the
tool
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is a cherry-pick to ignore changes under ios/.symlinks. The change correctly adds the directory to the list of ephemeral directories, and a related test is updated with a comment to improve traceability. The changes are correct and ready to be merged.
eyebrowsoffire
added
the
autosubmit
auto-submit
bot
merged commit b8f3374
into
flutter:flutter-3.38-candidate.0
3 participants
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
What is the link to the issue this cherry-pick is addressing?
#179008
Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See best practices for examples
flutter pub getcould be spawned multiple times on MacOS whenpubspec.yamls outside of the project were modified after aflutter pub getin the root project.Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
The widget previewer's file watcher can detect
pubspec.yamlchanges within plugin packages that are reachable via a symlink. This can cause numerousflutter pub getrequests to be issued that aren't necessary and can possibly cause a user's machine to hang.Workaround:
Is there a workaround for this issue?
No.
Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
What are the steps to validate that this fix works?
flutter widget-preview starton a Macflutter pub getand verify that dozens of Dart processes aren't spawned