[CP-stable][ Tool ] Remove --no-sandbox when launching web apps on Chrome device #179192
Conversation
|
@bkonyi please fill out the PR description above, afterwards the release team will review this request. |
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
github-actions
bot
added
the
tool
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly removes the --no-sandbox flag from default Chrome launch arguments, restricting it to headless mode only. This is a welcome security enhancement, as it avoids disabling the Chrome sandbox for regular headed browser launches during development. The tests have been updated appropriately to account for this change by explicitly adding the flag where necessary. The changes are clear, correct, and improve the tool's security posture.
eyebrowsoffire
added
the
autosubmit
auto-submit
bot
merged commit bfd0db6
into
flutter:flutter-3.38-candidate.0
…apps on Chrome device (flutter/flutter#179192)
…apps on Chrome device (flutter/flutter#179192)
3 participants
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
What is the link to the issue this cherry-pick is addressing?
#175227
Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See best practices for examples
Flutter Web applications launched in Chrome show a warning related to
--no-sandbox.Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
We were incorrectly disabling the Chrome sandbox for non-test contexts, which results in a ominous warning about "Stability and security [suffering]".
Workaround:
Is there a workaround for this issue?
N/A
Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
What are the steps to validate that this fix works?
Run
flutter run -d chrome, verify the launched Chrome instance doesn't have a warning banner.