Fix draggable scrollable sheet example drag speed is off #179179
Merged
+139
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
huycozy
force-pushed
the
fix-DraggableScrollableSheet-example-drag-speed-is-off-179102
branch
from
e22bc67 to
5622cd3
Compare
examples/api/lib/widgets/draggable_scrollable_sheet/draggable_scrollable_sheet.0.dart
Outdated
Show resolved
Hide resolved
examples/api/lib/widgets/draggable_scrollable_sheet/draggable_scrollable_sheet.0.dart
Outdated
Show resolved
Hide resolved
huycozy
force-pushed
the
fix-DraggableScrollableSheet-example-drag-speed-is-off-179102
branch
3 times, most recently
from
ef5ed23 to
beea989
Compare
examples/api/lib/widgets/draggable_scrollable_sheet/draggable_scrollable_sheet.0.dart
Show resolved
Hide resolved
huycozy
requested review from
chunhtai and
dkwingsmt
and removed request for
dkwingsmt
chunhtai
reviewed
Dec 8, 2025
Contributor
chunhtai
left a comment
chunhtai
left a comment
There was a problem hiding this comment.
Can you add a test for this example?
examples/api/lib/widgets/draggable_scrollable_sheet/draggable_scrollable_sheet.0.dart
Outdated
Show resolved
Hide resolved
examples/api/lib/widgets/draggable_scrollable_sheet/draggable_scrollable_sheet.0.dart
Outdated
Show resolved
Hide resolved
examples/api/lib/widgets/draggable_scrollable_sheet/draggable_scrollable_sheet.0.dart
Outdated
Show resolved
Hide resolved
Member
Author
|
Thank you for reviewing this, @chunhtai. I added some tests for this fix. |
Signed-off-by: huycozy <[email protected]>
…ntion Signed-off-by: huycozy <[email protected]>
Signed-off-by: huycozy <[email protected]>
screen height Signed-off-by: huycozy <[email protected]> Signed-off-by: huycozy <[email protected]>
huycozy
force-pushed
the
fix-DraggableScrollableSheet-example-drag-speed-is-off-179102
branch
from
3bb963e to
c2d0756
Compare
chunhtai
approved these changes
Dec 9, 2025
Contributor
chunhtai
left a comment
chunhtai
left a comment
There was a problem hiding this comment.
just minor comment otherwise LGTM
examples/api/lib/widgets/draggable_scrollable_sheet/draggable_scrollable_sheet.0.dart
Outdated
Show resolved
Hide resolved
Signed-off-by: huycozy <[email protected]> Signed-off-by: huycozy <[email protected]>
huycozy
force-pushed
the
fix-DraggableScrollableSheet-example-drag-speed-is-off-179102
branch
from
c2d0756 to
1c515ba
Compare
huycozy
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
huycozy
deleted the
fix-DraggableScrollableSheet-example-drag-speed-is-off-179102
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Dec 12, 2025
flutter/flutter@e25d71b...6e1aa82 2025-12-12 [email protected] Add documentation for what to do when bumping the minimum sdk version supported by flutter (flutter/flutter#179795) 2025-12-12 [email protected] Roll Skia from ee08571bbf67 to e66816c3645e (2 revisions) (flutter/flutter#179792) 2025-12-12 [email protected] Roll Packages from 36383d6 to 0ac7a03 (1 revision) (flutter/flutter#179793) 2025-12-12 [email protected] Roll Fuchsia Linux SDK from QssSL8DkxIbMvf89C... to fppT9ZrwbFx7iYrIh... (flutter/flutter#179785) 2025-12-12 [email protected] Roll Skia from 4251aa7454da to ee08571bbf67 (1 revision) (flutter/flutter#179783) 2025-12-12 [email protected] Roll Skia from 344ff9c41fb6 to 4251aa7454da (2 revisions) (flutter/flutter#179779) 2025-12-12 [email protected] Fix draggable scrollable sheet example drag speed is off (flutter/flutter#179179) 2025-12-12 [email protected] [ios][pv] accept/reject gesture based on hitTest (with new widget API) (flutter/flutter#179659) 2025-12-12 [email protected] Roll Skia from 7ad91f64b468 to 344ff9c41fb6 (1 revision) (flutter/flutter#179774) 2025-12-12 [email protected] [fuchsia] temporarily disable touch-input-test due to the flakiness (flutter/flutter#179747) 2025-12-12 [email protected] Roll Skia from 979b7ae09145 to 7ad91f64b468 (6 revisions) (flutter/flutter#179770) 2025-12-12 [email protected] Exit with code 1 when calling `flutter build` without arguments (flutter/flutter#175900) 2025-12-12 [email protected] [ Tool ] Assemble: "Improper" validation error when dealing with base64 encoded dart-define value (flutter/flutter#178737) 2025-12-12 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ Analysis ] Added initial implementation of the `flutter_analyzer_plugin` (#175679)" (flutter/flutter#179766) 2025-12-11 [email protected] Add 3.38.5 changelog (flutter/flutter#179750) 2025-12-11 [email protected] Roll Dart SDK from 3d4b989bdc41 to 9a65db770758 (2 revisions) (flutter/flutter#179746) 2025-12-11 [email protected] fix: fresh install of windows support (flutter/flutter#179720) 2025-12-11 [email protected] [ Analysis ] Added initial implementation of the `flutter_analyzer_plugin` (flutter/flutter#175679) 2025-12-11 [email protected] Roll Skia from d570e2317110 to 979b7ae09145 (4 revisions) (flutter/flutter#179742) 2025-12-11 [email protected] chore: linux fuchsia tests are flaking (flutter/flutter#179744) 2025-12-11 [email protected] Roll Packages from 74a5a53 to 36383d6 (4 revisions) (flutter/flutter#179740) 2025-12-11 [email protected] Revert "Android implementation of content sizing" (flutter/flutter#179698) 2025-12-11 [email protected] [skia] Disable legacy image decoders (flutter/flutter#179277) 2025-12-11 [email protected] Roll Skia from deb0153719dd to d570e2317110 (2 revisions) (flutter/flutter#179734) 2025-12-11 [email protected] Roll Dart SDK from dbcb567e2432 to 3d4b989bdc41 (1 revision) (flutter/flutter#179733) 2025-12-11 [email protected] Roll Fuchsia Linux SDK from u5vxWTRT0HlxOP5_r... to QssSL8DkxIbMvf89C... (flutter/flutter#179729) 2025-12-11 [email protected] Roll Skia from 59c6cad539f7 to deb0153719dd (2 revisions) (flutter/flutter#179721) 2025-12-11 [email protected] Roll Dart SDK from 077062c5e515 to dbcb567e2432 (2 revisions) (flutter/flutter#179715) 2025-12-11 [email protected] Use kPreventOverdraw for arcs with overlapping stroke caps (flutter/flutter#179312) 2025-12-11 [email protected] Roll Skia from e61cc6d073fd to 59c6cad539f7 (22 revisions) (flutter/flutter#179714) 2025-12-10 [email protected] Reland: Add framework-side hitTestBehavior support to Semantics (#178817) (flutter/flutter#179352) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_isOnDesktopAndWebout of Grabber, so it's easier to see Grabber widget purpose when reading the codeDemo
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.