Make sure that a CupertinoListTile doesn't crash in 0x0 environment #179109
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a regression test to ensure that CupertinoListTile does not crash when rendered in a zero-sized environment, addressing a previously reported issue. The added test is well-structured and correctly simulates the problematic scenario. I have suggested a minor enhancement to the test to more closely match the conditions of the original bug report, which involved a leading widget.
| await tester.pumpWidget( | ||
| const CupertinoApp( | ||
| home: Center( | ||
| child: SizedBox.shrink(child: CupertinoListTile(title: Text('X'))), |
Contributor
There was a problem hiding this comment.
This is a good regression test. To better cover the scenario described in the original issue, which was related to calculations involving the leading widget, I suggest also testing the case where a leading widget is present. This will make the test more robust against future regressions related to this part of the layout logic.
Suggested change
| child: SizedBox.shrink(child: CupertinoListTile(title: Text('X'))), | |
| child: SizedBox.shrink(child: CupertinoListTile(title: Text('X'), leading: Icon(CupertinoIcons.add))), |
victorsanni
approved these changes
Nov 26, 2025
victorsanni
approved these changes
Dec 2, 2025
| const CupertinoApp( | ||
| home: Center( | ||
| child: SizedBox.shrink( | ||
| child: CupertinoListTile(title: Text('X'), trailing: CupertinoListTileChevron()), |
Contributor
There was a problem hiding this comment.
I think it puts the chevron in by default? My request was we should expect that the chevron is correctly shrunk.
Contributor
Author
There was a problem hiding this comment.
Do you want me to assert that the size of the CupertinoListTileChevron is zero here?
Contributor
There was a problem hiding this comment.
I think this test is fine since we only want to verify that ListTile has size zero.
dkwingsmt
approved these changes
Dec 5, 2025
Contributor
dkwingsmt
left a comment
dkwingsmt
left a comment
There was a problem hiding this comment.
Checklist:
- The test is in the correct file
- The test name goes “does not crash at zero area”
- The target widget is wrapped by
Center(or is fullscreen) - The target widget does not have an overlay, or the overlay is tested
- The target widget is expected to have a size of exactly
Size.zero
| const CupertinoApp( | ||
| home: Center( | ||
| child: SizedBox.shrink( | ||
| child: CupertinoListTile(title: Text('X'), trailing: CupertinoListTileChevron()), |
Contributor
There was a problem hiding this comment.
I think this test is fine since we only want to verify that ListTile has size zero.
dkwingsmt
added
the
autosubmit
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
flutter-dashboard
bot
removed
the
autosubmit
victorsanni
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 9, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 9, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 9, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 9, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 9, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 9, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 10, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 10, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 10, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 10, 2025
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
…lutter#179109) This is my attempt to handle flutter#6537 for the CupertinoListTile widget. --------- Co-authored-by: Tong Mu <[email protected]>
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Dec 10, 2025
…10593) Manual roll requested by [email protected] flutter/flutter@b2de367...6a1f5b7 2025-12-09 [email protected] Fix - Semantics focus does not move outside viewport when moving up or down (flutter/flutter#179480) 2025-12-09 [email protected] Make sure that a CupertinoActionSheetAction doesn't crash in 0x0 envi… (flutter/flutter#178955) 2025-12-09 [email protected] Make sure that a CupertinoPickerDefaultSelectionOverlay doesn't crash… (flutter/flutter#179351) 2025-12-09 [email protected] Make sure that a CupertinoExpansionTile doesn't crash in 0x0 environment (flutter/flutter#178978) 2025-12-09 [email protected] Roll Packages from 33a9a81 to 338ecd3 (5 revisions) (flutter/flutter#179625) 2025-12-09 [email protected] [skia] Update SkSerialProcs to use new type (flutter/flutter#179347) 2025-12-09 [email protected] Roll Skia from 895fa7417947 to 502ee6f2a0d7 (4 revisions) (flutter/flutter#179617) 2025-12-09 [email protected] Roll Skia from 9f276dfa0bdc to 895fa7417947 (1 revision) (flutter/flutter#179608) 2025-12-09 [email protected] Remove unused optional argument in _followDiagnosticableChain (flutter/flutter#179525) 2025-12-08 [email protected] Roll Dart SDK from 3c07646cdcb9 to 019cb923bf62 (1 revision) (flutter/flutter#179595) 2025-12-08 [email protected] Marks Linux_mokey flutter_engine_group_performance to be flaky (flutter/flutter#179115) 2025-12-08 [email protected] Roll Skia from 00e6fc407968 to 9f276dfa0bdc (3 revisions) (flutter/flutter#179594) 2025-12-08 [email protected] Marks Mac_arm64_mokey run_release_test to be flaky (flutter/flutter#177372) 2025-12-08 [email protected] Roll Skia from b1936c760645 to 00e6fc407968 (5 revisions) (flutter/flutter#179589) 2025-12-08 [email protected] MatrixUtils.forceToPoint - simplify and optimize (flutter/flutter#179546) 2025-12-08 [email protected] Change GenerateFilledArcStrip to use non-overlapping triangles (flutter/flutter#179292) 2025-12-08 [email protected] Android implementation of content sizing (flutter/flutter#176063) 2025-12-08 [email protected] Roll Dart SDK from 75899721aa42 to 3c07646cdcb9 (1 revision) (flutter/flutter#179587) 2025-12-08 [email protected] Redistribute TESTOWNERS for Android team (flutter/flutter#179464) 2025-12-08 [email protected] Make sure that a CupertinoListTile doesn't crash in 0x0 environment (flutter/flutter#179109) 2025-12-08 [email protected] Make sure that a CupertinoFocusHalo doesn't crash in 0x0 environment (flutter/flutter#178773) 2025-12-08 [email protected] Make sure that a CupertinoPopupSurface doesn't crash in 0x0 environment (flutter/flutter#178929) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to handle #6537 for the CupertinoListTile widget.