Skip to content

[native assets] Bump minimum iOS version from 12 to 13 #179079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Nov 27, 2025
Merged

[native assets] Bump minimum iOS version from 12 to 13 #179079

auto-submit merged 2 commits into from
Nov 27, 2025

Conversation

@dcharkes
Copy link
Contributor

@dcharkes dcharkes commented Nov 25, 2025

We don't have a single place to update the minimum iOS version in the code base:

So, when the minimum version was bumped, one place was missed.

Thanks for reporting @tnarik! (#148504 (comment))

@dcharkes dcharkes requested a review from goderbauer November 25, 2025 14:12
@dcharkes dcharkes requested a review from a team as a code owner November 25, 2025 14:12
@flutter-dashboard
Copy link

flutter-dashboard bot commented Nov 25, 2025

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. team-ios Owned by iOS platform team labels Nov 25, 2025
@dcharkes dcharkes requested a review from vashworth November 25, 2025 14:12
gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 25, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly bumps the minimum iOS version for native assets from 12 to 13. It updates the targetIOSVersion constant and refactors a hardcoded version string to use this constant, improving maintainability. While the change itself is correct, it appears to break an integration test which was not updated. Please see the specific comment for details.

packages/flutter_tools/lib/src/isolated/native_assets/ios/native_assets.dart

// TODO(dcharkes): Fetch minimum iOS version from somewhere. https://github.com/flutter/flutter/issues/145104
const targetIOSVersion = 12;
const targetIOSVersion = 13;
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change is correct, but it will cause the expectDylibIsBundledIos test in packages/flutter_tools/test/integration.shard/isolated/native_assets_test.dart to fail. The test still asserts that MinimumOSVersion is 12.0.

Please update the test to expect 13.0 to ensure the CI passes. The relevant change in packages/flutter_tools/test/integration.shard/isolated/native_assets_test.dart would be:

- 	<string>12.0</string>
+ 	<string>13.0</string>

@dcharkes dcharkes mentioned this pull request Nov 25, 2025
Merged
9 tasks
goderbauer
goderbauer approved these changes Nov 25, 2025
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcharkes dcharkes added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 25, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Nov 26, 2025
Merged via the queue into master with commit 4e250ad Nov 27, 2025
146 of 147 checks passed
@auto-submit auto-submit bot deleted the ios-min-version branch November 27, 2025 01:41
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 27, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 27, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 27, 2025
@engine-flutter-autoroll
4e250ad4b [native assets] Bump minimum iOS version from 12 to 13 (flu…
ed4f0e1 
…tter/flutter#179079)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Nov 27, 2025
@engine-flutter-autoroll
Roll Flutter from 7b98d50631e5 to 022b155d1b76 (20 revisions) (#10530)
c8be05d 
flutter/flutter@7b98d50...022b155

2025-11-27 [email protected] Make tree green again by fixing lints (flutter/flutter#179186)
2025-11-26 [email protected] Add shared Darwin implementation for plugins (flutter/flutter#176495)
2025-11-26 [email protected] Fixed changing supportedLocales fails to update the locale (flutter/flutter#178526)
2025-11-26 [email protected] [ Tool ] Remove --no-sandbox when launching web apps on Chrome device (flutter/flutter#178670)
2025-11-26 [email protected] Build hooks: Don't require toolchain for unit tests (flutter/flutter#178954)
2025-11-26 [email protected] Fix a small typo in `HandlerCompat.java` docs (flutter/flutter#178595)
2025-11-26 [email protected] Roll Fuchsia Linux SDK from nzuAxCJGeJbkZCTkr... to _e9MNK4nfBOrERVP_... (flutter/flutter#179130)
2025-11-26 [email protected] Make sure that a CupertinoActivityIndicator doesn't crash in 0x0 envi… (flutter/flutter#178565)
2025-11-26 [email protected] [native assets] Bump minimum iOS version from 12 to 13 (flutter/flutter#179079)
2025-11-26 [email protected] Documents and fixes behavior when clipping background filter fragment shader (flutter/flutter#178940)
2025-11-26 [email protected] Replace the hardcoded link with an actual link tag in `PlatformChannel.java‎` docs (flutter/flutter#178588)
2025-11-26 [email protected] Roll Packages from cc3dca6 to 5d8d954 (5 revisions) (flutter/flutter#179140)
2025-11-26 [email protected] Add more templates that the UIScene migrator can match against (flutter/flutter#179044)
2025-11-26 [email protected] Remove deprecated activeColor in `dynamic_content_color.0.dart`‎ example (flutter/flutter#178961)
2025-11-26 [email protected] Remove deprecated `activeColor` in `decorated_sliver.1.dart‎` example (flutter/flutter#178959)
2025-11-26 [email protected] Small refactor in `PlayStoreDeferredComponentManager.java‎` (flutter/flutter#178586)
2025-11-26 [email protected] Roll Dart SDK from 9e605f706cdf to 1d8dc04bd1d7 (4 revisions) (flutter/flutter#179080)
2025-11-26 [email protected] Fix error when generating pt_BR localizations (flutter/flutter#175832)
2025-11-26 [email protected] Roll Fuchsia Test Scripts from JUeFbA8y0E-_pj-bg... to MHF-UAfO6sVKqSEYk... (flutter/flutter#179151)
2025-11-26 [email protected] Add flutter_lints to samples (flutter/flutter#179091)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger pushed a commit to mboetger/flutter that referenced this pull request Dec 2, 2025
@dcharkes @mboetger
[native assets] Bump minimum iOS version from 12 to 13 (flutter#179079)
d7c7281 
We don't have a single place to update the minimum iOS version in the
code base:

* flutter#145104

So, when the minimum version was bumped, one place was missed.

Thanks for reporting @tnarik!
(flutter#148504 (comment))
reidbaker pushed a commit to AbdeMohlbi/flutter that referenced this pull request Dec 10, 2025
@dcharkes @reidbaker
[native assets] Bump minimum iOS version from 12 to 13 (flutter#179079)
eb0c73f 
We don't have a single place to update the minimum iOS version in the
code base:

* flutter#145104

So, when the minimum version was bumped, one place was missed.

Thanks for reporting @tnarik!
(flutter#148504 (comment))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

@vashworth vashworth vashworth approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

team-ios Owned by iOS platform team tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dcharkes @goderbauer @vashworth