Update some comments to reflect theme normalization #179013
Merged
+29
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates comments across AppBar, Banner, and BottomAppBar to reflect theme normalization, which is a great improvement for documentation clarity. The changes are mostly correct, but I've found one comment in app_bar.dart that seems to incorrectly describe the property's behavior. I've left a suggestion to correct it. Otherwise, the changes look good.
bleroux
force-pushed
the
update_AppBar_Banner_BottomAppBar_documentation_for_theme_normalization
branch
from
0c8b988 to
21c989b
Compare
bleroux
force-pushed
the
update_AppBar_Banner_BottomAppBar_documentation_for_theme_normalization
branch
from
21c989b to
5ca868a
Compare
QuncCccccc
approved these changes
Dec 1, 2025
Contributor
QuncCccccc
left a comment
QuncCccccc
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the improvement:)
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 2, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 2, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 2, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Dec 2, 2025
flutter/flutter@05d6005...5545bb3 2025-12-02 [email protected] Roll Skia from 4371ed0ce49e to 45337c4e919d (1 revision) (flutter/flutter#179342) 2025-12-02 [email protected] Roll Fuchsia Linux SDK from sTk6OB7a4yudbfdZg... to l0DvmZrMHlF12frrX... (flutter/flutter#179338) 2025-12-02 [email protected] Unfocus search anchor bar when the view is closed (flutter/flutter#178910) 2025-12-02 [email protected] Directly generate a Mach-O dynamic library using gen_snapshot. [reland] (flutter/flutter#174870) 2025-12-02 [email protected] Roll Skia from 1fc59bf5cbb1 to 4371ed0ce49e (3 revisions) (flutter/flutter#179326) 2025-12-02 [email protected] [win32] Replace threadpool timer with custom background thread timer (flutter/flutter#179249) 2025-12-02 [email protected] Roll Skia from 61257a1036fb to 1fc59bf5cbb1 (1 revision) (flutter/flutter#179321) 2025-12-02 [email protected] Roll Skia from ef52cf952211 to 61257a1036fb (2 revisions) (flutter/flutter#179319) 2025-12-02 [email protected] Roll Skia from 8887653a773e to ef52cf952211 (1 revision) (flutter/flutter#179316) 2025-12-02 [email protected] Roll pub packages (flutter/flutter#179313) 2025-12-02 [email protected] Update customer tests (flutter/flutter#179309) 2025-12-01 [email protected] Marks Linux_pixel_7pro new_gallery__transition_perf to be unflaky (flutter/flutter#176339) 2025-12-01 [email protected] Fix typo (flutter/flutter#179200) 2025-12-01 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 5.0.1 to 6.0.0 in the all-github-actions group (flutter/flutter#179308) 2025-12-01 [email protected] Roll Dart SDK from c54108eeb2c1 to eb743a1d4ade (1 revision) (flutter/flutter#179304) 2025-12-01 [email protected] Roll pub packages (flutter/flutter#179280) 2025-12-01 [email protected] Roll Skia from 68cc3257e734 to 8887653a773e (4 revisions) (flutter/flutter#179302) 2025-12-01 [email protected] Support round caps for the fast arc stroke generator (flutter/flutter#178269) 2025-12-01 [email protected] Fix for PR #174374 - Fix - TalkBack does not announce list information (flutter/flutter#177622) 2025-12-01 [email protected] Small cleanup in `AccessibilityBridge.java` (flutter/flutter#179226) 2025-12-01 [email protected] Roll Skia from 925c311f4b37 to 68cc3257e734 (44 revisions) (flutter/flutter#179294) 2025-12-01 [email protected] [ Widget Preview ] Ignore changes under `ios/.symlinks` (flutter/flutter#179290) 2025-12-01 [email protected] Delete unecessary lockfile (flutter/flutter#179052) 2025-12-01 [email protected] Resolving and piping the view ID through the WidgetController and the TestPointer so that clicks wind up on the right view (flutter/flutter#178941) 2025-12-01 [email protected] Fix link specified as plain text `FlutterApplication.java` (flutter/flutter#178573) 2025-12-01 [email protected] Update some comments to reflect theme normalization (flutter/flutter#179013) 2025-12-01 [email protected] Roll Dart SDK from 51fe8cd01fbe to c54108eeb2c1 (1 revision) (flutter/flutter#179267) 2025-12-01 [email protected] Explicitly use FreeType font scanner with Fuchsia (flutter/flutter#179055) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Dec 2, 2025
## Description This PR updates some comments in AppBar, Banner and BottomAppBar to reflect the changes related to Theme normalization. ## Related Issue Related to flutter#91772 ## Tests - Documentation only
bleroux
deleted the
update_AppBar_Banner_BottomAppBar_documentation_for_theme_normalization
branch
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
## Description This PR updates some comments in AppBar, Banner and BottomAppBar to reflect the changes related to Theme normalization. ## Related Issue Related to flutter#91772 ## Tests - Documentation only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates some comments in AppBar, Banner and BottomAppBar to reflect the changes related to Theme normalization.
Related Issue
Related to #91772
Tests