Skip to content

Conversation

@flar
Copy link
Contributor

@flar flar commented Nov 22, 2025

Reverts #177410

The change is causing the task wide_gamut_ios to hang every time. Local testing shows that reverting this commit fixes the problem.

@flar flar requested a review from a team as a code owner November 22, 2025 08:46
@github-actions github-actions bot added platform-ios iOS applications specifically engine flutter/engine related. See also e: labels. team-ios Owned by iOS platform team labels Nov 22, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts the "[ios] Dynamic Content Resizing" change, which was causing a test task to hang. The revert is comprehensive, removing the feature's implementation from the engine, along with associated test code, example applications, and project file configurations. The changes consist entirely of removals and reversions to restore the codebase to its state before the problematic change was introduced. The revert appears to be clean and complete, with no leftover artifacts or new issues introduced.

@flar flar added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 22, 2025
@jtmcdole jtmcdole added the emergency Jump the queue; land PR in front of all others; only use for emergencies label Nov 22, 2025
@flutter-dashboard
Copy link

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

@jtmcdole
Copy link
Member

Added emergency label since this was not a RevertBot revert.

@auto-submit auto-submit bot added this pull request to the merge queue Nov 22, 2025
Merged via the queue into master with commit c8cfb2b Nov 22, 2025
187 of 188 checks passed
@auto-submit auto-submit bot deleted the revert-177410-ios-resizing-final branch November 22, 2025 16:12
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 22, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 22, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Nov 22, 2025
flutter/flutter@d438df3...c8cfb2b

2025-11-22 [email protected] Revert "[ios] Dynamic Content Resizing" (flutter/flutter#178958)
2025-11-22 [email protected] Make sure that a SearchAnchor doesn't crash in 0x0 environment (flutter/flutter#177749)
2025-11-22 [email protected] Make sure that a Stepper doesn't crash in 0x0 environment (flutter/flutter#178068)
2025-11-22 [email protected] Remove deprecated `activeColor` in `switch.0.dart` example (flutter/flutter#178293)
2025-11-22 [email protected] Make sure that a UserAccountsDrawerHeader doesn't crash in 0x0 enviro… (flutter/flutter#178516)
2025-11-22 [email protected] Make sure that a TimePickerDialog doesn't crash in 0x0 environment (flutter/flutter#178451)
2025-11-22 [email protected] Make sure that a CupertinoLinearActivityIndicator doesn't crash in 0x… (flutter/flutter#178566)
2025-11-22 [email protected] Make sure that a CupertinoTabBar doesn't crash in 0x0 environment (flutter/flutter#178613)
2025-11-22 [email protected] Make sure that a CupertinoContextMenu doesn't crash in 0x0 environment (flutter/flutter#178722)
2025-11-22 [email protected] Sort entries in TESTOWNERS (flutter/flutter#178939)
2025-11-22 [email protected] [ios] Dynamic Content Resizing (flutter/flutter#177410)
2025-11-21 [email protected] Roll Skia from dc88b21ce7d2 to 3018c3053490 (2 revisions) (flutter/flutter#178947)
2025-11-21 [email protected] Manually roll material_color_utilities (flutter/flutter#170000)
2025-11-21 [email protected] Roll Fuchsia Linux SDK from Y-cMdgKy3d6EnibWR... to 4ul9jvZ7jnDGIjtCD... (flutter/flutter#178934)
2025-11-21 [email protected] Roll Dart SDK from c788b6a7aefd to 5af71c736b0a (1 revision) (flutter/flutter#178932)
2025-11-21 [email protected] Roll Skia from c588bb60d5da to dc88b21ce7d2 (2 revisions) (flutter/flutter#178933)
2025-11-21 [email protected] Update .ci.yaml and TESTOWNERS for arc macrobenchmark tests (flutter/flutter#178891)
2025-11-21 [email protected] Use interactive mode with `devicectl` to redirect stdout (flutter/flutter#178405)
2025-11-21 [email protected] Update .ci.yaml in flutter/flutter to use either macOS 15.5 or macOS … (flutter/flutter#178666)
2025-11-21 [email protected] Roll Skia from d4e9d2873bfd to c588bb60d5da (1 revision) (flutter/flutter#178928)
2025-11-21 [email protected] Roll Packages from b1e2fb0 to e67b6be (7 revisions) (flutter/flutter#178927)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger pushed a commit to mboetger/flutter that referenced this pull request Dec 2, 2025
Reverts flutter#177410

The change is causing the task `wide_gamut_ios` to hang every time.
Local testing shows that reverting this commit fixes the problem.
reidbaker pushed a commit to AbdeMohlbi/flutter that referenced this pull request Dec 10, 2025
Reverts flutter#177410

The change is causing the task `wide_gamut_ios` to hang every time.
Local testing shows that reverting this commit fixes the problem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

emergency Jump the queue; land PR in front of all others; only use for emergencies engine flutter/engine related. See also e: labels. platform-ios iOS applications specifically team-ios Owned by iOS platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants