Update .ci.yaml and TESTOWNERS for arc macrobenchmark tests #178891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds CI configuration in .ci.yaml and ownership information in TESTOWNERS for new arc macrobenchmark performance tests. The changes correctly add the new test targets. My review includes suggestions to improve maintainability by reducing duplication in the YAML configuration and by sorting the new entries in the TESTOWNERS file.
Comment on lines
3556
to
3591
| - name: Linux_pixel_7pro draw_arcs_all_fill_styles_perf__timeline_summary | ||
| recipe: devicelab/devicelab_drone | ||
| presubmit: false | ||
| timeout: 60 | ||
| properties: | ||
| tags: > | ||
| ["devicelab", "android", "linux", "pixel", "7pro"] | ||
| task_name: draw_arcs_all_fill_styles_perf__timeline_summary | ||
|
|
||
| - name: Mac_ios draw_arcs_all_fill_styles_perf_ios__timeline_summary | ||
| recipe: devicelab/devicelab_drone | ||
| presubmit: false | ||
| timeout: 60 | ||
| properties: | ||
| tags: > | ||
| ["devicelab", "ios", "mac"] | ||
| task_name: draw_arcs_all_fill_styles_perf_ios__timeline_summary | ||
|
|
||
| - name: Linux_pixel_7pro draw_arcs_all_stroke_styles_perf__timeline_summary | ||
| recipe: devicelab/devicelab_drone | ||
| presubmit: false | ||
| timeout: 60 | ||
| properties: | ||
| tags: > | ||
| ["devicelab", "android", "linux", "pixel", "7pro"] | ||
| task_name: draw_arcs_all_stroke_styles_perf__timeline_summary | ||
|
|
||
| - name: Mac_ios draw_arcs_all_stroke_styles_perf_ios__timeline_summary | ||
| recipe: devicelab/devicelab_drone | ||
| presubmit: false | ||
| timeout: 60 | ||
| properties: | ||
| tags: > | ||
| ["devicelab", "ios", "mac"] | ||
| task_name: draw_arcs_all_stroke_styles_perf_ios__timeline_summary | ||
|
|
Contributor
There was a problem hiding this comment.
There is significant duplication across these four new test targets. To improve maintainability and adhere to the 'Avoid duplicating state' principle from the style guide1, consider using YAML anchors and aliases to define common properties. This would make the configuration cleaner and easier to manage in the future.
Style Guide References
Footnotes
-
The style guide recommends avoiding duplication. Using YAML anchors for repeated configuration blocks would align with this principle. ↩
Comment on lines
+117
to
+118
| /dev/devicelab/bin/tasks/draw_arcs_all_fill_styles_perf__timeline_summary.dart @b-luk @flutter/engine | ||
| /dev/devicelab/bin/tasks/draw_arcs_all_stroke_styles_perf__timeline_summary.dart @b-luk @flutter/engine |
Contributor
There was a problem hiding this comment.
For better maintainability and consistency, please keep test owner entries sorted alphabetically within each section. These new entries should be placed after line 114 (...complex_layout_scroll_perf_impeller_gles__timeline_summary.dart). While I see other entries are also out of order, it would be good to place new entries correctly.
Comment on lines
+239
to
+240
| /dev/devicelab/bin/tasks/draw_arcs_all_fill_styles_perf_ios__timeline_summary.dart @b-luk @flutter/engine | ||
| /dev/devicelab/bin/tasks/draw_arcs_all_stroke_styles_perf_ios__timeline_summary.dart @b-luk @flutter/engine |
Contributor
There was a problem hiding this comment.
For better maintainability and consistency, please keep test owner entries sorted alphabetically within each section. These new entries should be placed before line 236 (...static_path_stroke_tessellation_perf_ios__timeline_summary.dart).
flar
approved these changes
Nov 21, 2025
Contributor
flar
left a comment
flar
left a comment
There was a problem hiding this comment.
I think the alphabetical suggestion from the bot makes sense. I don't know that we've embraced the de-duplication suggestion in that file, though, yet...
Contributor
Author
|
I think alphabetizing would be good. But the file isn't currently sorted, so I can't alphabetize these new entries without reordering the entire file. I think that's out of scope of this PR. I'll file a new issue about this. |
flutter-dashboard
bot
removed
the
autosubmit
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 22, 2025
Sorting these entries was suggested by the gemini-code-assist bot in another PR which modified the TESTOWNERS file: #178891 (see comments at #178891 (comment) and #178891 (comment)) This is a follow-up PR to perform the sorting. We don't want to do it in the PR where it was suggested #178891 because sorting the entries is out of scope of that PR's goal.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 22, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 22, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Nov 22, 2025
flutter/flutter@d438df3...c8cfb2b 2025-11-22 [email protected] Revert "[ios] Dynamic Content Resizing" (flutter/flutter#178958) 2025-11-22 [email protected] Make sure that a SearchAnchor doesn't crash in 0x0 environment (flutter/flutter#177749) 2025-11-22 [email protected] Make sure that a Stepper doesn't crash in 0x0 environment (flutter/flutter#178068) 2025-11-22 [email protected] Remove deprecated `activeColor` in `switch.0.dart` example (flutter/flutter#178293) 2025-11-22 [email protected] Make sure that a UserAccountsDrawerHeader doesn't crash in 0x0 enviro… (flutter/flutter#178516) 2025-11-22 [email protected] Make sure that a TimePickerDialog doesn't crash in 0x0 environment (flutter/flutter#178451) 2025-11-22 [email protected] Make sure that a CupertinoLinearActivityIndicator doesn't crash in 0x… (flutter/flutter#178566) 2025-11-22 [email protected] Make sure that a CupertinoTabBar doesn't crash in 0x0 environment (flutter/flutter#178613) 2025-11-22 [email protected] Make sure that a CupertinoContextMenu doesn't crash in 0x0 environment (flutter/flutter#178722) 2025-11-22 [email protected] Sort entries in TESTOWNERS (flutter/flutter#178939) 2025-11-22 [email protected] [ios] Dynamic Content Resizing (flutter/flutter#177410) 2025-11-21 [email protected] Roll Skia from dc88b21ce7d2 to 3018c3053490 (2 revisions) (flutter/flutter#178947) 2025-11-21 [email protected] Manually roll material_color_utilities (flutter/flutter#170000) 2025-11-21 [email protected] Roll Fuchsia Linux SDK from Y-cMdgKy3d6EnibWR... to 4ul9jvZ7jnDGIjtCD... (flutter/flutter#178934) 2025-11-21 [email protected] Roll Dart SDK from c788b6a7aefd to 5af71c736b0a (1 revision) (flutter/flutter#178932) 2025-11-21 [email protected] Roll Skia from c588bb60d5da to dc88b21ce7d2 (2 revisions) (flutter/flutter#178933) 2025-11-21 [email protected] Update .ci.yaml and TESTOWNERS for arc macrobenchmark tests (flutter/flutter#178891) 2025-11-21 [email protected] Use interactive mode with `devicectl` to redirect stdout (flutter/flutter#178405) 2025-11-21 [email protected] Update .ci.yaml in flutter/flutter to use either macOS 15.5 or macOS … (flutter/flutter#178666) 2025-11-21 [email protected] Roll Skia from d4e9d2873bfd to c588bb60d5da (1 revision) (flutter/flutter#178928) 2025-11-21 [email protected] Roll Packages from b1e2fb0 to e67b6be (7 revisions) (flutter/flutter#178927) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Dec 2, 2025
…178891) The benchmarks were added in flutter#178690, but that PR didn't update the .ci.yaml and TESTOWNERS files.
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Dec 2, 2025
Sorting these entries was suggested by the gemini-code-assist bot in another PR which modified the TESTOWNERS file: flutter#178891 (see comments at flutter#178891 (comment) and flutter#178891 (comment)) This is a follow-up PR to perform the sorting. We don't want to do it in the PR where it was suggested flutter#178891 because sorting the entries is out of scope of that PR's goal.
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
…178891) The benchmarks were added in flutter#178690, but that PR didn't update the .ci.yaml and TESTOWNERS files.
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
Sorting these entries was suggested by the gemini-code-assist bot in another PR which modified the TESTOWNERS file: flutter#178891 (see comments at flutter#178891 (comment) and flutter#178891 (comment)) This is a follow-up PR to perform the sorting. We don't want to do it in the PR where it was suggested flutter#178891 because sorting the entries is out of scope of that PR's goal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The benchmarks were added in #178690, but that PR didn't update the .ci.yaml and TESTOWNERS files.