Add framework-side hitTestBehavior support to Semantics #178817

flutter-zl · 2025-11-19T18:28:12Z

This is a reland of #177570, which was reverted in #178744 due to test failures.

The original PR introduced hitTestBehavior to the semantics framework but incorrectly applied opaque behavior to ModalRoute, which blocked platform views from receiving pointer events.

Instead of making the entire modal opaque, we:

Keep ModalRoute without explicit hitTestBehavior (defaults to defer)
Make only the dialog/sheet content opaque (blocks clicks to barrier)
Platform views remain clickable because they're outside the opaque content boundary

Fixes #149001
Original PR: #177570
Revert: #178744

gemini-code-assist

Code Review

This pull request introduces hitTestBehavior to the semantics framework, allowing finer control over hit testing for accessibility. The changes correctly apply this new property to modal widgets like BottomSheet and Dialog to make them opaque, and to platform views to make them transparent, fixing a regression from a previous attempt. Overall, the implementation is solid, but I've identified two critical issues in the property merging logic in semantics.dart that could lead to incorrect behavior when merging semantic nodes. The provided fixes should ensure that the hitTestBehavior of the top-most widget correctly takes precedence.

packages/flutter/lib/src/semantics/semantics.dart

Address Gemini Code Assistant feedback: Make hitTestBehavior merging consistent with role and inputType by implementing 'first non-defer wins' pattern in getSemanticsData(). The absorb() method already uses the correct pattern, so only getSemanticsData() needed to be fixed.

Fix compilation errors by adding required hitTestBehavior parameter to all 6 SemanticsData constructor calls in matchers_test.dart. This was missing from the original PR flutter#177570 changes.

Fix 'Dropdown menu includes semantics' test to match the actual semantics tree where the modal scope and barrier are siblings (not parent-child) due to the removal of hitTestBehavior.opaque from ModalRoute.

chunhtai · 2025-11-19T19:56:59Z

packages/flutter/lib/src/material/dialog.dart


    return Semantics(
      role: semanticsRole,
+      hitTestBehavior: SemanticsHitTestBehavior.opaque,


instead of doing this on the dialog widget, should we do it in the DialogRoute instead? it is possible that someone don't use Dialog widget to create content to be sent to showDialog method

Great suggestion. Updated.

chunhtai · 2025-11-19T19:58:33Z

packages/flutter/lib/src/material/bottom_sheet.dart

          namesRoute: true,
          label: routeLabel,
          explicitChildNodes: true,
+          hitTestBehavior: SemanticsHitTestBehavior.opaque,


same here, I think we should add this to the showBottonSheet and showModalBottomSheet

Great suggestion. Updated.

chunhtai

LGTM

…utter/flutter#178817)

Piinks · 2025-11-25T22:37:59Z

Reverting as this was manually merged during a tree closure.

auto-submit · 2025-11-25T22:38:22Z

A reason for requesting a revert of flutter/flutter/178817 could
not be found or the reason was not properly formatted. Begin a comment with 'Reason for revert:' to tell the bot why
this issue is being reverted.

Piinks · 2025-11-25T22:46:43Z

Reason for revert: change was landed during tree closure

)" This reverts commit 8f3f89f.

chingjun · 2025-11-25T22:59:15Z

Also this PR was merged while Google Testing was still failing. Can you fix the failing tests before attempting to reland this PR? Thanks.

…8817)" (#179100)  Reverts: #178817   Initiated by: Piinks   Reason for reverting: change was landed during tree closure   Original PR Author: flutter-zl   Reviewed By: {chunhtai}   This change reverts the following previous change: This is a reland of #177570, which was reverted in #178744 due to test failures. The original PR introduced `hitTestBehavior` to the semantics framework but incorrectly applied `opaque` behavior to `ModalRoute`, which blocked platform views from receiving pointer events. Instead of making the entire modal opaque, we: 1. Keep `ModalRoute` without explicit `hitTestBehavior` (defaults to `defer`) 2. Make only the dialog/sheet content opaque (blocks clicks to barrier) 3. Platform views remain clickable because they're outside the opaque content boundary Fixes #149001 Original PR: #177570 Revert: #178744  Co-authored-by: auto-submit[bot] <[email protected]>

…utter/flutter#178817)

flutter/flutter@3f553f6...7b98d50 2025-11-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix for win32 embedder failing to send all alt key downs to the flutter app (#179097)" (flutter/flutter#179136) 2025-11-26 [email protected] Fix for win32 embedder failing to send all alt key downs to the flutter app (flutter/flutter#179097) 2025-11-26 [email protected] Modernize framework lints (flutter/flutter#179089) 2025-11-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add framework-side hitTestBehavior support to Semantics (#178817)" (flutter/flutter#179100) 2025-11-25 [email protected] Add framework-side hitTestBehavior support to Semantics (flutter/flutter#178817) 2025-11-25 [email protected] Roll Packages from e019cf9 to cc3dca6 (1 revision) (flutter/flutter#179081) 2025-11-25 [email protected] Add tooltip windows to the windowing API alongside the window positioning logic (flutter/flutter#177404) 2025-11-25 [email protected] FlutterWindowsView::SendWindowMetrics now reliably sends the display_id (flutter/flutter#179053) 2025-11-25 [email protected] Remove semantics geometry shortcircuit (flutter/flutter#178680) 2025-11-25 [email protected] Add an assert message when OverlayEntry.remove is called twice (flutter/flutter#178163) 2025-11-25 [email protected] Roll Fuchsia Linux SDK from pOO9Jl9HTLsEmks6y... to nzuAxCJGeJbkZCTkr... (flutter/flutter#179066) 2025-11-25 [email protected] Dynamically set MinimumOSVersion in App.framework (flutter/flutter#178253) 2025-11-25 [email protected] Roll Skia from d83c30b090f4 to 925c311f4b37 (2 revisions) (flutter/flutter#179060) 2025-11-25 [email protected] Marks Linux build_android_host_app_with_module_aar to be unflaky (flutter/flutter#174864) 2025-11-25 [email protected] Marks Linux_mokey complex_layout__start_up to be unflaky (flutter/flutter#174865) 2025-11-25 [email protected] Manual Dart SDK roll to 3.11.0-169.0.dev (flutter/flutter#179054) 2025-11-25 [email protected] Bump Dart to 3.9 (flutter/flutter#179041) 2025-11-25 [email protected] Roll Skia from e298c2f93ebf to d83c30b090f4 (2 revisions) (flutter/flutter#179058) 2025-11-24 [email protected] updated licenses_cpp readme (flutter/flutter#178874) 2025-11-24 [email protected] Roll Skia from 43d2020be565 to e298c2f93ebf (5 revisions) (flutter/flutter#179046) 2025-11-24 [email protected] Refactor `_isLabel` method in `stepper.dart` to use `any` for better readablity (flutter/flutter#178909) 2025-11-24 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 5 to 6 in the all-github-actions group (flutter/flutter#179049) 2025-11-24 [email protected] Disposes test restoration manager when accessed by bindings (flutter/flutter#176519) 2025-11-24 [email protected] [ Widget Preview ] Always generate scaffold under `$TMP` (flutter/flutter#179039) 2025-11-24 [email protected] Roll Packages from e67b6be to e019cf9 (9 revisions) (flutter/flutter#179035) 2025-11-24 [email protected] Update CHANGELOG.md for Flutter 3.38.3 (flutter/flutter#178935) 2025-11-24 [email protected] Remove unnecessary `String.valueOf` in `SettingsChannel.java‎` (flutter/flutter#178590) 2025-11-24 [email protected] Roll pub manually, pick up flutter_lints in examples/api (flutter/flutter#179030) 2025-11-24 [email protected] Roll Dart SDK from 24cc9a740bd3 to afca43095efa (1 revision) (flutter/flutter#179019) 2025-11-24 [email protected] Pass EXCLUDED_ARCHS from Xcode project to xcodebuild for macOS builds (flutter/flutter#176948) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

This is a reland of flutter#177570, which was reverted in flutter#178744 due to test failures. The original PR introduced `hitTestBehavior` to the semantics framework but incorrectly applied `opaque` behavior to `ModalRoute`, which blocked platform views from receiving pointer events. Instead of making the entire modal opaque, we: 1. Keep `ModalRoute` without explicit `hitTestBehavior` (defaults to `defer`) 2. Make only the dialog/sheet content opaque (blocks clicks to barrier) 3. Platform views remain clickable because they're outside the opaque content boundary Fixes flutter#149001 Original PR: flutter#177570 Revert: flutter#178744

…tter#178817)" (flutter#179100)  Reverts: flutter#178817   Initiated by: Piinks   Reason for reverting: change was landed during tree closure   Original PR Author: flutter-zl   Reviewed By: {chunhtai}   This change reverts the following previous change: This is a reland of flutter#177570, which was reverted in flutter#178744 due to test failures. The original PR introduced `hitTestBehavior` to the semantics framework but incorrectly applied `opaque` behavior to `ModalRoute`, which blocked platform views from receiving pointer events. Instead of making the entire modal opaque, we: 1. Keep `ModalRoute` without explicit `hitTestBehavior` (defaults to `defer`) 2. Make only the dialog/sheet content opaque (blocks clicks to barrier) 3. Platform views remain clickable because they're outside the opaque content boundary Fixes flutter#149001 Original PR: flutter#177570 Revert: flutter#178744  Co-authored-by: auto-submit[bot] <[email protected]>

This is a reland of flutter#177570, which was reverted in flutter#178744 due to test failures. The original PR introduced `hitTestBehavior` to the semantics framework but incorrectly applied `opaque` behavior to `ModalRoute`, which blocked platform views from receiving pointer events. Instead of making the entire modal opaque, we: 1. Keep `ModalRoute` without explicit `hitTestBehavior` (defaults to `defer`) 2. Make only the dialog/sheet content opaque (blocks clicks to barrier) 3. Platform views remain clickable because they're outside the opaque content boundary Fixes flutter#149001 Original PR: flutter#177570 Revert: flutter#178744

…tter#178817)" (flutter#179100)  Reverts: flutter#178817   Initiated by: Piinks   Reason for reverting: change was landed during tree closure   Original PR Author: flutter-zl   Reviewed By: {chunhtai}   This change reverts the following previous change: This is a reland of flutter#177570, which was reverted in flutter#178744 due to test failures. The original PR introduced `hitTestBehavior` to the semantics framework but incorrectly applied `opaque` behavior to `ModalRoute`, which blocked platform views from receiving pointer events. Instead of making the entire modal opaque, we: 1. Keep `ModalRoute` without explicit `hitTestBehavior` (defaults to `defer`) 2. Make only the dialog/sheet content opaque (blocks clicks to barrier) 3. Platform views remain clickable because they're outside the opaque content boundary Fixes flutter#149001 Original PR: flutter#177570 Revert: flutter#178744  Co-authored-by: auto-submit[bot] <[email protected]>

) (#179352) This is a reland of #178817, which was reverted in #179100 due to test failures. The original PR introduced `hitTestBehavior` to the semantics framework but incorrectly applied `opaque` behavior to `ModalRoute`, which blocked platform views from receiving pointer events. Instead of making the entire modal opaque, we: 1. Keep `ModalRoute` without explicit `hitTestBehavior` (defaults to `defer`) 2. Make only the dialog/sheet content opaque (blocks clicks to barrier) 3. Platform views remain clickable because they're outside the opaque content boundary Fixes #149001 Original PR: #177570 Revert: #178744

…ter#178817) (flutter#179352) This is a reland of flutter#178817, which was reverted in flutter#179100 due to test failures. The original PR introduced `hitTestBehavior` to the semantics framework but incorrectly applied `opaque` behavior to `ModalRoute`, which blocked platform views from receiving pointer events. Instead of making the entire modal opaque, we: 1. Keep `ModalRoute` without explicit `hitTestBehavior` (defaults to `defer`) 2. Make only the dialog/sheet content opaque (blocks clicks to barrier) 3. Platform views remain clickable because they're outside the opaque content boundary Fixes flutter#149001 Original PR: flutter#177570 Revert: flutter#178744

Add framework-side hitTestBehavior support to Semantics

8dbe4b3

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: routes Navigator, Router, and related APIs. labels Nov 19, 2025

gemini-code-assist bot reviewed Nov 19, 2025

View reviewed changes

packages/flutter/lib/src/semantics/semantics.dart Outdated Show resolved Hide resolved

packages/flutter/lib/src/semantics/semantics.dart Show resolved Hide resolved

flutter-zl added 2 commits November 19, 2025 10:46

Add missing hitTestBehavior parameter to matchers_test.dart

60ed35f

Fix compilation errors by adding required hitTestBehavior parameter to all 6 SemanticsData constructor calls in matchers_test.dart. This was missing from the original PR flutter#177570 changes.

github-actions bot added the a: tests "flutter test", flutter_test, or one of our tests label Nov 19, 2025

dkwingsmt requested a review from chunhtai November 19, 2025 19:32

flutter-zl removed the request for review from chunhtai November 19, 2025 19:36

Update dropdown_test.dart for new semantics tree structure

66a51f6

Fix 'Dropdown menu includes semantics' test to match the actual semantics tree where the modal scope and barrier are siblings (not parent-child) due to the removal of hitTestBehavior.opaque from ModalRoute.

chunhtai reviewed Nov 19, 2025

View reviewed changes

flutter-zl added 5 commits November 19, 2025 14:27

Move hitTestBehavior.opaque from widgets to routes

cf02b73

fix analyzer issue

4f99788

Fix bottom sheet semantics tests for route-level wrapper

7da1974

format

1d9df18

formatting

657e221

flutter-zl requested a review from chunhtai November 20, 2025 18:20

chunhtai approved these changes Nov 24, 2025

View reviewed changes

flutter-zl added this pull request to the merge queue Nov 25, 2025

Merged via the queue into flutter:master with commit 8f3f89f Nov 25, 2025
67 of 69 checks passed

flutter-zl deleted the dialog_1027_clean branch November 25, 2025 18:46

engine-flutter-autoroll mentioned this pull request Nov 25, 2025

Roll Flutter from 3f553f6779cb to 8f3f89f75e8c (26 revisions) flutter/packages#10519

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 25, 2025

8f3f89f75 Add framework-side hitTestBehavior support to Semantics (fl…

97d840d

…utter/flutter#178817)

Piinks added the revert Autorevert PR (with "Reason for revert:" comment) label Nov 25, 2025

auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Nov 25, 2025

Piinks added the revert Autorevert PR (with "Reason for revert:" comment) label Nov 25, 2025

auto-submit bot pushed a commit that referenced this pull request Nov 25, 2025

Revert "Add framework-side hitTestBehavior support to Semantics (#178817

2975efa

)" This reverts commit 8f3f89f.

auto-submit bot mentioned this pull request Nov 25, 2025

Reverts "Add framework-side hitTestBehavior support to Semantics (#178817)" #179100

Merged

auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Nov 25, 2025

engine-flutter-autoroll mentioned this pull request Nov 26, 2025

Roll Flutter from 3f553f6779cb to fde117b7b144 (29 revisions) flutter/packages#10522

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 26, 2025

8f3f89f75 Add framework-side hitTestBehavior support to Semantics (fl…

f9e3e3a

…utter/flutter#178817)

engine-flutter-autoroll mentioned this pull request Nov 26, 2025

Roll Flutter from 3f553f6779cb to 7b98d50631e5 (30 revisions) flutter/packages#10523

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 26, 2025

8f3f89f75 Add framework-side hitTestBehavior support to Semantics (fl…

e81c134

…utter/flutter#178817)

flutter-zl mentioned this pull request Dec 2, 2025

Reland: Add framework-side hitTestBehavior support to Semantics (#178817) #179352

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add framework-side hitTestBehavior support to Semantics #178817

Add framework-side hitTestBehavior support to Semantics #178817

Uh oh!

flutter-zl commented Nov 19, 2025 •

edited

Loading

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

chunhtai Nov 19, 2025

Uh oh!

flutter-zl Nov 19, 2025

Uh oh!

chunhtai Nov 19, 2025

Uh oh!

flutter-zl Nov 19, 2025

Uh oh!

chunhtai left a comment

Uh oh!

Uh oh!

Piinks commented Nov 25, 2025

Uh oh!

auto-submit bot commented Nov 25, 2025

Uh oh!

Piinks commented Nov 25, 2025

Uh oh!

chingjun commented Nov 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Add framework-side hitTestBehavior support to Semantics #178817

Add framework-side hitTestBehavior support to Semantics #178817

Uh oh!

Conversation

flutter-zl commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

chunhtai Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

flutter-zl Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

chunhtai Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

flutter-zl Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Piinks commented Nov 25, 2025

Uh oh!

auto-submit bot commented Nov 25, 2025

Uh oh!

Piinks commented Nov 25, 2025

Uh oh!

chingjun commented Nov 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

flutter-zl commented Nov 19, 2025 •

edited

Loading