Skip to content

Refactor PreviewDetector initialization parameters #178745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Nov 18, 2025
Merged

Refactor PreviewDetector initialization parameters #178745

auto-submit merged 1 commit into from
Nov 18, 2025

Conversation

@reidbaker
Copy link
Contributor

@reidbaker reidbaker commented Nov 18, 2025 •
edited
Loading

@reidbaker reidbaker requested a review from bkonyi November 18, 2025 17:49
@flutter-dashboard
Copy link

flutter-dashboard bot commented Nov 18, 2025

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 18, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 18, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the initialization of PreviewDetector in a test file. The constructor call is changed to pass a FlutterProject object via the project parameter, instead of passing a Directory object via the projectRoot parameter. This change aligns with a refactoring of the PreviewDetector constructor.

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 18, 2025
@auto-submit auto-submit bot merged commit b6b38b4 into flutter-3.39-candidate.0 Nov 18, 2025
146 checks passed
@auto-submit auto-submit bot deleted the i178679-project-param branch November 18, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkonyi bkonyi bkonyi approved these changes

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reidbaker @bkonyi @fluttergithubbot