Make sure that a CupertinoContextMenu doesn't crash in 0x0 environment #178722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request aims to fix a crash in CupertinoContextMenu when it has a zero size. A test case has been added to reproduce this scenario. However, the test does not seem to trigger the crash condition as it doesn't simulate opening the context menu. Additionally, the fix for the underlying division-by-zero issue appears to be missing from this pull request. I've suggested an update to the test to correctly validate the fix.
Comment on lines
+1544
to
+1558
| testWidgets('CupertinoContextMenu does not crash at zero area', (WidgetTester tester) async { | ||
| await tester.pumpWidget( | ||
| CupertinoApp( | ||
| home: Center( | ||
| child: SizedBox.shrink( | ||
| child: CupertinoContextMenu( | ||
| actions: const <Widget>[Text('X'), Text('Y')], | ||
| child: const Text('Y'), | ||
| ), | ||
| ), | ||
| ), | ||
| ), | ||
| ); | ||
| expect(tester.getSize(find.byType(CupertinoContextMenu)), Size.zero); | ||
| }); |
Contributor
There was a problem hiding this comment.
This test doesn't fully cover the scenario described in the issue. The crash occurs when the context menu is opened via a long press, but this test only verifies that the widget can be pumped without crashing. To ensure the fix is effective, the test should also simulate opening the context menu, which would trigger the code path that causes the division-by-zero error.1
testWidgets('CupertinoContextMenu does not crash at zero area', (WidgetTester tester) async {
await tester.pumpWidget(
CupertinoApp(
home: Center(
child: SizedBox.shrink(
child: CupertinoContextMenu(
actions: const <Widget>[Text('X'), Text('Y')],
child: const Text('Y'),
),
),
),
),
);
expect(tester.getSize(find.byType(CupertinoContextMenu)), Size.zero);
// Trigger the context menu to ensure it doesn't crash.
await tester.longPress(find.byType(CupertinoContextMenu));
await tester.pump(); // Let animations start.
// The test passes if it doesn't crash.
});Style Guide References
Footnotes
Contributor
There was a problem hiding this comment.
+1, the context menu is activated when its child is long pressed.
Contributor
Author
There was a problem hiding this comment.
Applying this produces:
Finder specifies a widget that would not receive pointer events.
A call to longPress() with finder "Found 1 widget with type "CupertinoContextMenu": [
CupertinoContextMenu(state: _CupertinoContextMenuState#6f93c(tickers: tracking 1 ticker)),
]" derived an Offset (Offset(400.0, 300.0)) that would not hit test on the specified widget.
Maybe the widget is actually off-screen, or another widget is obscuring it, or the widget cannot
receive pointer events.
dkwingsmt
approved these changes
Nov 19, 2025
Contributor
dkwingsmt
left a comment
dkwingsmt
left a comment
There was a problem hiding this comment.
Although this widget is basically an overlay, I think it has no way to open programatically and thus we can't test the overlay at zero area.
victorsanni
reviewed
Nov 20, 2025
Comment on lines
+1544
to
+1558
| testWidgets('CupertinoContextMenu does not crash at zero area', (WidgetTester tester) async { | ||
| await tester.pumpWidget( | ||
| CupertinoApp( | ||
| home: Center( | ||
| child: SizedBox.shrink( | ||
| child: CupertinoContextMenu( | ||
| actions: const <Widget>[Text('X'), Text('Y')], | ||
| child: const Text('Y'), | ||
| ), | ||
| ), | ||
| ), | ||
| ), | ||
| ); | ||
| expect(tester.getSize(find.byType(CupertinoContextMenu)), Size.zero); | ||
| }); |
Contributor
There was a problem hiding this comment.
+1, the context menu is activated when its child is long pressed.
| version: "2.2.2" | ||
| sdks: | ||
| dart: ">=3.9.0 <4.0.0" | ||
| dart: ">=3.11.0-88.0.dev <4.0.0" |
Contributor
There was a problem hiding this comment.
This should be reverted?
ahmedsameha1
force-pushed
the
handle#6537-CupertinoContextMenu
branch
from
0781f1c to
0600d9b
Compare
victorsanni
approved these changes
Nov 22, 2025
victorsanni
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 22, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 22, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Nov 22, 2025
flutter/flutter@d438df3...c8cfb2b 2025-11-22 [email protected] Revert "[ios] Dynamic Content Resizing" (flutter/flutter#178958) 2025-11-22 [email protected] Make sure that a SearchAnchor doesn't crash in 0x0 environment (flutter/flutter#177749) 2025-11-22 [email protected] Make sure that a Stepper doesn't crash in 0x0 environment (flutter/flutter#178068) 2025-11-22 [email protected] Remove deprecated `activeColor` in `switch.0.dart` example (flutter/flutter#178293) 2025-11-22 [email protected] Make sure that a UserAccountsDrawerHeader doesn't crash in 0x0 enviro… (flutter/flutter#178516) 2025-11-22 [email protected] Make sure that a TimePickerDialog doesn't crash in 0x0 environment (flutter/flutter#178451) 2025-11-22 [email protected] Make sure that a CupertinoLinearActivityIndicator doesn't crash in 0x… (flutter/flutter#178566) 2025-11-22 [email protected] Make sure that a CupertinoTabBar doesn't crash in 0x0 environment (flutter/flutter#178613) 2025-11-22 [email protected] Make sure that a CupertinoContextMenu doesn't crash in 0x0 environment (flutter/flutter#178722) 2025-11-22 [email protected] Sort entries in TESTOWNERS (flutter/flutter#178939) 2025-11-22 [email protected] [ios] Dynamic Content Resizing (flutter/flutter#177410) 2025-11-21 [email protected] Roll Skia from dc88b21ce7d2 to 3018c3053490 (2 revisions) (flutter/flutter#178947) 2025-11-21 [email protected] Manually roll material_color_utilities (flutter/flutter#170000) 2025-11-21 [email protected] Roll Fuchsia Linux SDK from Y-cMdgKy3d6EnibWR... to 4ul9jvZ7jnDGIjtCD... (flutter/flutter#178934) 2025-11-21 [email protected] Roll Dart SDK from c788b6a7aefd to 5af71c736b0a (1 revision) (flutter/flutter#178932) 2025-11-21 [email protected] Roll Skia from c588bb60d5da to dc88b21ce7d2 (2 revisions) (flutter/flutter#178933) 2025-11-21 [email protected] Update .ci.yaml and TESTOWNERS for arc macrobenchmark tests (flutter/flutter#178891) 2025-11-21 [email protected] Use interactive mode with `devicectl` to redirect stdout (flutter/flutter#178405) 2025-11-21 [email protected] Update .ci.yaml in flutter/flutter to use either macOS 15.5 or macOS … (flutter/flutter#178666) 2025-11-21 [email protected] Roll Skia from d4e9d2873bfd to c588bb60d5da (1 revision) (flutter/flutter#178928) 2025-11-21 [email protected] Roll Packages from b1e2fb0 to e67b6be (7 revisions) (flutter/flutter#178927) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Dec 2, 2025
flutter#178722) This is my attempt to handle flutter#6537 for the CupertinoContextMenu widget.
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
flutter#178722) This is my attempt to handle flutter#6537 for the CupertinoContextMenu widget.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to handle #6537 for the CupertinoContextMenu widget.