Skip to content

Conversation

@bkonyi
Copy link
Contributor

@bkonyi bkonyi commented Nov 17, 2025

Fixes #178677

@bkonyi bkonyi requested a review from reidbaker November 17, 2025 21:22
@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 17, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the constructor call for PreviewDetector in a regression test. The change replaces the projectRoot argument with a project argument, which aligns the test with an update to the PreviewDetector constructor signature. This resolves an analysis error in the test file. The change is correct and I have no further feedback.

@reidbaker
Copy link
Contributor

reidbaker commented Nov 17, 2025

Do you know why this didn't fail pre submit?

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 17, 2025
@bkonyi
Copy link
Contributor Author

bkonyi commented Nov 17, 2025

Do you know why this didn't fail pre submit?

One of the other CPs changed the arguments.

@auto-submit auto-submit bot merged commit 8311571 into flutter-3.38-candidate.0 Nov 17, 2025
146 checks passed
@auto-submit auto-submit bot deleted the fix_arg_mismatch branch November 17, 2025 22:13
reidbaker added a commit that referenced this pull request Nov 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 19, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 19, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants