Skip to content

[ Tool ] Remove --no-sandbox when launching web apps on Chrome device #178670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 8 commits into from
Nov 27, 2025
Merged

[ Tool ] Remove --no-sandbox when launching web apps on Chrome device #178670

auto-submit merged 8 commits into from
Nov 27, 2025
+14 −4

Conversation

@bkonyi
Copy link
Contributor

@bkonyi bkonyi commented Nov 17, 2025

Fixes #175227

@bkonyi bkonyi requested review from jyameo and mdebbar November 17, 2025 20:02
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 17, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 17, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the --no-sandbox flag when launching Chrome for web applications. This change is motivated by the fact that this flag is no longer necessary and might be causing issues on ChromeOS. The change is correctly applied in packages/flutter_tools/lib/src/web/chrome.dart, and the corresponding test constant in packages/flutter_tools/test/web.shard/chrome_test.dart is updated to reflect this change. The changes are correct and look good.

@mdebbar
Copy link
Contributor

mdebbar commented Nov 17, 2025

Is --no-sandbox not needed in headless mode anymore?

@bkonyi
Copy link
Contributor Author

bkonyi commented Nov 17, 2025

Is --no-sandbox not needed in headless mode anymore?

I think it is, I just missed moving --no-sandbox back into the set of flags added when headless is true. Fixed.

mdebbar
mdebbar approved these changes Nov 18, 2025
View reviewed changes
Copy link
Contributor

@mdebbar mdebbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pubspec.lock
version: "2.2.2"
sdks:
dart: ">=3.9.0 <4.0.0"
dart: ">=3.11.0-88.0.dev <4.0.0"
Copy link
Contributor

@mdebbar mdebbar Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change intentional?

Copy link
Contributor Author

@bkonyi bkonyi Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. I thought I had reverted it 🤦

@bkonyi bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 18, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 18, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Nov 18, 2025

autosubmit label was removed for flutter/flutter/178670, because - The status or check suite Mac run_debug_test_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite Mac_arm64 build_tests_3_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@bkonyi bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 18, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 18, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Nov 18, 2025

autosubmit label was removed for flutter/flutter/178670, because - The status or check suite Linux web_long_running_tests_3_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@bkonyi bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 18, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Nov 18, 2025

autosubmit label was removed for flutter/flutter/178670, because - The status or check suite Mac tool_integration_tests_5_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 18, 2025
jyameo
jyameo approved these changes Nov 18, 2025
View reviewed changes
Copy link
Contributor

@jyameo jyameo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bkonyi bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 25, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 25, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Nov 25, 2025

autosubmit label was removed for flutter/flutter/178670, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR.

@bkonyi bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 25, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Nov 26, 2025
Merged via the queue into master with commit 17b4542 Nov 27, 2025
146 of 147 checks passed
@auto-submit auto-submit bot deleted the remove_no_sandbox branch November 27, 2025 02:44
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 27, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 27, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 27, 2025
@engine-flutter-autoroll
17b454204 [ Tool ] Remove --no-sandbox when launching web apps on Chr…
52d09b4 
…ome device (flutter/flutter#178670)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Nov 27, 2025
@engine-flutter-autoroll
Roll Flutter from 7b98d50631e5 to 022b155d1b76 (20 revisions) (#10530)
c8be05d 
flutter/flutter@7b98d50...022b155

2025-11-27 [email protected] Make tree green again by fixing lints (flutter/flutter#179186)
2025-11-26 [email protected] Add shared Darwin implementation for plugins (flutter/flutter#176495)
2025-11-26 [email protected] Fixed changing supportedLocales fails to update the locale (flutter/flutter#178526)
2025-11-26 [email protected] [ Tool ] Remove --no-sandbox when launching web apps on Chrome device (flutter/flutter#178670)
2025-11-26 [email protected] Build hooks: Don't require toolchain for unit tests (flutter/flutter#178954)
2025-11-26 [email protected] Fix a small typo in `HandlerCompat.java` docs (flutter/flutter#178595)
2025-11-26 [email protected] Roll Fuchsia Linux SDK from nzuAxCJGeJbkZCTkr... to _e9MNK4nfBOrERVP_... (flutter/flutter#179130)
2025-11-26 [email protected] Make sure that a CupertinoActivityIndicator doesn't crash in 0x0 envi… (flutter/flutter#178565)
2025-11-26 [email protected] [native assets] Bump minimum iOS version from 12 to 13 (flutter/flutter#179079)
2025-11-26 [email protected] Documents and fixes behavior when clipping background filter fragment shader (flutter/flutter#178940)
2025-11-26 [email protected] Replace the hardcoded link with an actual link tag in `PlatformChannel.java‎` docs (flutter/flutter#178588)
2025-11-26 [email protected] Roll Packages from cc3dca6 to 5d8d954 (5 revisions) (flutter/flutter#179140)
2025-11-26 [email protected] Add more templates that the UIScene migrator can match against (flutter/flutter#179044)
2025-11-26 [email protected] Remove deprecated activeColor in `dynamic_content_color.0.dart`‎ example (flutter/flutter#178961)
2025-11-26 [email protected] Remove deprecated `activeColor` in `decorated_sliver.1.dart‎` example (flutter/flutter#178959)
2025-11-26 [email protected] Small refactor in `PlayStoreDeferredComponentManager.java‎` (flutter/flutter#178586)
2025-11-26 [email protected] Roll Dart SDK from 9e605f706cdf to 1d8dc04bd1d7 (4 revisions) (flutter/flutter#179080)
2025-11-26 [email protected] Fix error when generating pt_BR localizations (flutter/flutter#175832)
2025-11-26 [email protected] Roll Fuchsia Test Scripts from JUeFbA8y0E-_pj-bg... to MHF-UAfO6sVKqSEYk... (flutter/flutter#179151)
2025-11-26 [email protected] Add flutter_lints to samples (flutter/flutter#179091)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@bkonyi bkonyi added cp: beta cherry pick this pull request to beta release candidate branch cp: stable cherry pick this pull request to stable release candidate branch labels Nov 27, 2025
flutteractionsbot pushed a commit to flutteractionsbot/flutter that referenced this pull request Nov 27, 2025
@bkonyi
[ Tool ] Remove --no-sandbox when launching web apps on Chrome device (…
100a494 
…flutter#178670)

Fixes flutter#175227
flutteractionsbot pushed a commit to flutteractionsbot/flutter that referenced this pull request Nov 27, 2025
@bkonyi
[ Tool ] Remove --no-sandbox when launching web apps on Chrome device (…
ac7d711 
…flutter#178670)

Fixes flutter#175227
mboetger pushed a commit to mboetger/flutter that referenced this pull request Dec 2, 2025
@bkonyi @mboetger
[ Tool ] Remove --no-sandbox when launching web apps on Chrome device (…
bc8ee64 
…flutter#178670)

Fixes flutter#175227
reidbaker pushed a commit to AbdeMohlbi/flutter that referenced this pull request Dec 10, 2025
@bkonyi @reidbaker
[ Tool ] Remove --no-sandbox when launching web apps on Chrome device (…
da6e55d 
…flutter#178670)

Fixes flutter#175227
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdebbar mdebbar mdebbar approved these changes

@jyameo jyameo jyameo approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cp: beta cherry pick this pull request to beta release candidate branch cp: stable cherry pick this pull request to stable release candidate branch tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Getting a warning on Web: You are using an unsupported command-line flag: --no-sandbox. Stability and security will suffer.

3 participants

@bkonyi @mdebbar @jyameo