Potentially fixing the flakiness in win32 windowing tests, but it needs some running #178499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces several good changes to improve the reliability of the windowing tests. Wrapping the driver extension handler in a try-catch block and adding timeouts to awaitNotification and driver.waitFor are excellent measures to prevent tests from hanging and to improve error logging. The introduction of a _requestDataWithRetry helper on the test side is also a solid strategy to handle transient failures. My main feedback is to enhance the retry logic to also handle application-level errors returned from the driver extension, which will make the tests even more robust and easier to debug.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 24, 2025
…but it needs some running (flutter/flutter#178499)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 24, 2025
…but it needs some running (flutter/flutter#178499)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Nov 24, 2025
flutter/flutter@c8cfb2b...3f553f6 2025-11-24 [email protected] Roll Skia from 1cbc0e6a7d21 to 43d2020be565 (7 revisions) (flutter/flutter#179010) 2025-11-24 [email protected] Potentially fixing the flakiness in win32 windowing tests, but it needs some running (flutter/flutter#178499) 2025-11-24 [email protected] Roll Skia from ee2cd2c06cf7 to 1cbc0e6a7d21 (1 revision) (flutter/flutter#178995) 2025-11-24 [email protected] Roll Fuchsia Linux SDK from lJTlAwQY4MnuRuORC... to pOO9Jl9HTLsEmks6y... (flutter/flutter#178994) 2025-11-23 [email protected] Roll Dart SDK from a1422c6f8aa1 to 24cc9a740bd3 (1 revision) (flutter/flutter#178992) 2025-11-23 [email protected] Roll Skia from 6592e75d6f7e to ee2cd2c06cf7 (1 revision) (flutter/flutter#178990) 2025-11-23 [email protected] Roll Skia from fb6c00107a51 to 6592e75d6f7e (5 revisions) (flutter/flutter#178985) 2025-11-22 [email protected] Roll Fuchsia Linux SDK from 4ul9jvZ7jnDGIjtCD... to lJTlAwQY4MnuRuORC... (flutter/flutter#178971) 2025-11-22 [email protected] Roll Dart SDK from c44cf2015e3d to a1422c6f8aa1 (2 revisions) (flutter/flutter#178968) 2025-11-22 [email protected] Roll Skia from 3018c3053490 to fb6c00107a51 (4 revisions) (flutter/flutter#178952) 2025-11-22 [email protected] Roll Dart SDK from 5af71c736b0a to c44cf2015e3d (1 revision) (flutter/flutter#178953) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
agrapine
pushed a commit
to swipelab/flutter_packages
that referenced
this pull request
Nov 26, 2025
…r#10510) flutter/flutter@c8cfb2b...3f553f6 2025-11-24 [email protected] Roll Skia from 1cbc0e6a7d21 to 43d2020be565 (7 revisions) (flutter/flutter#179010) 2025-11-24 [email protected] Potentially fixing the flakiness in win32 windowing tests, but it needs some running (flutter/flutter#178499) 2025-11-24 [email protected] Roll Skia from ee2cd2c06cf7 to 1cbc0e6a7d21 (1 revision) (flutter/flutter#178995) 2025-11-24 [email protected] Roll Fuchsia Linux SDK from lJTlAwQY4MnuRuORC... to pOO9Jl9HTLsEmks6y... (flutter/flutter#178994) 2025-11-23 [email protected] Roll Dart SDK from a1422c6f8aa1 to 24cc9a740bd3 (1 revision) (flutter/flutter#178992) 2025-11-23 [email protected] Roll Skia from 6592e75d6f7e to ee2cd2c06cf7 (1 revision) (flutter/flutter#178990) 2025-11-23 [email protected] Roll Skia from fb6c00107a51 to 6592e75d6f7e (5 revisions) (flutter/flutter#178985) 2025-11-22 [email protected] Roll Fuchsia Linux SDK from 4ul9jvZ7jnDGIjtCD... to lJTlAwQY4MnuRuORC... (flutter/flutter#178971) 2025-11-22 [email protected] Roll Dart SDK from c44cf2015e3d to a1422c6f8aa1 (2 revisions) (flutter/flutter#178968) 2025-11-22 [email protected] Roll Skia from 3018c3053490 to fb6c00107a51 (4 revisions) (flutter/flutter#178952) 2025-11-22 [email protected] Roll Dart SDK from 5af71c736b0a to c44cf2015e3d (1 revision) (flutter/flutter#178953) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bufffun
pushed a commit
to bufffun/flutter
that referenced
this pull request
Nov 26, 2025
…ds some running (flutter#178499) Adding some more logging and retrying mechanisms to the win32 windowing tests to see if it fixes the flakiness. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Dec 2, 2025
…ds some running (flutter#178499) Adding some more logging and retrying mechanisms to the win32 windowing tests to see if it fixes the flakiness. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
…ds some running (flutter#178499) Adding some more logging and retrying mechanisms to the win32 windowing tests to see if it fixes the flakiness. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 11, 2025
Reverts #176063 Fixes: #179667 Git bisect: ``` ❯ git bisect log # bad: [5b74a3b] Check for a null cached image in SingleFrameCodec::getNextFrame (#179483) # good: [66dd93f] Bump engine version for Flutter 3.38.4 stable hotfix. (#179424) git bisect start 'master' 'flutter-3.38-candidate.0' # good: [df87ee3] Roll Skia from d10a0d877ff4 to ea7cdbc6b986 (15 revisions) (#176686) git bisect good df87ee3 # good: [951b25d] Check for devicectl launch logs from std and file (#178167) git bisect good 951b25d # good: [337bbfb] Potentially fixing the flakiness in win32 windowing tests, but it needs some running (#178499) git bisect good 337bbfb # good: [8e952d6] Roll Skia from c20f797ab6f9 to 81a9a0751f00 (5 revisions) (#179417) git bisect good 8e952d6 # good: [723fec5] Roll Skia from e19670f70406 to dccd48c6c6ab (6 revisions) (#179524) git bisect good 723fec5 # bad: [96c6525] Roll Dart SDK from 3c07646cdcb9 to 019cb923bf62 (1 revision) (#179595) git bisect bad 96c6525 # good: [4000ce2] Implementation of `TestWindowingOwner` for testing multi-window (#179355) git bisect good 4000ce2 # good: [26f311c] Roll Dart SDK from 75899721aa42 to 3c07646cdcb9 (1 revision) (#179587) git bisect good 26f311c # bad: [8cc9fee] Roll Skia from b1936c760645 to 00e6fc407968 (5 revisions) (#179589) git bisect bad 8cc9fee # bad: [b37b6fa] Change GenerateFilledArcStrip to use non-overlapping triangles (#179292) git bisect bad b37b6fa # bad: [f197a3a] Android implementation of content sizing (#176063) git bisect bad f197a3a # first bad commit: [f197a3a] Android implementation of content sizing (#176063) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some more logging and retrying mechanisms to the win32 windowing tests to see if it fixes the flakiness.
Pre-launch Checklist
///).