-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Add 3.38.1 release notes #178493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 3.38.1 release notes #178493
Conversation
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds the release notes for Flutter version 3.38.1, which includes support for Dart 3.10 stable. My review includes one suggestion to rephrase the release note to better align with the project's hotfix documentation best practices by describing the problem from a user's perspective rather than describing the implementation.
|
|
||
| ### [3.38.1](https://github.com/flutter/flutter/releases/tag/3.38.1) | ||
|
|
||
| - [flutter/178400](https://github.com/flutter/flutter/issues/178400) Adds support for Dart 3.10 stable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To better align with the hotfix documentation best practices, this release note should describe the problem from a user's perspective rather than describing the change. The current message describes the action taken ('Adds support...'), but the guide suggests describing the problem that is being solved. For example, what a user would experience without this fix.
| - [flutter/178400](https://github.com/flutter/flutter/issues/178400) Adds support for Dart 3.10 stable. | |
| - [flutter/178400](https://github.com/flutter/flutter/issues/178400) Flutter apps fail to build when using the Dart 3.10 stable SDK. |
justinmc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
ad76f2b
into
flutter:flutter-3.38-candidate.0
Retroactively adding this note. Sadly these will be release in the next hotfix, but they will be available on master once #178487 lands.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.