[CP-stable][ Tool ] Only process a single unhandled tool exception #178469
Conversation
Without this change, if multiple asynchronous exceptions are thrown while processing an exception, multiple exception analytics events can be sent for a single process crash, skewing crashlytics data. Fixes flutter#178318
|
@bkonyi please fill out the PR description above, afterwards the release team will review this request. |
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
github-actions
bot
added
the
tool
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses an issue where multiple unhandled tool exceptions could be processed concurrently, potentially leading to multiple crash reports for a single incident. The fix introduces a mechanism to ensure that the tool's error handling logic is executed only once for the first unhandled exception, ignoring subsequent ones during the shutdown process. This is achieved by using a global Future that acts as a lock. The state is reset on each run to prevent leaks, which is particularly important for testing.
A new test case has been added to validate this behavior. It simulates a command that throws multiple asynchronous exceptions and asserts that only a single crash analytics event is sent.
The implementation is clean, effective, and the accompanying test provides good coverage for the fix. The changes look solid and correctly solve the problem.
reidbaker
added
the
autosubmit
auto-submit
bot
merged commit b473856
into
flutter:flutter-3.38-candidate.0
3 participants
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
What is the link to the issue this cherry-pick is addressing?
#178318
Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See best practices for examples
Certain
fluttercrash scenarios can result in multiple crash reports being submitted for a single process crash.Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
Crash analytics data can be skewed to make certain bugs appear much more severe then they actually are.
Workaround:
Is there a workaround for this issue?
Don't crash? :)
Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
What are the steps to validate that this fix works?
Run attached unit test.