fix: infra out of resources #178387
Merged
fix: infra out of resources #178387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mac bots in device lab were upgraded to 15.7; which no longer matches ci.yaml question for future: is there a better option for this other than pinning? fixes: flutter#178384
jtmcdole
added
the
emergency
|
Detected the If you add the The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue". |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the CI configuration in .ci.yaml to add Mac-15.7 to the list of supported operating systems. This change directly addresses an issue where CI jobs were failing due to a mismatch with upgraded Mac bots. My review includes a suggestion to improve the long-term maintainability of this configuration by investigating more flexible OS version matching to prevent similar issues in the future.
| {"dependency": "open_jdk", "version": "version:21"} | ||
| ] | ||
| os: Mac-15.1|Mac-15.5|Mac-15.6 | ||
| os: Mac-15.1|Mac-15.5|Mac-15.6|Mac-15.7 |
Contributor
There was a problem hiding this comment.
While this fixes the immediate problem, pinning specific minor OS versions is brittle and requires manual updates for each new version, as you noted in the description. To improve maintainability, it would be ideal to use a more flexible pattern if the CI system supports it. For instance, a wildcard like Mac-15.* or specifying only the major version could make this configuration more resilient to future OS upgrades on the bots.
zanderso
approved these changes
Nov 12, 2025
vashworth
approved these changes
Nov 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 12, 2025
jtmcdole
added
the
cp: beta
flutteractionsbot
pushed a commit
to flutteractionsbot/flutter
that referenced
this pull request
Nov 12, 2025
Mac bots in device lab were upgraded to 15.7; which no longer matches ci.yaml question for future: is there a better option for this other than pinning? fixes: flutter#178384
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 12, 2025
jtmcdole
added a commit
to jtmcdole/flutter
that referenced
this pull request
Nov 12, 2025
Mac bots in device lab were upgraded to 15.7; which no longer matches ci.yaml question for future: is there a better option for this other than pinning? fixes: flutter#178384
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 16, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 16, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 16, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2025
IvoneDjaja
pushed a commit
to IvoneDjaja/flutter
that referenced
this pull request
Nov 22, 2025
Mac bots in device lab were upgraded to 15.7; which no longer matches ci.yaml question for future: is there a better option for this other than pinning? fixes: flutter#178384
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Dec 2, 2025
Mac bots in device lab were upgraded to 15.7; which no longer matches ci.yaml question for future: is there a better option for this other than pinning? fixes: flutter#178384
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
Mac bots in device lab were upgraded to 15.7; which no longer matches ci.yaml question for future: is there a better option for this other than pinning? fixes: flutter#178384
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mac bots in device lab were upgraded to 15.7; which no longer matches ci.yaml
question for future: is there a better option for this other than pinning?
fixes: #178384